Re: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty list

["Zeng, Star" <star.zeng@intel.com>]

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com> 
Sent: Wednesday, September 16, 2020 8:21 PM
To: devel@edk2.groups.io; gaoliming@byosoft.com.cn
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize IncLines as empty list


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> gaoliming
> Sent: Wednesday, September 16, 2020 5:58 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L 
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2-devel] [PATCH] IntelFsp2Pkg GenCfgOpt.py: Initialize 
> IncLines as empty list
> 
> IncLines as empty list for the case when InputHeaderFile is not specified.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  IntelFsp2Pkg/Tools/GenCfgOpt.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py 
> b/IntelFsp2Pkg/Tools/GenCfgOpt.py index e9de128e..bcced590 100644
> --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> @@ -1177,6 +1177,7 @@ EndList
>          UpdSignatureCheck = ['FSPT_UPD_SIGNATURE', 
> 'FSPM_UPD_SIGNATURE', 'FSPS_UPD_SIGNATURE']
>          ExcludedSpecificUpd = ['FSPT_ARCH_UPD', 'FSPM_ARCH_UPD', 
> 'FSPS_ARCH_UPD']
> 
> +        IncLines = []
>          if InputHeaderFile != '':
>              if not os.path.exists(InputHeaderFile):
>                   self.Error = "Input header file '%s' does not exist" 
> % InputHeaderFile
> --
> 2.27.0.windows.1
> 
> 
> 
>