From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.3315.1588299766625732477 for ; Thu, 30 Apr 2020 19:22:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=P4+9TMpA; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: star.zeng@intel.com) IronPort-SDR: 3kjg3CSkZQYV9cr6miqcGu6Cl4VVaVQfZIzPIsqkpiwtK11bws5e3ka15TnuWUAYc1lv3OqUn/ gdgvuIJCV9kQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 19:22:46 -0700 IronPort-SDR: gaQtfFfOoIjHIg0sOT3BQcjbTu1ECi3A9qUPrkWus5QhBybeLDzPO/P8AphwYeWR/b32mDFdto MVxw44wgt/oA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,338,1583222400"; d="scan'208";a="294708651" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 30 Apr 2020 19:22:45 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 19:22:45 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 19:22:45 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 19:22:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DFrxgUYEYjLwyCzpn45DIAVAbL2rJ98h+yXvVPlObNKLdXqOtA4t+nFvNg3btsrur0mpa8B4OSrAJAcZPkrNNoZiz8PUEtAVsouh9HJYdAHZHZN59iNZKQgPWo3q3//hHazJHeA+dY+LMCUHH1Opy6ukm+kikovPLmkI3TFuMTXRLCjTSvJhi28z6bYQprrw+CKDY99mtJFp0y/nDKqIIwIH4+v8R9RELDD8DaGKuKEr1O9PXw9UMCOr3TBdijuWaH6UrJn0mhhO3clf6N+ViKVxu50lucyUsfB4Oy+6AXV0aV59VuGRrRGp3V4sF3mgFgvAsQkG4HZzA38jfV67rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G0q76rzs22YxCa7ilnb3DFQYKKQMRoZ8ME4THL+X3Zk=; b=nSD0ffu4PHQMVY2qnQ/e4HimCzC1YqHNl60BkVgiGsvTf2oCPOnO76PTsXtHdM34CjZmApB2osEZlT0XUrUthAjrIw++MXOM14rG6gCkj5/HeXFLoSW8tJXNWhpIzGmTSejaW+dFvQjITFlkTpYjVy9jZMS3IQyRgMX+AJHo7hdWg7Hitu5QrNSg9whZ9L2AEEY3iJtpHLhWOQL1oDNRte6WUpV/CuFUeCwfPyS2ch5/NYhOuq5E0f19yCIQpTXTQDgtCckzWMyywrvsJUhqgtR/iQnNN0+pmghnNtyfQDup6DthLffjAb0dwVImJQGRBQGtIjzrd+s1gC7vHmeMLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G0q76rzs22YxCa7ilnb3DFQYKKQMRoZ8ME4THL+X3Zk=; b=P4+9TMpAZdsIIgjU+hG62o8xA8AIUwa/AqTFd7w6PKJJ8BX5PWIE0DsQwvhxw0xWEliV5ChEm/7BCHPGhvJ1GHlo5uycxb+WknuNjsC9G6Nr3He9zXpAZkT/1vLx1ptomNFwkt5MT9IEe3cozX7myYxyC2om5HVCNMKzowM/jFE= Received: from DM6PR11MB4058.namprd11.prod.outlook.com (2603:10b6:5:193::13) by DM6PR11MB2619.namprd11.prod.outlook.com (2603:10b6:5:c6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Fri, 1 May 2020 02:22:43 +0000 Received: from DM6PR11MB4058.namprd11.prod.outlook.com ([fe80::dd9d:71c0:79f2:c3e3]) by DM6PR11MB4058.namprd11.prod.outlook.com ([fe80::dd9d:71c0:79f2:c3e3%7]) with mapi id 15.20.2958.019; Fri, 1 May 2020 02:22:43 +0000 From: "Zeng, Star" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Ma, Maurice" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase silicon initialization. Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase silicon initialization. Thread-Index: AQHWHpAEdgTn20ddOU+ACL8vnGZWQaiRsemAgADPotA= Date: Fri, 1 May 2020 02:22:43 +0000 Message-ID: References: <20200430013745.18528-1-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.196] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 200bf760-5749-423d-0f57-08d7ed7687b7 x-ms-traffictypediagnostic: DM6PR11MB2619: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0390DB4BDA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4058.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(376002)(136003)(396003)(39860400002)(346002)(52536014)(19627235002)(9686003)(966005)(7696005)(55016002)(26005)(6506007)(4326008)(53546011)(66946007)(66446008)(76116006)(64756008)(66556008)(66476007)(5660300002)(71200400001)(478600001)(86362001)(8936002)(8676002)(316002)(33656002)(186003)(6636002)(2906002)(110136005)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gJ4qD3pNfjvn2vv3wJK06PR+s29R0BXw1u2z8abMDLSwiE52pwZTmJnXQX/RJ9tJdsu3mSX54pG4LdFAcNEg+rCV3iIFkGSHUv8j6ZoDEHStGHcFVo0rJO1og6nTeSzwuhbOl5YHlbJAoz4lXHF+9zdxx2gLNq8QwPzBnwQhyfyzB8HhS0wiBU1IadVdD5Pcwl1vruvYaSZd371sW2qwqSQ+W2H0e4QiJ7k530AS7frirSOCrNxzEHBDMvNSh5nN+IJVjruuW2hD3AlnoeOQZhhuPlNCPs8ptHXLk2YojZSZHf8LtfBqCLF2TiJ6QziGSpeGmBSw9RsbHBWp56c/5Ba7iqHkOMsQysvo0Kwe9nEzx0L/Sb9UKs32IIysfMTloSjfw2ipQeVFKWDlRzVVsTydJlP52AWi3sjJQxEyk5kl+UugqRYwrQUTMaRM2kv8aKByURdmKyup3rLswp/VTGAHgy147Pw8ZpA6GnYChLfEEccDhQh13Pe3AJ/Zwv8aorLZtqnY8dbObadk2CBDGA== x-ms-exchange-antispam-messagedata: 4wa9f7Ii4/2Pc07BOocWlfaX6nbh2uzmpdB9yDRFZ+ldHruw+yBk63sKX88e/entOiF5BAk5YNo8lN8pdbpJ2BMAv4fWJNXJxfLtsp5agYLo8plTxnxUFuhUCIpwgLM0Fyz6vAEycV1grSHSVOMEmfKJGfSQA8s73xRQZwZQ4VWks0qS1SylBroABb4TAgxZ4aIDJFj+ZUdVWafH+HiLSVUZicnqhlMndtl9UjgyXlw+hbzSKB8Tsn/XfDzeAyhAkWcqMkQ3XC1gNTZUSzGxlBst+3y+Lb0O5oE9NR+I/cm/jUK7hgjYjmc14ePsyF/kvnVVyGNLUjQ1he5HOlFTAH2tmtuVcJ/KzQWUVBu2Lf0mEKcdOok+j6rnn8KHV9nBYTTZGr1rYC+J3rCRib9pF62CU+p19L+xT0WE4SQUfpKU8q8hdv/rSRo1PBTs7vYihwZga+o2cCdCa+RCBJgfPgwap4DXFhZ6sdv+klz6Po4Xjiz2/rSQTSguwmmV024DH25aGc+46qMwzfW2SSXVK5W25q/K57cd8WJHeCeUatxgF/fyV775XiEvlAav6NKJEUPSrWu6OKRPOZjrKGbtrcSJbCtHxUL+sJ8IpK83jMXSKWQM4vHLBCN0UjtnTRRw2OOssxqTGm6Kl4BgqoPbCImsu4Xxmo0in3a1/dNOSWW1eTbTbxS52rahnSd6F716zoTj97Vocwju6NIqFgBpgAoxZxhBGYAsI3UBvVFDiMKzJ4+QptvS5YG1LEj4nBRCBSRbxnXmYVA3Ftlg9KAGXPGXAyz8iXmsR133iJVQs+I= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 200bf760-5749-423d-0f57-08d7ed7687b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2020 02:22:43.3020 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ixB4bC686nvGnHFUwb/oKT5n2nMxV7/HOP8vsjgzrvD9jm2Lnct+e9+qemm95fk5efGqbMpPXUjDUF6kGpGqdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2619 Return-Path: star.zeng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Friday, May 1, 2020 5:59 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Ma, Maurice ; Zeng, Star > Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase sili= con > initialization. >=20 > Reviewed-by: Nate DeSimone >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Wednesday, April 29, 2020 6:38 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase silicon > initialization. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2698 >=20 > To enhance FSP silicon initialization flexibility an optional Multi-Phas= e API is > introduced and FSP header needs update for new API offset. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Include/Guid/FspHeaderFile.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > index 16f43a1273..3474bac1de 100644 > --- a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > +++ b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > @@ -1,8 +1,8 @@ > /** @file > Intel FSP Header File definition from Intel Firmware Support Package > External > - Architecture Specification v2.0. > + Architecture Specification v2.0 and above. >=20 > - Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved. > + Copyright (c) 2014 - 2020, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -110,6 +110,12 @@ typedef struct { > /// Byte 0x44: The offset for the API to initialize the CPU and chips= et. > /// > UINT32 FspSiliconInitEntryOffset; > + /// > + /// Byte 0x48: Offset for the API for the optional Multi-Phase proces= sor > and chipset initialization. > + /// This value is only valid if FSP HeaderRevision is >=3D= 5. > + /// If the value is set to 0x00000000, then this API is no= t > available in this component. > + /// > + UINT32 FspMultiPhaseSiInitEntryOffset; > } FSP_INFO_HEADER; >=20 > /// > -- > 2.13.3.windows.1 >=20 >=20 >=20 >=20