public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Chiu, Chasel" <chasel.chiu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ma, Maurice" <maurice.ma@intel.com>
Subject: Re: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.
Date: Thu, 11 Jun 2020 11:20:25 +0000	[thread overview]
Message-ID: <DM6PR11MB40585E65A30C081337851F7FE3800@DM6PR11MB4058.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR1101MB216039E0714FFC8DD6357AFCCD830@MWHPR1101MB2160.namprd11.prod.outlook.com>

Reviewed-by: Star Zeng <star.zeng@intel.com> with the copyright year correction.

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, June 11, 2020 4:35 AM
> To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.
> 
> Please fix copyright year. With that change...
> 
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Tuesday, June 9, 2020 7:33 PM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788
> 
> DSC is incomplete according to the established CI policies.
> Fsp22SecCoreS.inf needs to be added to the Components section for
> completeness.
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  IntelFsp2Pkg/IntelFsp2Pkg.dsc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.dsc
> index 02fe9cb188..9b5e38c5d9 100644
> --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc
> +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  # Provides driver and definitions to build fsp.
>  #
> -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2022, Intel Corporation. All rights
> +reserved.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  #  ## @@ -65,6 +65,7 @@
>    IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
>    IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
>    IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
> +  IntelFsp2Pkg/FspSecCore/Fsp22SecCoreS.inf
>    IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf
> 
>  [PcdsFixedAtBuild.common]
> --
> 2.13.3.windows.1


      reply	other threads:[~2020-06-11 11:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10  2:33 [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc Chiu, Chasel
2020-06-10  6:54 ` [edk2-devel] " Sean
2020-06-10 13:41   ` Chiu, Chasel
2020-06-10 20:35 ` Nate DeSimone
2020-06-11 11:20   ` Zeng, Star [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB40585E65A30C081337851F7FE3800@DM6PR11MB4058.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox