public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"pierre.gondois@arm.com" <pierre.gondois@arm.com>,
	"Bi, Dandan" <dandan.bi@intel.com>,
	"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>,
	"Alexei.Fedorov@arm.com" <Alexei.Fedorov@arm.com>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 0/2] Define AML_NAME_SEG_SIZE
Date: Wed, 2 Jun 2021 06:13:00 +0000	[thread overview]
Message-ID: <DM6PR11MB405864AE802837500A487295E33D9@DM6PR11MB4058.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210601220450.28003-1-Pierre.Gondois@arm.com>

Just like to give my RB: Reviewed-by: Star Zeng <star.zeng@intel.com>
Please also get the RB from maintainer. 😊


Thanks,
Star
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of PierreGondois
Sent: 2021年6月2日 6:05
To: devel@edk2.groups.io; Bi, Dandan <dandan.bi@intel.com>; gaoliming@byosoft.com.cn; Kinney, Michael D <michael.d.kinney@intel.com>; Sami.Mujawar@arm.com; Alexei.Fedorov@arm.com
Subject: [edk2-devel] [PATCH v1 0/2] Define AML_NAME_SEG_SIZE

From: Pierre Gondois <Pierre.Gondois@arm.com>

There is currently multiple AML_NAME_SEG_SIZE define in the edk2 repository. One in the MdeModulePkg and one in the DynamicTablesPkg package. Since the value can be inferred from the ACPI specification, it could be moved to MdePkg/Include/IndustryStandard/ and avoid re-definitions 

The two patches should be merged at once to avoid having multiple definitions of AML_NAME_SEG_SIZE.

The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1750_Add_AML_NAMESEG_SIZE_v1
The results of the CI can be seen at:
https://github.com/tianocore/edk2/pull/1681

Pierre Gondois (2):
  MdePkg/MdeModulePkg: Move AML_NAME_SEG_SIZE definition
  DynamicTablesPkg: Use AML_NAME_SEG_SIZE define

 .../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c  | 4 ++--
 .../AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c   | 4 ++--
 DynamicTablesPkg/Library/Common/AmlLib/AmlDefines.h      | 9 +--------
 MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiSdt.h       | 1 -
 MdePkg/Include/IndustryStandard/AcpiAml.h                | 7 ++++++-
 5 files changed, 11 insertions(+), 14 deletions(-)

--
2.17.1







  parent reply	other threads:[~2021-06-02  6:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 22:04 [PATCH v1 0/2] Define AML_NAME_SEG_SIZE PierreGondois
2021-06-01 22:04 ` [PATCH v1 1/2] MdePkg/MdeModulePkg: Move AML_NAME_SEG_SIZE definition PierreGondois
2021-06-02  2:28   ` 回复: " gaoliming
2021-06-01 22:04 ` [PATCH v1 2/2] DynamicTablesPkg: Use AML_NAME_SEG_SIZE define PierreGondois
2021-06-02  6:13 ` Zeng, Star [this message]
2021-06-02  8:33 ` [PATCH v1 0/2] Define AML_NAME_SEG_SIZE Sami Mujawar
2021-06-02 11:30 ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB405864AE802837500A487295E33D9@DM6PR11MB4058.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox