From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.7366.1622599506445221069 for ; Tue, 01 Jun 2021 19:05:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Fin3cGqE; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: star.zeng@intel.com) IronPort-SDR: 27SNlMtLK9G9rqvgL6cjrntPGfOT1hFbs04moaNCakfh3Nuh+l3yLnKKh/Jhgu0n8g4nzW61EP aDfGiRsKzlwQ== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="203496316" X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="203496316" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 19:05:05 -0700 IronPort-SDR: HQGUyL9DlZw9Vk2kL1b9BGBtHfes4M0sSx7pHU4ckaiKvvIMAiY1j4T7NGaIZUaJZGT7dz7B+x QPelerHT1V2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,241,1616482800"; d="scan'208";a="445547508" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 01 Jun 2021 19:05:05 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 19:05:05 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 19:05:04 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 1 Jun 2021 19:05:04 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 1 Jun 2021 19:05:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVx5xcc0pCyqDmQw4QFhSFaeqBXAYLcVC1gdXCjyEcfBUaluoLkhxhbV+4iq366vHlBdQTeCHMfft2/p4+JLM/rT8jHWj7Dzl4UcNgturc+HCbdxfnSrCD3eZpgG32+ttGB6AUn6WS4PfIvXzkhlaLBuC3GGqUNocs+UW4iD9vBJUmtg3b6apwLkUjHn+8kDI3fxyhABrSXKVIXPZpw5kWVhFiRO2lleh72puu94OPFYZ/SGLWhBsAneDqZDxozCcqjWNZ6gbj6cS6glS7MfTNmFpwGdpFQ/cf+9ftJwPrTVRB5RKBM4jdF+8eJYJYK2psmOFN7p+nrbu8IJpql9+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XkmQswTjFDv6qsAEVHXdaEFO1DR0rXovMjw73lXfGUk=; b=n2RdBB8sppnuXQP1tzWpaVKbCIxbQ8CmKWupnNDZABu3hWwa4cOneDAqkeHBdk1UiuoBkBsLr9BXneff9eJ5dwMSuz4//3PE+yN+HzQmmY5bRoMRuaTJTbxb9vp5Yqhm68f8vfPNwLsrfL1DPyENoRHZlhVzk6aTBPhZA6LbwsbF7u84s/zAdS0Y30ROzLr5BBYdL9V2hw1ounlgCaEa6AY0Fh56E5cGnwmCq+juuMaGczkkbwI/C9DJGaE9qDOfmIrNtFN3p+Lu2ego75157v9//OVD06S9E+snbM5e8lAP20g7+7LXlyQjB6WbNJ58UMxWzBduovW/aNClHkKyVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XkmQswTjFDv6qsAEVHXdaEFO1DR0rXovMjw73lXfGUk=; b=Fin3cGqEmb4OWyNBemrbENhAcxVK4s5oyjypcwmIuYDDLoK1oVNji5m0Gjnb4ZBumpf6kBRyrByVYGOSkmsGiw0Z9u6KY3G5zCUB1sf6v7T0JuGonLFyylOUzcE4Z7ZuexdUnvP7nNpDbxNnmXdA4b+FQP/tklAZyU0WO+sECoA= Received: from DM6PR11MB4058.namprd11.prod.outlook.com (2603:10b6:5:193::13) by DM5PR1101MB2218.namprd11.prod.outlook.com (2603:10b6:4:4f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Wed, 2 Jun 2021 02:05:02 +0000 Received: from DM6PR11MB4058.namprd11.prod.outlook.com ([fe80::e0fa:3702:94d4:c7c9]) by DM6PR11MB4058.namprd11.prod.outlook.com ([fe80::e0fa:3702:94d4:c7c9%3]) with mapi id 15.20.4173.030; Wed, 2 Jun 2021 02:05:02 +0000 From: "Zeng, Star" To: "devel@edk2.groups.io" , "Ni, Ray" , "Li, Daoxiang" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor location info Thread-Topic: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor location info Thread-Index: AQHXVvpAOHZIF64VzEW8VOBmGniZ6ar/+QLw Date: Wed, 2 Jun 2021 02:05:02 +0000 Message-ID: References: <20210601072451.1329-1-daoxiang.li@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd7e358d-30e7-4ab5-ec8e-08d9256ad572 x-ms-traffictypediagnostic: DM5PR1101MB2218: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JlCK7U9zKhqTVP+PAdFYE2Bb10Jj+EW5qL4xxAAvL2ajXecwRZcNp0UVSjo7YEsz0+Vb57yDO6r0AFwtqz9Yb2DE4kihNwtC9zEIp/U0OeuNHfPRuWCCskAeGEPgNycrrV2N5KDPAHyljGNql7LBhL/jXglOxE/bE/2U7YsmCmcNP4T4jUHSIpD3REfSlEHXSGKqsnC4fA6qrOmXwtoCgfWIJ1g4yLpaHVjQD/CTAxWoA8Isp32Vj/1TAAKxbDJSkRs5zHCBQaH2DngE67ItsUJM+ovMsiqWKCsgVSka372wvZKr5NAkks9X7pOV4mpb2tc05nM2PAteqqkUNzHe4IwHe2BkaIaLhNedl+TKHPy+Oo/Z+oL8yXfYb/wm4M7X6GC0FNigo5Iqbs7lOkfFe/w5y/mHRA3SI3f3qgTI3DsD73kTYNlcv2XT5XX6foecwaE3Uh3u/TnVQcSvheuYAyRkUd09uugeSQOLHPAdH7r/kpbwSORx2p1PSDBVLlKVEyKpbirnb58bE7wpL318osg0Evbg/EI4leQneVxJ8JBnzYuuNVj7SZgvu0NsxgfsH6y0BFBT/zR+F32yfC/rhxHlMbEOnCvAWFpIYZy6enYiOJL/DuNZ47+QqETfgxPUUFnTZ5BSt1KnBs5koxs57vK70enbV5CEugUlc4C/OGJbwlmS7GfmAwEXmI1KVBatkIh53HA+6FTQjR1+DnzXdQIgiuCw1b16PEFwTlZ43XnOLY4DTCXloiQJ99Vyq8Dk x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4058.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(39860400002)(396003)(346002)(376002)(15650500001)(9686003)(316002)(66946007)(53546011)(52536014)(55016002)(4326008)(8676002)(26005)(122000001)(66446008)(19627235002)(6506007)(54906003)(71200400001)(38100700002)(83380400001)(110136005)(5660300002)(66476007)(186003)(478600001)(966005)(76116006)(8936002)(7696005)(107886003)(66556008)(86362001)(6636002)(33656002)(2906002)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3ILjqEfpo3sfDvFXD2wMw5ogVuDuq4rY/T7ccqbLVaG4pifQbdU6XI9Mxn9H?= =?us-ascii?Q?36dIs+r78damjyyMn7ld7yawKLogdUZZRXO4g3d+blLrd70oIbR84fvDVQuT?= =?us-ascii?Q?+hCKxzmF1sFU14ae0i2IkssWXqnndtZWDiPVsKzbeq4oLIDkjiequZdKZVAU?= =?us-ascii?Q?fXKI1A1b6+foJQVQD+2YOuj5GSOayI6DOnV7gDH3gyIiRTvPOrnfNDs4YR+7?= =?us-ascii?Q?C2ZywhJOd0dSnrh6cRUSkkNjvquPFNLYDE61+n3tefiG2ozE37n79IjBwcFy?= =?us-ascii?Q?Z2r7yfPXDh4dZoyzB4fZQFGmMo88U3zl+4YsKLoPsIzGkp9mXgO66xM4PQDs?= =?us-ascii?Q?sqybDy+zU5xwf4eEAPq/LQ6mFhDqsEkumvGOcJzg6QAIWToqTainaP5kg3HU?= =?us-ascii?Q?KeD12Da5bt2Uz1IJ0OVcSjSro/RA+1ZtzEY2jyPKdan2lN18xEvzrPCdymJY?= =?us-ascii?Q?MQoXL/lPu257uQ0H5SZReOLoqjLETxLVvOvRBLsZkYSfdOeAR27YKVrDI8JF?= =?us-ascii?Q?Rec4HYrYEnwpBSjmFCI6OX6aIp2J4jhABEmo392fLra/fW8caeR0ixxgRlef?= =?us-ascii?Q?vt5P1gyguLY9S+euh0sRl2fMPku1dHNYptOtTOS/7YEkAHdcHnb3eDU5WrkW?= =?us-ascii?Q?haX7G/DPeH1GCQcQHEXstkwSkalhXPQ/0pVz9oGZw7Zl/nzY61F/4F/SxONt?= =?us-ascii?Q?uLTr/gh2vyO0WbJ6yaDHhF8x3PMz6lNOYVOmWm5bjW/+/8QwetcPyfdIzSwm?= =?us-ascii?Q?tg9X64CZSckaC7pNlDUHj5VCjvxzsRhwC0QdFduRHC+K2ce+b9W9+s8OjqYY?= =?us-ascii?Q?dETwLWnaxQfFjMpaBADaAvcFtukKsCva/fME0O3M3D/j90Fija6YekVUgKaH?= =?us-ascii?Q?m95kKhFp96DCdbWhXRSfFa4QkacxrFpb13sFHCbKA16uU+zgaHxa8kbINqyA?= =?us-ascii?Q?EaSEt3Uyx8+AXzmRSA+EvfHhWEwdk24JwRk1Wcqi7qmfktUoKhMOej4rc4mm?= =?us-ascii?Q?mXhSxEGrB6qCpJ2CVcaIeiQXCm9tMt52pW8sQhopIIPHqXSCWSYdrU33ULzq?= =?us-ascii?Q?A33Lz1eSPecoO5rPfRQYg6X7sB1uw+3LnSeQXltKHqv8AMYI7ZqkNCRFiICB?= =?us-ascii?Q?CegawVDcV/puGKQ0+UQ7suOFYWnEsBnazlMYvvsEXB0OFZQQeXRj9YDk4Bt9?= =?us-ascii?Q?+LjID40Y9KY1sJwhPbdyM2MURH9ugVOiBk21MVL9rpLdLpJs1pw8n3VxbRU1?= =?us-ascii?Q?0rME455R+6MdtafKGuaij1e/owSVFybbk6/rVsd8zUbMtmyBSHenE7jNILsC?= =?us-ascii?Q?95TZYYtsIjvO64iSV+rNPINU?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4058.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd7e358d-30e7-4ab5-ec8e-08d9256ad572 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2021 02:05:02.5496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i6A3rjCxdqEY7BzgrrkdrVHU/XCDpi7xH5TAqocJs1c3UI61i8gWHXyLb73c90U8j8OTVUuAGrrF+jaSe86jEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2218 Return-Path: star.zeng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In C1e.c, the MSR_FEATURE_CONFIG is better to be corrected to MSR_NEHALEM_P= OWER_CTL. Thanks, Star -----Original Message----- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Tuesday, June 1, 2021 11:25 PM To: Li, Daoxiang ; devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Ku= mar, Rahul1 Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: = Update processor location info Reviewed-by: Ray Ni > -----Original Message----- > From: Li, Daoxiang > Sent: Tuesday, June 1, 2021 3:25 PM > To: devel@edk2.groups.io > Cc: Li, Daoxiang ; Dong, Eric=20 > ; Ni, Ray ; Laszlo Ersek=20 > ; Kumar, Rahul1 > Subject: [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update=20 > processor location info >=20 > From: Daoxiang Li >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3424 >=20 > Processor location information check needs to updated When Core 0 is=20 > disabled >=20 > Signed-off-by: Daoxiang Li > CC: Eric Dong > CC: Ray Ni > CC: Laszlo Ersek > CC: Rahul Kumar > --- > UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c | 4 ++-- > UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 4 ++-- > UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c=20 > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > index e6e5db75917c..c867802f0bb0 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > @@ -63,9 +63,9 @@ C1eInitialize ( > { >=20 > // >=20 > // The scope of C1EEnable bit in the MSR_NEHALEM_POWER_CTL is=20 > Package, only program >=20 > - // MSR_FEATURE_CONFIG for thread 0 core 0 in each package. >=20 > + // MSR_FEATURE_CONFIG once for each package. >=20 > // >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) ||=20 > (CpuInfo->ProcessorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D 0= )) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 >=20 >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > index bb5d983d1f4b..a3a2861cee5b 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > @@ -152,10 +152,10 @@ McaInitialize ( >=20 >=20 > // >=20 > // The scope of MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS is package for= =20 > below processor type, only program >=20 > - // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS for thread 0 core 0 in each p= ackage. >=20 > + // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS once for each package. >=20 > // >=20 > if (IS_NEHALEM_PROCESSOR (CpuInfo->DisplayFamily,=20 > CpuInfo->DisplayModel)) { >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) || (CpuInfo->Pr= ocessorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D= 0)) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 > } >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c=20 > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > index 8450c7ea3eaf..3c4c1bc706ba 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > @@ -130,10 +130,10 @@ PpinInitialize ( > // Support function already check the processor which support PPIN=20 > feature, so this function not need >=20 > // to check the processor again. >=20 > // >=20 > - // The scope of the MSR_IVY_BRIDGE_PPIN_CTL is package level, only=20 > program MSR_IVY_BRIDGE_PPIN_CTL for >=20 > - // thread 0 core 0 in each package. >=20 > + // The scope of the MSR_IVY_BRIDGE_PPIN_CTL is package level, only=20 > + program MSR_IVY_BRIDGE_PPIN_CTL >=20 > + // once for each package. >=20 > // >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) ||=20 > (CpuInfo->ProcessorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D 0= )) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 >=20 >=20 > -- > 2.28.0.windows.1