From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.8850.1632796750982960667 for ; Mon, 27 Sep 2021 19:39:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=hx+vEW4O; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: star.zeng@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="310154357" X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="310154357" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 19:39:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,328,1624345200"; d="scan'208";a="654957923" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 27 Sep 2021 19:39:04 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 19:39:04 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 19:39:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 19:39:03 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 19:39:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHMnW48tAnGwbfDjm5BA0/78H7oXVT4EuUui/C0gn7K2WE5tWqfRirFS62kVCux1E1agCcUvp/1XpTfXGh+k9y21wzPxJ42+0OMFR3ih42C+rbV6w6nePwt8N/NsuVMyEqnT5PZ44KJ8bEbCE8B2xU1K60xU6QZXsTvlmiADSqj+kbRgCFSX2bHaDIcUyHvPISU+P+fPU521xuL5mNLDgz/x6g4OvvwRO3yWUxBlUDzN/L0leF4qKMLiZdcFN1SuAYJUlfqQJMcnZ77Vc6fl1u4iGH9p1W+WMRsPo2SEBTkOcVBV9R/AryTU1Goc3KPg1Y/X5wGHn98EXdeOiK4HXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fVgR7ORY916BgV3iz1Tw9HdceC5pZFD/xuDZovLgmJ0=; b=nHeEUSXTues3QMDEcgyoFkeCsZLkyzY+Qn3Ze2YW4CH5G4rKIBFFyqTw6KeiS+mqH5+AZib8EGx5wBfhVQyt+unJHipIBapB+s+7ENyiV56alvCU+MjW5d9gyb/RhVCMlkmMZalLnODWhC95tBxDQ68hK+vQqhfiSUHojUKxdGD23ZzvosQt8CeiAjcEF7PVZCz0E4+qBP3ElJmxSgjGmDPSp+cO487Mi3N2p5+F5Uneno6T15PHiN8pHxgyH6snACF/xZUyoojQbRiktyF2M2k9rWwsNFkNWe3oNvLsSDAnO+ErUtsoUajlRMMAiZTiyVh+HbFGGh5XidOJdaTP0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVgR7ORY916BgV3iz1Tw9HdceC5pZFD/xuDZovLgmJ0=; b=hx+vEW4OhU2BzirpoXYFFt2lyp9Ur2oQ5uatst/TJrBu/QgRAtRWTqbcE2x25OkBqumnWTuAu8ZKtJzxKeX6uSV2b0ZKgYUtjfPPNleNO+HfFQy9vLUnMD3ULO1j2hy25oZO+2DJfDQLcqqOeYJPfFJILp+oktGmqv2ztQpjAAU= Received: from DM6PR11MB4058.namprd11.prod.outlook.com (2603:10b6:5:193::13) by DM6PR11MB3258.namprd11.prod.outlook.com (2603:10b6:5:e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Tue, 28 Sep 2021 02:39:01 +0000 Received: from DM6PR11MB4058.namprd11.prod.outlook.com ([fe80::dd12:1911:3b44:25b4]) by DM6PR11MB4058.namprd11.prod.outlook.com ([fe80::dd12:1911:3b44:25b4%4]) with mapi id 15.20.4544.022; Tue, 28 Sep 2021 02:39:01 +0000 From: "Zeng, Star" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" , "Kinney, Michael D" , "Liu, Zhiguang" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 Thread-Topic: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 Thread-Index: AQHXtA0tkxC+bifa40Kp2LwLfOqcdKu4s6SAgAAAhFCAAAc4EA== Date: Tue, 28 Sep 2021 02:39:01 +0000 Message-ID: References: <16A8DA167D1CA920.13648@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0624aa46-66d8-4c35-0cdc-08d982292176 x-ms-traffictypediagnostic: DM6PR11MB3258: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QE/q8LaF3LI0mdb4FTuM2Ew2GM1FGgA/4TDUrvNZ1cCKK7mMBdHgYY39NWYwXhRm1u9jRSiZMXGIjJCvP5xfbXSEHL6T1eWcHE2dr0+eGqn9We+1FA9Lgzu3nSlNTnFJU30LG5tm0wQO1fWclSa3XJGK5xBq6RErTGSaJtGanCJy4qZVF08TGFVnQO0vgO0t+RBy6x68G9VZ8uXHJlO8SuUb1d9XPd4McmJgursHdiHN8m7YvclZnwCbPvG9oAfI/+zQJV2hTRLDwKslcFZr7wsMsuUXgpbN/taO/ImF7qcjcTox1K/TWiulzvoRqUwUKdxKe7CYasbSra50VUboSyAfNBFGWu9hjxCNgryuO5AoN36Ftjjjfs8xo0bp4SynZ617IvTvgH6QtER9KLebDSyphCrC4OSkrgLexfqRwUpmPVLGFXtSb/DA8OdIFslTmra30qavmxIGbwBwFQLLo+5m8FnjgB2OKyBsvzpmjpVmJQ1Ysx4uG35IT7nRknBjDrLlqd+3Wa4tZ1F5ulul7tNJLY3UArj2oSfN6VlFA+ChrT2Kil9oXHOS+CgGWWDENioybgraLUN10cYuA5nckmhKv+10fuFutfJUNQJM7kUlm0Hjzos8QzmKgtZ4mLeyH54VOknBBNw4gH1YQzyTyqSMR0cNZ8ZKb6A4L/hQ1qBl7GYGqwyew1CINJvgPCWzZnRzdwFbHDrGaIrRg4aC9vjs9H8Lner2wOkOOXuHkL3hy+NKISJMLI2pjO0G6YUKujBvlBM/ai2uEUHVNA2yp3upK9Oks4ey1HhbDc2DhHdCsdfoRYmf7VrZmdkaohvFVt8Ui7VbgxprH1h5DrTl7Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4058.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(38070700005)(186003)(110136005)(53546011)(6506007)(26005)(64756008)(66946007)(66446008)(508600001)(66476007)(54906003)(66556008)(966005)(76116006)(316002)(19627235002)(83380400001)(5660300002)(33656002)(107886003)(8936002)(7696005)(122000001)(2906002)(38100700002)(8676002)(9686003)(4326008)(71200400001)(55016002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?ajZNL3JuNThFREFVL1R4NXlIZXJsd2lrcW5DNDJ4d2tBOS8vMDVnV1VT?= =?iso-2022-jp?B?ZGk1cUJkNEJsQmQzM1Fta0did0w0R09BUGZXUkR1cmE5SzF6RVVaTFlG?= =?iso-2022-jp?B?ZzF3UVVEWjhQbk1QSU96V3RxNW5GUVVxeDgzMDJ3RVV2V1h0SjBjOHZ0?= =?iso-2022-jp?B?RWg1cUlyV3hoZ1Q0MUM0aVVoWVpUOGtlR0daaXJkRzJqTWZ5OXQ0Q3ZO?= =?iso-2022-jp?B?THZNYVFyclZBOXJVeUpCVkVLMks1QzRkSHFaVHpDWHlhaWFGNU9MeUxp?= =?iso-2022-jp?B?R1Y4WWJXRkcreVhXUjhtay9KZFhYeG1sQkkwOXdaT1hjSS9kMERpWEcr?= =?iso-2022-jp?B?Um51UUlQL3dpSExOUFEveC82YWpYRTBLSElRMitsNWgra0ZFVkp1Q01U?= =?iso-2022-jp?B?TXRmenA0akR2Y0lIVWlDYmNxU21IT04zOTQyUGFiK0RvSUkvSmI4SFRr?= =?iso-2022-jp?B?Yms0T3B6T05FZk1uN2ZURVlzWUlaMll1NGlUVTB0eUl5bVd6Wjg1Uy9y?= =?iso-2022-jp?B?UlZzN1hiTC9STHlyZ3NiQ05ZRVRPN3Q0V2ord2dCNm9JK0RBeTJRRTl0?= =?iso-2022-jp?B?OFIzZ3pKMUVOSkZGb2ZQbnhmTGdZMDJRd0tVZ1IyWTEyVE4rSUNMZ3Y1?= =?iso-2022-jp?B?ZEpCY2xjelBRblJZWUZaUHpGTk80UzRBQjBGVlJIRGU5M3NSL0Vvb1NQ?= =?iso-2022-jp?B?eGNucGJjNHRUSTM0QVdiUlBCRXd1cndodmFONUhYaXIyM3VXZEtyNjhy?= =?iso-2022-jp?B?UUp1OUhncFQ2bVgvaE1hTEpTRkNWOGNVZHZKSU1mM1RrTXdEdTUwdURw?= =?iso-2022-jp?B?UnJucmV4a3dYVWlZWldPaXpkVVg3SzIxUks2VUlEdVMwaGN3TkxNNzd5?= =?iso-2022-jp?B?SWN3cEZLcW45WXVQamVLc2xNZTdmQU5TWDk3RFVSSFNuSWNna1lJTDY2?= =?iso-2022-jp?B?ejBJdkRUeWV1V2ZKb2lXK3luUmRDQnNGTnN6Wk8rZ0MzWVlOcXF3dExQ?= =?iso-2022-jp?B?d0hkdGNnMXEzYWpXdURaNWcrcnlwbFN0cSthWjVFQjkxdGVWMWd0SXlh?= =?iso-2022-jp?B?K042Y0gvN1VkTmNwMnhmTnViZmNmNWFaZmhDbTNPWXliM0JDZGlyZ2Vn?= =?iso-2022-jp?B?emhEbzNXSjVIMFpMb3lFZ0x4VW40ZktKb2g0ZmZHRFNwSEsxbnRNbTdk?= =?iso-2022-jp?B?ckl3RitScmJYZThyM0QzWC9sdnN6Vll3ZEJ6WUFkVGdIRVNqYnJpdzBj?= =?iso-2022-jp?B?VEk2dXU4VS9EZ1FHMzBDWnlCLzVSdTVKeFIwZUtGN2phMTNON2hzYm54?= =?iso-2022-jp?B?OGJKalRibkhQdC9mWHN5ZnQxakltTnMrQmFrNnQyRlV6VjN5MTJNS1Nw?= =?iso-2022-jp?B?UkF2MFdIK0RMQTB4bGJMNXhPay8rVDJieVNmM0hoZjV0RER2YkJFdVc4?= =?iso-2022-jp?B?NkwrcVlzdVF3RjRTRWNidXUwaE5jUWFuNHNzWWVKa1Z3VTNwenlFTENn?= =?iso-2022-jp?B?V0dIbE03bXZVbUxXODhXTHNieW8wckNkZHluR2VxRHVXbDIyL1FHS2N0?= =?iso-2022-jp?B?M1plZFI2NmthVWZuZkU2QW5vdm5jamxPV3F3aDVaRWZwVVlKK3k0QVcy?= =?iso-2022-jp?B?SEM3a2hvZ1A0QmtoblBJU2FGOGIza3Yra2tnUGtFRGh3TTNLaVh3eTVV?= =?iso-2022-jp?B?VUZ0bXY4SHh6dEQwd25wdDhLR0lOOVExY3QrRlRrOGc0WHZGbEtqZzFm?= =?iso-2022-jp?B?Tm51RFE4OFpYSUdHUjVHdFhBNlBja2k0UElxTDNSa3AzZmVpRWN2Tmpo?= =?iso-2022-jp?B?QU5mMjRSRzBiWWJ4bWFSQ0pCVFZ6OXFPbjhmUUpBT1FZek5XbC9XODF1?= =?iso-2022-jp?B?SkhDMk4rcWxBeWc5Wi9lajhhbW9LSGdZeHF6b2w0NnRzS2tla1RmR0kx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4058.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0624aa46-66d8-4c35-0cdc-08d982292176 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2021 02:39:01.4381 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XeY0de2k3JueLSAH/XBS2gYV2nYipgYbeM3We/9m2ihJ0YijN+F2/MKdUs+01J3K1QhLo4M5yugfAWXtdprfFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3258 Return-Path: star.zeng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Good comment. Saw 0db89a661f38b10012ff4f62e1853bfc48efd462 does so for both MdePkg and Sh= ellPkg, but that is different for fixing typo which must change both MdePkg= and ShellPkg in same patch. Please check V2. Thanks, Star -----Original Message----- From: Ni, Ray =20 Sent: 2021=1B$BG/=1B(B9=1B$B7n=1B(B28=1B$BF|=1B(B 10:12 To: Zeng, Star ; devel@edk2.groups.io Cc: gaoliming@byosoft.com.cn; Kinney, Michael D ; Liu, Zhiguang ; Gao, Zhichao Subject: RE: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add ProcessorUpgradeSock= etLGA4677 from SMBIOS 3.5.0 Star, It might be better to split the patch to two patches. one is to change MdePkg adding the definitions. The other is to change ShellPkg consuming the definitions. > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, September 28, 2021 10:11 AM > To: devel@edk2.groups.io; Zeng, Star > Cc: gaoliming@byosoft.com.cn; Kinney, Michael D=20 > ; Liu, Zhiguang ;=20 > Ni, Ray ; Gao, Zhichao > Subject: RE: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add=20 > ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 >=20 > + Maintainers and Reviewers >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zeng,=20 > Star > Sent: 2021=1B$BG/=1B(B9=1B$B7n=1B(B28=1B$BF|=1B(B 10:04 > To: devel@edk2.groups.io > Cc: Zeng, Star > Subject: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add=20 > ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 >=20 > This patch adds ProcessorUpgradeSocketLGA4677 definition into Smbios.h fr= om SMBIOS 3.5.0 and entry into QueryTable.c. > It also adds ProcessorUpgradeSocketLGA4189 and=20 > ProcessorUpgradeSocketLGA1200 into from SMBIOS 3.4.0 and entries into Que= ryTable.c. >=20 > Signed-off-by: Star Zeng > --- > MdePkg/Include/IndustryStandard/SmBios.h | 7 +++++-- > .../SmbiosView/QueryTable.c | 14 +++++++++++++- > 2 files changed, 18 insertions(+), 3 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h=20 > b/MdePkg/Include/IndustryStandard/SmBios.h > index 6918f58cce44..2c2b32b8d462 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -1,7 +1,7 @@ > /** @file Industry Standard Definitions of SMBIOS Table Specification = v3.3.0. -Copyright (c) 2006 - 2019, Intel Corporation. All > rights reserved.
+Copyright (c) 2006 - 2021, Intel Corporation. All=20 > rights reserved.
(C) Copyright 2015-2017 Hewlett Packard=20 > Enterprise Development LP
(C) Copyright 2015 - 2019 Hewlett=20 > Packard Enterprise Development LP
SPDX- > License-Identifier: BSD-2-Clause-Patent@@ -810,7 +810,10 @@ typedef enum = { > ProcessorUpgradeSocketLGA2066 =3D 0x39, ProcessorUpgradeSocketBGA1= 392 =3D 0x3A, ProcessorUpgradeSocketBGA1510 > =3D 0x3B,- ProcessorUpgradeSocketBGA1528 =3D 0x3C+ ProcessorUpgradeSo= cketBGA1528 =3D 0x3C,+ > ProcessorUpgradeSocketLGA4189 =3D 0x3D,+ ProcessorUpgradeSocketLGA1200= =3D 0x3E,+ ProcessorUpgradeSocketLGA4677 =3D > 0x3F } PROCESSOR_UPGRADE; ///diff --git=20 > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > index 7fc9d38a3b03..c312a7f8f227 100644 > ---=20 > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ c > @@ -2,7 +2,7 @@ > Build a table, each item is (Key, Info) pair. And give a interface o= f query a string out of a table. - Copyright (c) 2005 - 2019, > Intel Corporation. All rights reserved.
+ Copyright (c) 2005 - 2021, = Intel Corporation. All rights reserved.
(C) Copyright > 2016-2019 Hewlett Packard Enterprise Development LP
SPDX-License-Id= entifier: BSD-2-Clause-Patent @@ -589,6 +589,18 > @@ TABLE_ITEM ProcessorUpgradeTable[] =3D { > { 0x3C, L"Socket BGA1528"+ },+ {+ 0x3D,+ L"Socket LGA4= 189"+ },+ {+ 0x3E,+ L"Socket LGA1200"+ },+ {+ 0x3F,+ > L"Socket LGA4677" } }; -- > 2.27.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#81189):=20 > https://edk2.groups.io/g/devel/message/81189 > Mute This Topic: https://groups.io/mt/85916590/1779220 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub=20 > [star.zeng@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D >=20