From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web08.11415.1612883014273535741 for ; Tue, 09 Feb 2021 07:03:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=G9EUPKgd; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: bob.c.feng@intel.com) IronPort-SDR: mPezW7KJY/FWcE9e3WmRYwiUCjqwgZKGbQetCLU10sq9r2AzokO5A30k6WrZ+1adjbGkDhf8yc npyqGGVfEBNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9889"; a="266726792" X-IronPort-AV: E=Sophos;i="5.81,165,1610438400"; d="scan'208";a="266726792" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 07:03:28 -0800 IronPort-SDR: YlL1Ct2syuD3H0EmBRwEHo2ZU7corj6mHLQ6qJkHpUIcua+5yY6Jfjg31KMspdvN0DNuVEAqKX N7Egd3d9iLnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,165,1610438400"; d="scan'208";a="578068667" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 09 Feb 2021 07:03:28 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 9 Feb 2021 07:03:28 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 9 Feb 2021 07:03:27 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 9 Feb 2021 07:03:27 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 9 Feb 2021 07:03:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BafKgmeZmksEI/RIfjjPtQV/lvVWYcH05XPrfPEyS8IvsAXXi9DsTBrqNQL251YqH9iXMmfOyuJZ0OtLRwQbCxdg9heXin3Ig0IDbnHsRmCn0T/cAXQhApEPVdfezGuePwtAODzO+wf0cqLz2CTuKvpob3EHZhU1NeEjfRLTHpDyiK0Imw59il2rqpFx4kSlevQAHvmmEEdrd5b3cBdOA1P3EpcOAK+RhVpvb+MAr7M+EyXs8xApNI6Vgw7gjy96bxBAeYUEvSXIXD294xVbf92vrzfvgDxok43uYG+miwE1ha56DyV4xR3kOs4VVJCuQKhF9Q3lDTEdQQdpvNP6fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcNVjnOg5MTXvpUyfqI6IjQd8AjdJg8JwXtWsMq/Qhw=; b=HPukDFa89ld13NJFn0hM4YL1ZQltaqqGtRfKzYZ73Od2myJhcENDSgmFM2iBwlBCYX1EdRU9cB2xxruJoz1BvPvM2rEqwMx8PUA13vfVMiOfdp97iXkrInauVphkEOsrA+J3lPfqNeVoKVqeO9wEnQphCOTTN0BtH1eGU4Tpqls8PUJTDs0HuuEwQHZ71WCs8Vmd9O2DFiaLaHtUWMTp5WJ5xJakWdxn95Vw5Ho0+f4BLV1YJP0ZBqZA6nb20F6sHfqBVxcUfR2+44nMJ/i/0R5bprpHhk8orSiChsogkPus84B9ifsJgHjQu2XW048IxSP10AUFOYabg1aohbnkUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcNVjnOg5MTXvpUyfqI6IjQd8AjdJg8JwXtWsMq/Qhw=; b=G9EUPKgdwMLChcUc44IwbiCt0ctQiymy0aJXbbdGAo2rsuz+0GoDE2DG5zXkxytzF1X1S1tMpTdH0ufl2x5w8wxOpicOWSGk4QjcaY6Irk1rJ98k9QUxuDA7BoGnsuQ0/HZ3esFY2VP3KhDw2pVdUEUzgcbsb41o0EiwAfJM0gk= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB4530.namprd11.prod.outlook.com (2603:10b6:5:2a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17; Tue, 9 Feb 2021 15:03:24 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::845:55b:f6b3:aa0a]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::845:55b:f6b3:aa0a%6]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 15:03:24 +0000 From: "Bob Feng" To: "Kinney, Michael D" , Leif Lindholm CC: "devel@edk2.groups.io" , Liming Gao , "Chen, Christine" , "Matthew Carlson" Subject: Re: [Patch] BaseTools: Fix the ending character for Linux script BuildEnv Thread-Topic: [Patch] BaseTools: Fix the ending character for Linux script BuildEnv Thread-Index: AQHW/vR/DoHkGvZv7EKpCnuWV86EY6pP601g Date: Tue, 9 Feb 2021 15:03:24 +0000 Message-ID: References: <20210209145808.451-1-bob.c.feng@intel.com> <20210209150118.GJ1664@vanye> In-Reply-To: <20210209150118.GJ1664@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fbea08e-d6bc-471f-e19b-08d8cd0bd936 x-ms-traffictypediagnostic: DM6PR11MB4530: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E+UpEJG1XlXKJOiceT5jqL91IXIAhPRGKU2LW3xkQkU5E3jga92qBFYRQbIshfvIuX/j0/mBnc/SAbnOAtstfrT4cAqV0RL3beBanQwRG1SDHm2OHZqJ6drDXLxWXHv+2FtUhXbnSB4yaa1apKh7EG0rXs2xv7nsFpt7sNE1dbyDFuye1KVucRlVWvf2G9LkJFkQeFiy2NdwQ+qu660b+zqvVj2o3gT4a410gQXNveRyxnW68ugV+sCE6VytoRGkFYUPMAjImd3i4WcdLaWrV7d/oyXcXVpi46OQW+K33bCMaW2lRwEO6LLQWIUGPhgNhndAJxDQj0ZtUxxq3xWq4OwPRk9TaHlAWYncVetFVRJlZf+9NT31rfd9DrhkLK8zJUmQHbgm+wjRjAkeabYVv90Yq+uD3c1OONb4lieXCblqUWRO0ztHTY4hxKRG3LmQQOzk0Z3wZNV0Vv//GAdYqY+qxvwfo5CnqWDZXayeH6r/zKgjdx3GcHXQ7OXRJTCJ7FflDkVtvT6Ubb5qxc5QoA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(396003)(366004)(39860400002)(376002)(66556008)(66476007)(66446008)(64756008)(66946007)(8936002)(26005)(83380400001)(76116006)(4326008)(33656002)(2906002)(478600001)(110136005)(54906003)(7696005)(316002)(8676002)(52536014)(55016002)(71200400001)(86362001)(53546011)(6506007)(186003)(5660300002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1avROE5srvjvk3gVoWfqHrEqaJKEGV0Di6gMiAaZRDa7Vt2wfj44awyJu0V/?= =?us-ascii?Q?ZR58LI7NcMHfN15afJDVma5otKiOV5kLiYxfTf810OD/YMF0QDOYEvzaRZ8G?= =?us-ascii?Q?Wwum4sdHBknTMHYVVl6MxY8O6ssBs+SxXyW7yBuuDn6ScuIyQ8F1A4MVZiO6?= =?us-ascii?Q?EnlxNM7A4Ubnm+d0Ti6qTBFXNbEFWkcAo5RaEdVwh/oxC0x+qvwXEMLZgFdf?= =?us-ascii?Q?OC30CuNYbCTj9qN+3QJewDSRDQOw72a4oCN+GUZ3RtgQSLmcEL+Lq5cOsz8/?= =?us-ascii?Q?l4A0XYLIf0ShfqhIv04hbLZe6DKvTP32Zq2Mh19Lk3LCnb9RORF+UDxQWGqD?= =?us-ascii?Q?yyy60Fl8Cr+lZ1Gf81/Amy0bFP2BZHjgE+nHDJGtceZbZQxpk1MySDnsyU8y?= =?us-ascii?Q?PY2oRnPefNUfMsUfvSAaF82e6pJDSztSayqOPk8DweMfZzPCACOsPVEcY2ge?= =?us-ascii?Q?Y22jQJKI/HVd1li1NkIGMJjwxVJx+ouEA669lwQkjFxOCJ+/eMlvdLBqyvl7?= =?us-ascii?Q?rnqdDyJBE8OUA4tc/FeM2e8SzffOOtSDLIlmgC2Mx6T41ldfVfgLQvm/+IJc?= =?us-ascii?Q?z9nx1V9n1mAwkpjqzXlLbwZqDU4Gxh6H13W7CnSy3dp9igDvAHQqy06kgfVD?= =?us-ascii?Q?19FYaIAg11hNwUPflYVxPCN3JhYcQWOoQ0BQBiFSDqA1RVUGgUkQhQq6EfBe?= =?us-ascii?Q?Rnvqfk/iI6OS/ms92mF+5KA3QPSBe+Sg4kd7RDS5i1ycOm0LvnKJcO6Tnvj3?= =?us-ascii?Q?CqGRDLMuTfOzx4UDQKVDBPocBejj55I8+OM0Ztsugoznu0Nd1UAbRMXb/xTv?= =?us-ascii?Q?4EysH8PhBt45BAENo916HBatME4SaVa1sIK4AphO4xvuR8O/dGgVueXlnUOU?= =?us-ascii?Q?CnqszvQUafSkV5Ko1twDa5z/twNOIClKGRW26ecJsoIo3mB+wieoCOBsotSG?= =?us-ascii?Q?/gPEPtXD6ViNOKWguyMxbfhXQBtzQOUc9LsQOR4EO2iwWf6OlLu83NR1QsWZ?= =?us-ascii?Q?1uQ7h4uwEqphzr7wgV6PCLBIiKsjK+KAFaeJnpYgKzsoaaxJQsbqTLiJbZm2?= =?us-ascii?Q?mOIAE7/rM54+7Qpc8GAbo3gruXPV0urTR2CiajHX/YfjxzR5I9OS7J/mEZew?= =?us-ascii?Q?HDPUrGTYRMJlERy6XwclSm6qwOkyqycFtKIkOA62piFtRgToJimZZX6PdO3L?= =?us-ascii?Q?RGEOrYAa3kq4llcXqtIqt6sc+leqOp6+o7f5aGxzceUepEfEpsxhCT+fUwGh?= =?us-ascii?Q?wrtU8HhW23/ltVbSVHgf5Wf7O1l6A2kqhy7lJteQ2j9PQB7wT7B3qecd8ejH?= =?us-ascii?Q?7MUPmQkcxW9yXniwC7aoxgEB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fbea08e-d6bc-471f-e19b-08d8cd0bd936 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2021 15:03:24.4352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aVA+72TyAd03EmFLGI+7D6Dp0H8dCcRASZTMW0zeYL4U9JjVRJQk7z9gobFnt3WAzJtNnxow9QNOQvlIgp+e4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4530 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike Could you help review this patch and push it?=20 Liming may take leave now. Thanks, Bob -----Original Message----- From: Leif Lindholm =20 Sent: Tuesday, February 9, 2021 11:01 PM To: Feng, Bob C Cc: devel@edk2.groups.io; Liming Gao ; Chen, Chri= stine ; Matthew Carlson ; = Kinney, Michael D Subject: Re: [Patch] BaseTools: Fix the ending character for Linux script B= uildEnv On Tue, Feb 09, 2021 at 22:58:08 +0800, Bob Feng wrote: > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: Matthew Carlson > Cc: Michael D Kinney > Cc: Leif Lindholm SMTP strips the intersting aspect, but as long as the end result is a Build= Env that has no characters: Reviewed-by: Leif Lindholm > --- > BaseTools/BuildEnv | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv index=20 > 8d283e10c0..275f4c5901 100755 > --- a/BaseTools/BuildEnv > +++ b/BaseTools/BuildEnv > @@ -44,11 +44,11 @@ RestorePreviousConfiguration() { > break > fi > done > fi > fi > - > + > PREVIOUS_CONF_FILE=3D$CONF_PATH/BuildEnv.sh > if [ -e $PREVIOUS_CONF_FILE ] > then > echo Loading previous configuration from $PREVIOUS_CONF_FILE > . $PREVIOUS_CONF_FILE > @@ -196,21 +196,21 @@ AddEdkToolsToPath() { > return 1 > fi > =20 > EDK_TOOLS_PATH_BIN=3D`GetEdkToolsPathBinDirectory` > =20 > - # check if the edk2basetools pip package is available > - if $PYTHON_COMMAND -c "import edk2basetools" &> /dev/null; then > - # if it is, use the pip version of the wrappers > - echo "Using Pip Basetools" > - AddDirToStartOfPath $EDK_TOOLS_PATH/BinPipWrappers/PosixLike > - else > - echo "Using EDK2 in-source Basetools" > - AddDirToStartOfPath $EDK_TOOLS_PATH/BinWrappers/PosixLike > - fi > - > - > + # check if the edk2basetools pip package is available if=20 > + $PYTHON_COMMAND -c "import edk2basetools" &> /dev/null; then > + # if it is, use the pip version of the wrappers > + echo "Using Pip Basetools" > + AddDirToStartOfPath $EDK_TOOLS_PATH/BinPipWrappers/PosixLike > + else > + echo "Using EDK2 in-source Basetools" > + AddDirToStartOfPath $EDK_TOOLS_PATH/BinWrappers/PosixLike > + fi > + > + > AddDirToStartOfPath $EDK_TOOLS_PATH_BIN > =20 > } > =20 > CopySingleTemplateFile() { > -- > 2.29.1.windows.1 >=20