* [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
@ 2021-06-13 3:35 Rebecca Cran
2021-06-17 1:35 ` 回复: [edk2-devel] " gaoliming
0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2021-06-13 3:35 UTC (permalink / raw)
To: Bob Feng, Liming Gao, Yuwei Chen; +Cc: Rebecca Cran, devel
Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer
exists. Remove the check for it from toolsetup.bat to prevent the
erroneous claim that the binary C tools are missing.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 1 -
1 file changed, 1 deletion(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 4b5256ab6e..a766a69f08 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto check_c_tools
IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto check_c_tools
IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools
IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools
-IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools
IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools
IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools
IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
2021-06-13 3:35 [PATCH] BaseTools: Remove check for Split.exe in toolset.bat Rebecca Cran
@ 2021-06-17 1:35 ` gaoliming
2021-06-17 3:05 ` Bob Feng
[not found] ` <16893FA69251BD97.14591@groups.io>
0 siblings, 2 replies; 4+ messages in thread
From: gaoliming @ 2021-06-17 1:35 UTC (permalink / raw)
To: devel, rebecca, 'Bob Feng', 'Yuwei Chen'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:35
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in
> toolset.bat
>
> Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer
> exists. Remove the check for it from toolsetup.bat to prevent the
> erroneous claim that the binary C tools are missing.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> BaseTools/toolsetup.bat | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
> index 4b5256ab6e..a766a69f08 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto
> check_c_tools
> IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools
>
> -IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools
>
> --
> 2.32.0
>
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76441): https://edk2.groups.io/g/devel/message/76441
> Mute This Topic: https://groups.io/mt/83503018/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
2021-06-17 1:35 ` 回复: [edk2-devel] " gaoliming
@ 2021-06-17 3:05 ` Bob Feng
[not found] ` <16893FA69251BD97.14591@groups.io>
1 sibling, 0 replies; 4+ messages in thread
From: Bob Feng @ 2021-06-17 3:05 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io, rebecca@bsdio.com,
Chen, Christine
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Thursday, June 17, 2021 9:36 AM
To: devel@edk2.groups.io; rebecca@bsdio.com; Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:35
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in
> toolset.bat
>
> Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer
> exists. Remove the check for it from toolsetup.bat to prevent the
> erroneous claim that the binary C tools are missing.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> BaseTools/toolsetup.bat | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index
> 4b5256ab6e..a766a69f08 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto
> check_c_tools IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto
> check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools
>
> -IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools
>
> --
> 2.32.0
>
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76441):
> https://edk2.groups.io/g/devel/message/76441
> Mute This Topic: https://groups.io/mt/83503018/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
[not found] ` <16893FA69251BD97.14591@groups.io>
@ 2021-06-25 2:01 ` Bob Feng
0 siblings, 0 replies; 4+ messages in thread
From: Bob Feng @ 2021-06-25 2:01 UTC (permalink / raw)
To: devel@edk2.groups.io, Feng, Bob C, gaoliming, rebecca@bsdio.com,
Chen, Christine
Created the PR https://github.com/tianocore/edk2/pull/1761
Thanks,
BOb
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Thursday, June 17, 2021 11:05 AM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; rebecca@bsdio.com; Chen, Christine <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Thursday, June 17, 2021 9:36 AM
To: devel@edk2.groups.io; rebecca@bsdio.com; Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:35
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in
> toolset.bat
>
> Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer
> exists. Remove the check for it from toolsetup.bat to prevent the
> erroneous claim that the binary C tools are missing.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> BaseTools/toolsetup.bat | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index
> 4b5256ab6e..a766a69f08 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto
> check_c_tools IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto
> check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools
>
> -IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools
>
> IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools
>
> --
> 2.32.0
>
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76441):
> https://edk2.groups.io/g/devel/message/76441
> Mute This Topic: https://groups.io/mt/83503018/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-25 2:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-13 3:35 [PATCH] BaseTools: Remove check for Split.exe in toolset.bat Rebecca Cran
2021-06-17 1:35 ` 回复: [edk2-devel] " gaoliming
2021-06-17 3:05 ` Bob Feng
[not found] ` <16893FA69251BD97.14591@groups.io>
2021-06-25 2:01 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox