From: "Bob Feng" <bob.c.feng@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [Patch V2 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines
Date: Fri, 9 Jul 2021 01:25:54 +0000 [thread overview]
Message-ID: <DM6PR11MB407305A086A710D227879CEFC9189@DM6PR11MB4073.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210708195047.1649-3-michael.d.kinney@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Friday, July 9, 2021 3:51 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [Patch V2 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines
* Update GetMaintainer.py to support an optional GitHub ID at the
end of maintainer and reviewer lines.
* Remove contents after email address from standard output
* Fix minor issue in --lookup to convert file path separators
from '\' to '/' to be compatible with regular expression
file matching.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
BaseTools/Scripts/GetMaintainer.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py
index 5ec851554d64..d1e042c0afe4 100644
--- a/BaseTools/Scripts/GetMaintainer.py
+++ b/BaseTools/Scripts/GetMaintainer.py
@@ -18,7 +18,7 @@ EXPRESSIONS = {
'exclude': re.compile(r'^X:\s*(?P<exclude>.*?)\r*$'),
'file': re.compile(r'^F:\s*(?P<file>.*?)\r*$'),
'list': re.compile(r'^L:\s*(?P<list>.*?)\r*$'),
- 'maintainer': re.compile(r'^M:\s*(?P<maintainer>.*<.*?>)\r*$'),
+ 'maintainer': re.compile(r'^M:\s*(?P<maintainer>.*?)\r*$'),
'reviewer': re.compile(r'^R:\s*(?P<reviewer>.*?)\r*$'),
'status': re.compile(r'^S:\s*(?P<status>.*?)\r*$'),
'tree': re.compile(r'^T:\s*(?P<tree>.*?)\r*$'),
@@ -178,7 +178,7 @@ if __name__ == '__main__':
SECTIONS = parse_maintainers_file(CONFIG_FILE)
if ARGS.lookup:
- FILES = [ARGS.lookup]
+ FILES = [ARGS.lookup.replace('\\','/')]
else:
FILES = get_modified_files(REPO, ARGS)
@@ -191,4 +191,6 @@ if __name__ == '__main__':
ADDRESSES += addresslist
for address in list(OrderedDict.fromkeys(ADDRESSES)):
+ if '<' in address and '>' in address:
+ address = address.split('>', 1)[0] + '>'
print(' %s' % address)
--
2.32.0.windows.1
next prev parent reply other threads:[~2021-07-09 1:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 19:50 [Patch V2 0/3] Add GitHub IDs to Maintainers.txt Michael D Kinney
2021-07-08 19:50 ` [Patch V2 1/3] BaseTools/Scripts: Fix GetMaintainer.py line endings Michael D Kinney
2021-07-09 1:08 ` Bob Feng
2021-07-08 19:50 ` [Patch V2 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines Michael D Kinney
2021-07-09 1:25 ` Bob Feng [this message]
2021-07-08 19:50 ` [Patch V2 3/3] Maintainers.txt: Add GitHub IDs Michael D Kinney
2021-07-09 12:23 ` Laszlo Ersek
2021-07-09 16:42 ` Michael D Kinney
2021-07-22 4:15 ` Andrew Fish
2021-08-03 10:49 ` Leif Lindholm
2021-07-08 19:55 ` [edk2-devel] [Patch V2 0/3] Add GitHub IDs to Maintainers.txt Sean
2021-07-08 20:02 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB407305A086A710D227879CEFC9189@DM6PR11MB4073.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox