[PATCH EDK2 v2 0/1] BaseTools/EfiRom: remove redundant checking of argc

[PATCH EDK2 v2 0/1] BaseTools/EfiRom: remove redundant checking of argc

[wenyi,xie]

Main Changes since v1 :
Don't Remove error handling, only change checking to if (Argc == 1).

Wenyi Xie (1):
  BaseTools/EfiRom: remove redundant checking of argc

 BaseTools/Source/C/EfiRom/EfiRom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1.windows.1

[PATCH EDK2 v2 1/1] BaseTools/EfiRom: remove redundant checking of argc

[wenyi,xie]

As the condition of while statement is argc > 0, so argc < 1 will always
be false, it's redundant.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
 BaseTools/Source/C/EfiRom/EfiRom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom/EfiRom.c
index a7e2839b0a84..2506f559d574 100644
--- a/BaseTools/Source/C/EfiRom/EfiRom.c
+++ b/BaseTools/Source/C/EfiRom/EfiRom.c
@@ -1014,7 +1014,7 @@ Returns:
         // Device IDs specified with -i
         // Make sure there's at least one more parameter
         //
-        if (Argc < 1) {
+        if (Argc == 1) {
           Error (NULL, 0, 2000, "Invalid parameter", "Missing Device Id with %s option!", OptionName);
           ReturnStatus = 1;
           goto Done;
-- 
2.20.1.windows.1

Re: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/EfiRom: remove redundant checking of argc

[Bob Feng]

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
Sent: Tuesday, December 15, 2020 2:44 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn; Chen, Christine <yuwei.chen@intel.com>
Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
Subject: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/EfiRom: remove redundant checking of argc

As the condition of while statement is argc > 0, so argc < 1 will always be false, it's redundant.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
 BaseTools/Source/C/EfiRom/EfiRom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom/EfiRom.c
index a7e2839b0a84..2506f559d574 100644
--- a/BaseTools/Source/C/EfiRom/EfiRom.c
+++ b/BaseTools/Source/C/EfiRom/EfiRom.c
@@ -1014,7 +1014,7 @@ Returns:
         // Device IDs specified with -i
         // Make sure there's at least one more parameter
         //
-        if (Argc < 1) {
+        if (Argc == 1) {
           Error (NULL, 0, 2000, "Invalid parameter", "Missing Device Id with %s option!", OptionName);
           ReturnStatus = 1;
           goto Done;
--
2.20.1.windows.1