From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.8520.1609727571419038915 for ; Sun, 03 Jan 2021 18:32:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XG0mPiEI; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: bob.c.feng@intel.com) IronPort-SDR: gVfGVosSjcowvDdFTSztgPbWnMO8rLgKirGplbXaA7dlQRqWEUafk6MAGiMlInkpjxQcSBILjK sKyFFThrBS1g== X-IronPort-AV: E=McAfee;i="6000,8403,9853"; a="177057136" X-IronPort-AV: E=Sophos;i="5.78,472,1599548400"; d="scan'208";a="177057136" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jan 2021 18:32:50 -0800 IronPort-SDR: QpyqaIYxnj49uHjDJhDNWAAB/EB+d2D1W3H/dkrGDc4DqqhizpMqRv3fXfOuFXDQhPh53CVEbr 5p17uxPUNfcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,472,1599548400"; d="scan'208";a="378231812" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 03 Jan 2021 18:32:50 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 3 Jan 2021 18:32:49 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 3 Jan 2021 18:32:49 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 3 Jan 2021 18:32:49 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 3 Jan 2021 18:32:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NMKaWvT7W/sRhyaM4kxW2qKF2KS/mXicaWanyEu+OHCuqYl5XPUm9VDeCzzBk8jrJsWTcYo8XKcmZ+OyYHghZy8Vs0NWupqzBXVf6aSirev8oWWu018BaTuQcorju2KCKEyl8PPfSS752ZCNnt+jpVzWU/IqkzYcxpA8BEl8huZNgCwpd7alOYDcLuZfDZbJZBx045VIJClj/nvON19QgU7tg8iMLu4Y+kiqw+vqJMGg6lOvkPHLz85KkiEsO042q//JI1ZfCf8k0gspXmC/zrCRNrmzkdWFNcJhvY3hqx+ixYdTEOIt2KRWYJWjhG04iEbMsF2kc7rha7i4Bla5zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=swKW+ezqC5GbKPglA+s6mtz+xC4xOIt8ipa1OS5rzhk=; b=FanV1ilnOackaNGPk0nhd+Un2zyKqwhOgSLuC+JPVGGfrJlzWHRmtuwWB4qxBxkMsqhj8pMgA0Cc5iUJvP3ixvYJRJ192oVyo7cT/Fa3i3JfqigsvPo/X4YpYzETjEjURu0XNeTdcUXfdl++TcPNwtAc22Phewr2mK1IRq0x5EBIo6pPp2qvnypgeydN5Uq7InwtxObIF7PXCyCJ/s+jTGzWrVx5LXP/7VNy3HbnIQ6Xd8D0mWEOxLdJ7XO2Ha4dr8KqJcMz38BQhaQvWU4ezQLOQw/tu4psbrHm20Vud8gIkl886keqaqlFUdrVQcRwDBaAgFpsG1ht/dzU7yXWDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=swKW+ezqC5GbKPglA+s6mtz+xC4xOIt8ipa1OS5rzhk=; b=XG0mPiEIyVlVHzemhaXczmY1FGlPws59Eh5IJikMMaYvgMaoIa0qge8qWT1QTSIz0Pmd3JpqctOvX0DvhoRQg5pMsVOqStbAxLAmA2gqJKqRNE3YalhGXnP6+5PK57fB3ayNtGplywLuOHrS1JEOj1EN7PtvEFgtACpTyFVXhuw= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB3866.namprd11.prod.outlook.com (2603:10b6:5:199::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.20; Mon, 4 Jan 2021 02:32:48 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::5c3c:da40:5046:5413]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::5c3c:da40:5046:5413%7]) with mapi id 15.20.3721.024; Mon, 4 Jan 2021 02:32:48 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "ipark@nvidia.com" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging Thread-Topic: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging Thread-Index: AQHW3YSUP9P28G7RYkuWmNVGdL7IgaoWyJ4A Date: Mon, 4 Jan 2021 02:32:48 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a014bb4-0819-4b68-7482-08d8b05906c3 x-ms-traffictypediagnostic: DM6PR11MB3866: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aHMky3+oPG2B1YqeeVbj/P2DWneRfxthXHZAobDxJElowmAr8q5Js8GH6SM1ftiAXIBTGZzkEMQ/6Jg78H4J1TAybYXWopYuwXYIqxKRhVrv6hjU0qPoeGTvMWOf4lfzNJKbWtnIoZoUiSSjWIO6JFs2tak/vmX9BS4bEo5hYpsqf0/5Fwx5t7JykC+MhRNbGM3i1m0jUdIxTIkU0TRnrFGOBp3SoioIwawEEfQHBadHBdX04iUJ6FjqbUwBoCozzVdpXZXWwueOa78wQGIQIMzBssV9zV/STta69j3Sf8fLdjwxXI8OjeiND5NF24W/JFWUNBkkjZDuMDO+QEK6FnR9UityQzOLcqyDZFfRkLL4BBFEuiaZQUuRJnofP0Eeip0MHOcP3daPloHDontHBPl+/jyvgsN12fFkznsCqnYSq5UiF6ta5my6WMXSA6uQNow7Ou+wZISJgRuXto3K5w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(346002)(39860400002)(376002)(366004)(66446008)(66556008)(66476007)(64756008)(316002)(55016002)(66946007)(110136005)(76116006)(8936002)(8676002)(86362001)(71200400001)(2906002)(9686003)(5660300002)(7696005)(52536014)(186003)(6506007)(53546011)(26005)(33656002)(83380400001)(966005)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?4eMPgYnwywEOTQDpyA+5+PVhgMlfYn91/NU3uHPei4STnMvs0iU11wp0Oegf?= =?us-ascii?Q?d4qjI9w70TZdpyNA8n9VFnu/Hpnf6ztPMl28dA23i0GgSx4Z2tscI5oCOo0Q?= =?us-ascii?Q?GFtpLYPiXXQFErxSAmBvfhzij5q4osE8bnw7H+Q9IvnzAhZqey8P8yBP9lWD?= =?us-ascii?Q?dLfZoJPyh1wDLFI95Jkv1uHarrMzLe4vvs4aORhygFjZLGPG6k0MNcw9HmiS?= =?us-ascii?Q?A3gT7sSJYTPSlq/DMucjRISGHwKLQHH85dXIqxLz56JA4aPYSHrtDw/TNJon?= =?us-ascii?Q?YSGuLDVYNOgAWlibUM6vY4CNpFfLtXIAskOCOhvMu4NNzYddvG8WwWrVrXK1?= =?us-ascii?Q?9jAiDDfK4Kl+XGX8UFKrwlrLUw1k6BByzKoyLXycDjza2DnI2gj+WbYfwbgs?= =?us-ascii?Q?kOO6qEmVwtmwQwsAp+I7ZRS6iXa510PnLoGCHJs+AytXI71mFMx/UssMWNpZ?= =?us-ascii?Q?p96brlZRqc/Cc9J1hKfDQd0bTM1dTP4w6MFj71qclXYLD+Fht7fWzX6vMqud?= =?us-ascii?Q?KEBWtF1ZZHZURGfvIBjb7RrSJa9/CGGczZP3NjgbUJpWTWp2h8Bl5EU5gPtx?= =?us-ascii?Q?kNJSVpGj/2AvbB5u10DwyksmzeggzinfyxGzEZP0jWS4oK1o9gy6958H/WoT?= =?us-ascii?Q?zBIHOXMaDEk21bGNJuCm8Sd5vQlaEa3Ma1cm9CwlAojOUEtvZjhhCiyYQxym?= =?us-ascii?Q?f5aGrsOewJn1HKGBiC5Rdk6cjYV/nfmQlLLvuJtSyZxzWRtyNwhfgk//mY1G?= =?us-ascii?Q?k0N5oIQlzevwVHqKZPN8T0zZ4t0iIUgb8KoCkFUsEZSW+zha4zMRPaxiHygf?= =?us-ascii?Q?i7mVIs/QKacfEuFBivzXh1zBA2aYY2mu3nYY9w5SgC3Ifir3h6AkBPJffFOb?= =?us-ascii?Q?KJwxmuPmSFz60JqGKeRKvircDgpKSIghinqOOF4ta/1+/f3mU1aCrRmNTK/Z?= =?us-ascii?Q?XUgXsf/MIolZsrOZ/MPQ2xz6iqjT2H5u45gUCmiE0nQ=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a014bb4-0819-4b68-7482-08d8b05906c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2021 02:32:48.3546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 31FkfP8Yu1Mq/5NNVbx6aZU/+FaRvJqhhPPYeg22FYmRXw9sMpZZF45g+XEdnf1Lmzh0DfHDDwm5TgjzqDUeEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3866 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Irene Park Sent: Tuesday, December 29, 2020 9:47 AM To: devel@edk2.groups.io; Feng, Bob C ; gaoliming@by= osoft.com.cn Cc: Irene Park Subject: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging From: Irene Park EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the expec= ted error message when an error occurs. Signed-off-by: Irene Park --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Sourc= e/Python/AutoGen/GenPcdDb.py index 0870c44..ad5dae0 100644 --- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py +++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py @@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData): delta =3D {} for skuname, skuid in PcdDBData: if len(PcdDBData[(skuname, skuid)][1]) !=3D len(PcdDBData[(TAB_DE= FAULT, "0")][1]): - EdkLogger.ERROR("The size of each sku in one pcd are not same= ") + EdkLogger.error("build", AUTOGEN_ERROR, "The size of each=20 + sku in one pcd are not same") for skuname, skuid in PcdDBData: if skuname =3D=3D TAB_DEFAULT: continue -- 2.7.4