From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.6539.1618823641846854440 for ; Mon, 19 Apr 2021 02:14:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=pEWALwXE; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: bob.c.feng@intel.com) IronPort-SDR: hj0PkpzwoLR3CWkUqQEifUWCOHFE5kPkEoTzr/D5jme2CqzXr+1zoh0BpxrfpCAITS21n/Jefb 4bItefqzzpTg== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="259252909" X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="259252909" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 02:12:59 -0700 IronPort-SDR: f1SOeaWpEql6VN24ijBWNojYcBHQXmdJWUiGUuJWl07WsV+e7vqe4xYrkTQPPzsfHT16vH+kbt 1jr30zp7MQ1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="613333737" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga006.fm.intel.com with ESMTP; 19 Apr 2021 02:12:57 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 02:12:57 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 02:12:56 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 19 Apr 2021 02:12:56 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 19 Apr 2021 02:12:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cfGOm0LGIsLxIt8ay/DwjrvNGWcjI3r50k9qSkV/4IuvPLAl9swtYMHRt7vz6osfRVUgRqo1c9jicoj9oxBQA5U46j409BBqSReB6BQEn/nNqJOl9DtmWnjKdHpMlXNKGdNuas4Nx+Gpuk3f+3mgP0Gp9jLm/jH3QXEs6YJ65kQo+Jq5dhJFZQIGXzQSyF6lrrM5DjwedfRxgNPPhR62slvSCUBGx5wSDypEMn3PHkjmi4EJ1LKBycEMQWgfBOe2JvZ2m6b7gnUhCZIJNhnno9/oDrbAhP1jiRbrSdiAQ6js1vc1D2hOoMfedapph8dRSGOPC/2DFrWHBGaH319UYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MuetDHlV1d7A908ueznrSrJs/e65WRt0JLa9Q+UBCZM=; b=gR2jZ3b8tMyOVpzMDlRKdqZ+EGHiztb22Q8l3qiTphnPryPf8Wn/iQWePhsXOm8V3vmyjmx5OFf7UYayjb/D4PveyazN8ZfhENfqz8yKPydIo8Y7r2aA0X7mMEPVXcwH2nrsBcXc9DfL5SlBFSdIEtm7Hjwwfvx+cMMCgtGeNKKQohzowU+sjS8V5CLnMC3AAHGwK4fOXZBkZ8yBhoWu5wodKfox7psExk/IwqxzgdVAafhguvSfmm2HTEZleTpvRwB2P05pNpfHd0a0EN4C0WTUxygvGbtneyWapgMXAq4e4pSlLU0LBPFWx7ckFtAxaXuGkBurr8l+0Z7smxkRSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MuetDHlV1d7A908ueznrSrJs/e65WRt0JLa9Q+UBCZM=; b=pEWALwXED5gngX4skSUI7fe9tCtrx1dGE0PW/1KgMuZR3KKtRvZaLHQdvV9oGrYfSV2Hast7ga0mv1Ps7hEkYM0koBgvYNThNOH8h+vjaJBFoJE7Cupv5BJI4NCvo+YS5ymp0IePU7KCL9SnSJYA76sHYhm9TxAW6mCtT67ym3Y= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM4PR11MB5293.namprd11.prod.outlook.com (2603:10b6:5:390::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Mon, 19 Apr 2021 09:12:50 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18%3]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 09:12:49 +0000 From: "Bob Feng" To: "Shi, Steven" , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" Subject: Re: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Topic: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Index: AQHXM4RRbPrDgRbISkKYtP8/09FtlKq7hg7wgAAEHYCAAALcoA== Date: Mon, 19 Apr 2021 09:12:49 +0000 Message-ID: References: <20210417122133.1879-1-steven.shi@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 07e65461-7552-419b-c761-08d903134e02 x-ms-traffictypediagnostic: DM4PR11MB5293: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jE83NFzb6jkKDF8b0i8Egv8RPW+ObK9DNfeRfTIhxaIQS16wBpdDr+cAvDVIR+tJUXObNPj3EJtQ2b9arK7wCP5ml8tqXNSy5zkenMpBsu1jo8gu1FQILAMPU9iGzWF1gqwEYasXu9ffy5S0u/KGo7hlP01dPQxUVP0a4AZQT3GJttUqn6zPPoHzrJDFM18TpXPpGwY4Q6WYTJzmCoA/rDFCr+FLljRqbZheJPmoY9+MyGU2bjtBrylEttG57TndXJO2h5pCuT6CLxp8DN9bZb6KOzR3CBtO35MIVeehUAzTRR0z+m8Zvwz4mA5dHtbLf/4jmit5AbR92r4bohTlbPmf97bGzJSADxajps03J/tN7j2YCpAgH9Q9tFUFIKbnqTgPhalYeSW3oVKHyN0lhWOgCeiXPHSSmiqOI/oFGf4FqSUyTTVH8lhRotE/Ew2nK2VkaAJIyyXr2DesR+1EKZzavkYZh3PAinj42MgxvQpKQUaA7r2wYENrOrRpXyVbZu+OaOOLdlKzkVKN778pxgC6H9S6NOHO873ChvCwmMq5rP/oT/mXZFhcSCGaoqoqkO+QYNXTkLEV9ycQYk0EHdpNi6oOtuF3ksCdPbxUIN/m2iHlYcoz98RpJ5/giYIyjlPxKQWgq9b8so1BvR6T9IhbFbUc3cITJQDL+RIDdBB4yW3fJiUuCQqq+0NtEh00s4BuJi+PhdSodcKgNVDkX3w/79+yAWjM68DaVPupZIs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(396003)(366004)(39860400002)(136003)(4326008)(53546011)(6506007)(186003)(26005)(7696005)(478600001)(966005)(33656002)(52536014)(5660300002)(86362001)(71200400001)(8676002)(66556008)(64756008)(66476007)(38100700002)(83380400001)(55016002)(9686003)(316002)(76116006)(110136005)(122000001)(2906002)(8936002)(66946007)(66446008)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hTu5batGa3jEJIObHxoqjV1MTUJAg7WfY2Mt01u9jrFa1d/U0LYW/ZCTNIWY?= =?us-ascii?Q?J3TO5HKmK2rrLqnM2pLaV2U/N773BhYZA1vbqJVc/mO95Jy23qiBq7tIuAgU?= =?us-ascii?Q?hSgf+53w706gTkDeRLnmjKG8IuTZ9oyNzI9x5s2S+aibvSPcb9Nx5IX26L7x?= =?us-ascii?Q?K2nlthhpdAeK96LJc7A/Jc+FAGBOeM8FQNKG5w1rdPhRYCHeEA0bLcnfkYzl?= =?us-ascii?Q?QGIKMBDrt6xM7njqiTGuurawgz575w1tEihvl2rsi6Kqp1mjcwfa51CzMuaf?= =?us-ascii?Q?dfKkaYtP7CNzYYowH2kLwTFf1JEcr/SLQHbBlxlvMOZY8r61rAjbrbFIcbsR?= =?us-ascii?Q?aCMBquPey567KKDAASLf5vJrgRj9e2o2NAi6i7Sww75Ki9Gg8k75UHHpJpcQ?= =?us-ascii?Q?6iFaXf3mKEC5t+145dPBN21ISKbaI1zPYv7W+5u94isAtwYwqGe09dcYFla/?= =?us-ascii?Q?hvMUejr/UENmvbftkhmEVGaAqZQn/OnjAXdOaCa1Q/XpnpdpzQsWeQ3OBdDN?= =?us-ascii?Q?PU64XRMaTWZy9e2QlVf6xEaL4BFVkh1eqXRewkyd4/M0drcWo1u3JsPHDwYX?= =?us-ascii?Q?nXP/nPPHXPG4BMkzwWvpHDCplasmMvYqEa1NEgZ0yTHdf94HRgQTMO4UoL6t?= =?us-ascii?Q?GyQvOLzSqI13MQb/J2I4mbfKzTp6vJCBdBOspGOicpban6eF1OXwJP19+bj1?= =?us-ascii?Q?O01VIlNLQl0idNdhMCiarfd7nUpVn0LO7IMd1gea89tr26FaRetiB9VqUogo?= =?us-ascii?Q?/EdKf1gjPyHS0cvaOdJrDfk/6t1KLQaVppONJA1U5rUF2CHEPM9z9IOvVJVx?= =?us-ascii?Q?y/fdo3ZcPKCh9xrLj+N/eIB/Ze6VIzg+hgFdN2LeTGymQsrCp1mJq54cDZ5A?= =?us-ascii?Q?5iJ4Nbmpv658cqQhY07fHlFBgXUEHiQgrTfYnVYRmN6MQUfeUaM9v6CCYEMU?= =?us-ascii?Q?fGoBLldOLR1mkWRekQJU57h8z/nnAV4DJZ7H2aF7bd5D6VHbEuAAKYiABDEl?= =?us-ascii?Q?zKPz6VcIvYQ723N6lW8IAmYXly4XNHwx7QkYusb27wa6xxnbHNsqdmoF66ey?= =?us-ascii?Q?x2UIcuDngZNLXafsyfn7QrV5KTkZtEggQ+mZ6QMsiEoYnD9QwJZnQgFe0YfJ?= =?us-ascii?Q?JD2TAgdDofd/AEf85koH76q2cBYeX8z7bOLCmB3Rd7T1flc7usTJ5RnjSFdM?= =?us-ascii?Q?OKSjCll2f3w2bg+noVXV80sUBIBqnTd2G3+O4jEvpvZIIXYHY/N4OCOeRW4A?= =?us-ascii?Q?TtQaSG2pNXZqPtDTDnsG2Ts91369dz99j04+coim9Gt6CBHvZ3eJKhkbAZff?= =?us-ascii?Q?WpA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07e65461-7552-419b-c761-08d903134e02 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 09:12:49.6903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9Y2LUnjh+D9SyjJsnE2leS9rljIKKlf8ciglhxG8f+E6ojTHrwIGbxTnaqkMo8hCzCq6jNm+V9rktaFCfOL4Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5293 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK.=20 I also find a similar case in toolsetup.bat line 411 set "PATH=3D%BASE_TOOLS_PATH%\BinWrappers\WindowsLike;%PATH%" Reviewed-by: Bob Feng Thanks, Bob -----Original Message----- From: Shi, Steven =20 Sent: Monday, April 19, 2021 4:47 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: gaoliming@byosoft.com.cn Subject: RE: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path = string Hi Bob, I tried @set CLANG_BIN=3D"c:\Program Files\LLVM\bin\", but it cannot work w= ith my CI build service. Only the @set "CLANG_BIN=3DC:\Program Files\LLVM\b= in\" can works. So, it is necessary to use double quote around the whole se= tting string, which includes both "=3D" left name and right value parts. =20 Thanks Steven Shi Intel\IAGS\SFP\FIA (Firmware Infrastructure Automation) > -----Original Message----- > From: Feng, Bob C > Sent: Monday, April 19, 2021 4:34 PM > To: Shi, Steven ; devel@edk2.groups.io > Cc: gaoliming@byosoft.com.cn > Subject: RE: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN=20 > path string >=20 > Steven, >=20 > Would you do a little change as >=20 > @set CLANG_BIN=3D"c:\Program Files\LLVM\bin\" >=20 > I think the double quote should be only round the path. >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Shi, Steven > Sent: Saturday, April 17, 2021 8:22 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; gaoliming@byosoft.com.cn; Shi,=20 > Steven > Subject: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path=20 > string >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3341 >=20 > Current CLANG_BIN env variable is set without double quote around the=20 > LLVM default installation path string in windows, which causes some CI=20 > build service cannot find the LLVM path in windows. > This patch enhance it to add double quote around it. >=20 > Signed-off-by: Steven Shi > Cc: Bob Feng > Cc: Liming Gao > --- > edksetup.bat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/edksetup.bat b/edksetup.bat index=20 > 7b9377aaa5c2..7ad137bb3e9b > 100755 > --- a/edksetup.bat > +++ b/edksetup.bat > @@ -120,7 +120,7 @@ if not defined CLANG_BIN ( > @echo. @echo !!! WARNING !!! CLANG_BIN environment variable is n= ot > set @if exist "C:\Program Files\LLVM\bin\clang.exe" (- @set > CLANG_BIN=3DC:\Program Files\LLVM\bin\+ @set > "CLANG_BIN=3DC:\Program Files\LLVM\bin\" @echo Found LLVM, sett= ing > CLANG_BIN environment variable to C:\Program Files\LLVM\bin\ ) )-- > 2.28.0.windows.1