From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.9224.1618382021120883914 for ; Tue, 13 Apr 2021 23:33:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=egT5LkRk; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) IronPort-SDR: UK8+4/14JQmRmMNB0duHE0N9NWabreNEw1ug3TTLtRqR/u29rqk4zZ2QhTa04Bw2D/fbJd9nTY bURKIOalpIVw== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="174684096" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="174684096" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 23:33:39 -0700 IronPort-SDR: 3X1aj8+Z4Ul6qpgNvN8Wu7KcQ0A0RzAF2TQ+0I9xT+samsSMCiesBSSRN/EQylNZEna4t+B4f/ igBt9DobCgHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="382251467" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 13 Apr 2021 23:33:39 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 13 Apr 2021 23:33:39 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 13 Apr 2021 23:33:39 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 13 Apr 2021 23:33:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LEeBbf6kKPix+22XfxiMJ4G5pkROOuJQYW6tc3byyatkEeEsOPcPq/P7XUmY1ugkLoni6uOza/FoJqByJennaUa75jmsJ8GJ5bBM36KnmWhA5lTj91xVXf3bpPLrUoflWbCLWaRI3mm47SHMfVXdZYVmjaddkEE53Jl84uNDVILurTqgmvvIyh8vqugaHvjfGqM+NbDFetKxqSSTgJT6Tx55m9nMDDtmBpo7EL3Sz/94GqCpoK+/ODVnK15ccBdCNxvz8F4z5PiDU6F7shYrGcscqjieo9q9K8R/4c4rvqXkYSOeBm+JA3BcrtoF7x/SPaTL0vAcj1Uln6D64e0sWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fbygHa51IPaRU2F2TLXZRNqjkLUFTMz/qlPbWCFiG60=; b=cO9ZIzMeRfpyrn+iu4JCJrWmmDhS9JVQ0GYW9z1Kmbve9r+T1ArXosx+vAB6Gn7t9F7BU7Obl6cl2fe8RJGdyoLkxkte4wSVpUZ1N9yKGrj7UEmtF+EPcdSLqe2QbVIQzlaYYQ/XjBx6vkq/5FVLDq72sp1lHyoeQ+kBBDtoc4xQiLoQxQanZ12OHmz/EgOokqw9NobmZ/nIe0+RbJgo2RJY3VmfwjWQYCNQszH5aW7NVRzglv8kGtT6hFw6gdG4um4WQPRlqI1fC0YhNq6vXMrRiGWYg18lLeptLBFDTkKfsUaIawxLWxEqGySwSuTrXK4NfF2hgu4f3dL7cApyVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fbygHa51IPaRU2F2TLXZRNqjkLUFTMz/qlPbWCFiG60=; b=egT5LkRkT7DFh8kMLfJz2cITqPWkp9vxtHdANkARklusAY02ivcQHInNg8av9KrpDo9NjgTP4QcXuPA7G4dJKmv62CZmxId6aluBHNFCaK84YJ49LFx2kt/v7L6r4S8ZG4FyLdyWLtqUA5zOgNKOuNpZQcJbXCdxW981Xc8+MZI= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB2857.namprd11.prod.outlook.com (2603:10b6:5:cb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Wed, 14 Apr 2021 06:33:38 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18%3]) with mapi id 15.20.4042.016; Wed, 14 Apr 2021 06:33:37 +0000 From: "Bob Feng" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Liming Gao , "Chen, Christine" , Andrew Fish , Abner Chang Subject: Re: [Patch v2 3/4] BaseTools/Source/C: Remove CPU architecture assumptions Thread-Topic: [Patch v2 3/4] BaseTools/Source/C: Remove CPU architecture assumptions Thread-Index: AQHXMN401pf+pKuSoUSOXVQi2s6LkqqzjmxA Date: Wed, 14 Apr 2021 06:33:37 +0000 Message-ID: References: <20210414032758.1818-1-michael.d.kinney@intel.com> <20210414032758.1818-4-michael.d.kinney@intel.com> In-Reply-To: <20210414032758.1818-4-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.197] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ea9c99af-ea52-4df4-edcf-08d8ff0f3c93 x-ms-traffictypediagnostic: DM6PR11MB2857: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1332; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MywVBGzmdU1FmnEBPzgUrdjUPSvf8GmvyNwEf9IQqi4DDdGd/4fdHk4Qzm+qH1d76Oq/gzqny4cbRTGENACA20I+OdLgDQ5tg203uSeMl/fToGlrdX4UrOYN9bBO0oTHt1eYBd6/c/qqQkBG06vijfiflK9nBb2/iErSeS7zxprPgrOD7JP8iy/juxfj8VbgeKTrSg4pYLcLWEYSX08HX1m3/PSo/8mpylZC8FJFo7PkWkwSjDrJ4a60p6g7S8kf55aBz9+i7B31fmhpR73/21AOoV47QBE+LlwuTrF/R41is2QqW4xR34r4cLSxclQAdbBz9pvBenyBMa5WgRYF3GQkyWuiphCaLPy7zfhWRhNyBQubXk0xXa3vNHL8ZlmAHos0EhcwEdi2I1yAe/bhdpaD7wFGEbEdrwKHtGX5WQnO6xE5HAHRkKLZRJZonTVS7amZAh6yNLYOqeGv7d9WkyN/NmBWgcrrOIU50sJPk3XkRj7PrV53O/OpuV/uZh0i0ezWDOAEw27XLNAyBSFi0w/NkMsEQoECVQOiSURaWsjeOS6QErJVToS5B9SPhPni6t9I20t6tl9mrq7HzWuS8gL9eQmB488tu2Ba3FoAAy47x8AH8QaTbhMMSy+/EtZvW8U8/z1cvxceyHTJA+oAdQn7RZRYYNyzqD/H0GQ4tVT4+y5OLPRSIU1YCw5TAiMD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(376002)(346002)(136003)(39860400002)(9686003)(55016002)(5660300002)(64756008)(66446008)(7696005)(8676002)(26005)(54906003)(8936002)(66476007)(66556008)(122000001)(52536014)(83380400001)(38100700002)(2906002)(4326008)(76116006)(478600001)(53546011)(6506007)(316002)(110136005)(966005)(33656002)(19627235002)(71200400001)(66946007)(86362001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?sUiF4D3sC+EG1vWK0uiR5Ved6liA22D6zPST+8qyjgZhhvaT/TRYTkxO8oX3?= =?us-ascii?Q?s9OVtcnXT0r3qgWbAnWBChlXoPzZK4a58zq+pVSBICVxNGvmfwOqp+IxOGhV?= =?us-ascii?Q?3WoiW8EahrPcC5EtM4Q/hW8MpPGbPVXw/u5pKDGg3xKqJs62ZWjpBmMdODkG?= =?us-ascii?Q?/1u7N6Ifj1VRk70ZkKYUx4Kw9sCG/yQ2Ra419vc5iFgv/TWYdz4rWnc2U6bK?= =?us-ascii?Q?vHrKBnHztzXv4RGg++r4DqX/1+YcWmKn89PniQqpvCfUeTnbek23KTh9BVsN?= =?us-ascii?Q?W3DCoDOTAkiX7IO2vGyhGV1ebEdODvCFe5ssHWIFaV5H89qe6+pWHKFjFvE4?= =?us-ascii?Q?3TwTvESXxWU+yPKv14QwbZYzZNUd9JDKdWXK5mp0L4OmnU4i9dCMh0qjxwU3?= =?us-ascii?Q?GWeWF3gkyBQo1cPF9qyF/iHEpaMIGFU3V4bz0cmyaW7q5PIn0imVu+LafKL/?= =?us-ascii?Q?pfd7v2OLrw7TPJ3HWdRBCkOq85U0R1xk4VPgOJkACWfuBaKvkWppVrypNw4L?= =?us-ascii?Q?ojqP/r82vmRKsjebPpNn3Q+XMd6jG2mD53cYumyay4sEcg7E/XUfc/mgWfZR?= =?us-ascii?Q?qnP4MaljhY2hcn8uFyrYstonMqweZWzUZV8fYg3ntfK0vTf+YT9Sz4XcSAzt?= =?us-ascii?Q?zJseAJIw/KLx1iTIq5076VCrETMg5snHyTyv3BocQjM4obDANKg2Yv55udYX?= =?us-ascii?Q?hHvPKdu4egSRpRLFP6Ot9oqkS0jRXJUtLwc/5HHl8DP4SuFfQvLhlJdOduqf?= =?us-ascii?Q?y9DVIuvvtUtHttKwfV2Wghboc5Dy22qhGr0598uv4faiIxaMLxcY/DDtev5H?= =?us-ascii?Q?EUIhkaNWQ/5iKHo3obwTx1Jzrz9Q4DWMn7orUuM5dUotg9RbbOH7Ev3AoYWr?= =?us-ascii?Q?OlEAV4kFkCmWJWwQDXqnzqkBhVaXkpCCpBa6Lsfc0dwjxWN8GrsCaPQtkWyH?= =?us-ascii?Q?7XqF2dyly7aoz+crrmY8r1IwtcepMwPQNu9jtpuMbX0hUNMPb+XK97EXhnkC?= =?us-ascii?Q?uev/8hY+wrZdmimsdRB+qgxx+QAJlqbo196Xa6yrCGhXvpoY1W9e+xwubEWE?= =?us-ascii?Q?BnCjqGO/T/kWzUGfnhFGI5SL1X/sZt8cgVU637zAQtUY3wb/2ghFVaEY+S2h?= =?us-ascii?Q?3fK5pchnOih1LWUigezsTViNyJdKSeFS1fW/+kg27sWJERzIuw3HhH1Hovb1?= =?us-ascii?Q?hnodTdRhZU4muc7cwTIt/LkIxo9IV4Dj0ZmRM0l621oBLrxfuwjEw+rKSpm1?= =?us-ascii?Q?EvZAUanE6B4JthhhO9fqOfRyinaVEZLXflVG9D5qM+DSRvVzsE7P7jVXcR53?= =?us-ascii?Q?ny47Bj9YVbIhfLnbQgRiIAv7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea9c99af-ea52-4df4-edcf-08d8ff0f3c93 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 06:33:37.8205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EhYwYTngVdCiZ3hRUOcskGCC0uhhSAaTHzKcwxexjxqeG1E3tgIWGU93f6HNXewvIDem2NjW2rGW0Fzg6K1H4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2857 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Kinney, Michael D =20 Sent: Wednesday, April 14, 2021 11:28 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine ; Andrew Fish ; = Abner Chang Subject: [Patch v2 3/4] BaseTools/Source/C: Remove CPU architecture assumpt= ions REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3308 The EDK II Build Specifications do not restrict the set of CPU architecture= s that can be supported. Remove places in the EDK II that assume a fixed s= et of CPU architectures. Remove build breaks in the following tools when a check against a fixed set= of CPU architectures is made. * GenFw Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Andrew Fish Cc: Abner Chang Signed-off-by: Michael D Kinney --- BaseTools/Source/C/GenFw/Elf32Convert.c | 5 ++--- BaseTools/Source/C/GenF= w/Elf64Convert.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c b/BaseTools/Source/C/G= enFw/Elf32Convert.c index 7f351287a93c..2485b2cb7ad9 100644 --- a/BaseTools/Source/C/GenFw/Elf32Convert.c +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c @@ -1,7 +1,7 @@ /** @file Elf32 Convert solution =20 -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
Portions copyright (c) 2013, ARM Ltd. All rights reserved.
Portions C= opyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights re= served.
=20 @@ -143,8 +143,7 @@ InitializeElf32 ( return FALSE; } if (!((mEhdr->e_machine =3D=3D EM_386) || (mEhdr->e_machine =3D=3D EM_AR= M) || (mEhdr->e_machine =3D=3D EM_RISCV))) { - Error (NULL, 0, 3000, "Unsupported", "ELF e_machine is not Elf32 machi= ne."); - return FALSE; + Warning (NULL, 0, 3000, "Unsupported", "ELF e_machine is not Elf32=20 + machine."); } if (mEhdr->e_version !=3D EV_CURRENT) { Error (NULL, 0, 3000, "Unsupported", "ELF e_version (%u) not EV_CURREN= T (%d)", (unsigned) mEhdr->e_version, EV_CURRENT); diff --git a/BaseTools/S= ource/C/GenFw/Elf64Convert.c b/BaseTools/Source/C/GenFw/Elf64Convert.c index 4ed6b4477ea9..d097db863243 100644 --- a/BaseTools/Source/C/GenFw/Elf64Convert.c +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c @@ -1,7 +1,7 @@ /** @file Elf64 convert solution =20 -Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
Portions copyright (c) 2013-2014, ARM Ltd. All rights reserved.
Porti= ons Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All righ= ts reserved.
=20 @@ -162,8 +162,7 @@ InitializeElf64 ( return FALSE; } if (!((mEhdr->e_machine =3D=3D EM_X86_64) || (mEhdr->e_machine =3D=3D EM= _AARCH64) || (mEhdr->e_machine =3D=3D EM_RISCV64))) { - Error (NULL, 0, 3000, "Unsupported", "ELF e_machine is not Elf64 machi= ne."); - return FALSE; + Warning (NULL, 0, 3000, "Unsupported", "ELF e_machine is not Elf64=20 + machine."); } if (mEhdr->e_version !=3D EV_CURRENT) { Error (NULL, 0, 3000, "Unsupported", "ELF e_version (%u) not EV_CURREN= T (%d)", (unsigned) mEhdr->e_version, EV_CURRENT); -- 2.31.1.windows.1