From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"ipark@nvidia.com" <ipark@nvidia.com>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
Date: Wed, 6 Jan 2021 01:49:17 +0000 [thread overview]
Message-ID: <DM6PR11MB40734B3DD904A8B42EC9785FC9D00@DM6PR11MB4073.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1656E6B2AE248774.11073@groups.io>
Created a PR https://github.com/tianocore/edk2/pull/1297
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Monday, January 4, 2021 10:33 AM
To: devel@edk2.groups.io; ipark@nvidia.com; gaoliming@byosoft.com.cn
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene Park
Sent: Tuesday, December 29, 2020 9:47 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn
Cc: Irene Park <ipark@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging
From: Irene Park <ipark@nvidia.com>
EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the expected error message when an error occurs.
Signed-off-by: Irene Park <ipark@nvidia.com>
---
BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
index 0870c44..ad5dae0 100644
--- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py
+++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py
@@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData):
delta = {}
for skuname, skuid in PcdDBData:
if len(PcdDBData[(skuname, skuid)][1]) != len(PcdDBData[(TAB_DEFAULT, "0")][1]):
- EdkLogger.ERROR("The size of each sku in one pcd are not same")
+ EdkLogger.error("build", AUTOGEN_ERROR, "The size of each
+ sku in one pcd are not same")
for skuname, skuid in PcdDBData:
if skuname == TAB_DEFAULT:
continue
--
2.7.4
prev parent reply other threads:[~2021-01-06 1:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 1:46 [PATCH] BaseTools: Fix the improper error logging Irene Park
2021-01-04 1:01 ` 回复: " gaoliming
2021-01-04 2:32 ` [edk2-devel] " Bob Feng
[not found] ` <1656E6B2AE248774.11073@groups.io>
2021-01-06 1:49 ` Bob Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB40734B3DD904A8B42EC9785FC9D00@DM6PR11MB4073.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox