From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.2084.1609897760710185972 for ; Tue, 05 Jan 2021 17:49:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=A4yhGX3N; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) IronPort-SDR: P7+Ft5PRdVh2PWvfkc25Y3fMQtaB+JaD0/FfXYj/dd8snI/Ff7M1/qNxlhP0OaJoXs90qrq05A nhjnHHj65UrQ== X-IronPort-AV: E=McAfee;i="6000,8403,9855"; a="173703774" X-IronPort-AV: E=Sophos;i="5.78,478,1599548400"; d="scan'208";a="173703774" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2021 17:49:19 -0800 IronPort-SDR: AEYrrgDXc3EeZoApYTJC2ucs8+uXIiLRF+x1TqUwKKVVVlnaLJkeTn5zHoaRbdIZAwTPBEZNnf GwVdfbfHFGWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,478,1599548400"; d="scan'208";a="569909801" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 05 Jan 2021 17:49:19 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 5 Jan 2021 17:49:19 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 5 Jan 2021 17:49:18 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 5 Jan 2021 17:49:18 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 5 Jan 2021 17:49:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsZPdjqaXH5U08v21IEtzYrKmQg1kbYkxGU14HANe6MMCnB373KiaPOWDK0q+qru6HicxtCXmYYqraAcbqVq+e2S8v2wt09FOI1VDBy1GfOkguaInRdnkpv49fCgAFzITNlKUumcfrIGaD8U9uBMPI/2hOzJIanYB4KCDAZttck3z4CbyHUqbg7ZLGUK6pmOgIQTLlDnoRU1NwKdMpUlsUgsg7AeIErdz9nQuE3Sr5gaOnqRfrnWMrsU1HA+pPd5ZViyzjUtFrljFT0di1nbVn89rU9g5yzLX1hpq0QxoSRvL1kNqbWJDeyZDHY752xWuDQGjmDNM+5aHf66shNEmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MKwCXH5tSajthQrSsTUkeh0uBy4cHuSLSGe60C0HQNI=; b=SoApS5levoKxWb0NEpcdaX8JvY3E0wdxtPUl+aVjNPySmtb+ly4Dd5QmpN8m2br36J1HL7ao1MQbSIGqSXb29RqOITEf4TayX0+Ez0Ffp5J4AhKT/ErBM32oxSDurZyOpZIShldV7RfWH6K8VJvLdxnBC7f633K7K/wFQQp7xbgVRyhRyX8838mFSdgBqHz4C27uZ66Y5e8PmiWwCJtPD7xVEpa1FBg6vZFJDOOvsf7X4Cz4pJdDktOX+k7AG1Dyly792GuAsNzLyrtgjWPTCWeGE5qMSvOvOHbbBgfrfUWl+JNU/P7XPGGmima8etqSgc7cJ2fQmYGaBNONDaCV4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MKwCXH5tSajthQrSsTUkeh0uBy4cHuSLSGe60C0HQNI=; b=A4yhGX3Nb+ijwjMz9FBk8+fr7iQZb01wyLGl3J8TWFla3xG9upjAfB5wbbl1OUGaP8Eh2UZh5JUaNlAO+Im47yfeKAmvMppJ60Fb8cWl5mIEehtz7riXwIeQdV5McfTMHE3+PFX8B5pJ6lFVxikTQtlVobJs0Q4NP+FSeron6ko= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB3065.namprd11.prod.outlook.com (2603:10b6:5:72::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19; Wed, 6 Jan 2021 01:49:17 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::5c3c:da40:5046:5413]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::5c3c:da40:5046:5413%7]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 01:49:17 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" , "ipark@nvidia.com" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging Thread-Topic: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging Thread-Index: AQHW3YSUP9P28G7RYkuWmNVGdL7IgaoWyJ4AgAMYkWA= Date: Wed, 6 Jan 2021 01:49:17 +0000 Message-ID: References: <1656E6B2AE248774.11073@groups.io> In-Reply-To: <1656E6B2AE248774.11073@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0073eac-718c-44a8-b916-08d8b1e54752 x-ms-traffictypediagnostic: DM6PR11MB3065: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HMDzNC5KCdydvVombmyFJJoKsXhRRvRaTujEt9ZZpmtMhJ9RTICyBkx7ZBgldOcusthPzfp+3LLHj6KuhhXaAcL2PKIiwip8HBGmloKhAt3DYZcDcqmwNyznilb+Wy2gHNjw3LuaIlSwrgX5iXFHy8CllGIGtsa+73uTfQHs3GIyzN8J188skP0/7g0OgTV7od9GWcPoGv8MYW3NiiHAfPJ3QoRt3/GmOwYvYdpiqv30uB1FdYSV8ztokeVpn1JUCZTE1fOIu62YbG0N4HV3QZCwswxscNHxXZZZz7VNn/VHF8kpofgPjHW/G+37/MdZx9rL3ENSZ5cAu3IgVD7NAJ0nsPfjQQRd931JBPteeydnl8bstbTRNSEMGpC8qTz9+P0xTj9bweB9ZE7yQOiN9/wvBI2TX5ShWf6le3JrQwoo6gdMFhhkDDAYurisosQCCB5MEdXS2F1ECq3WcFxgPg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(366004)(136003)(346002)(39860400002)(33656002)(26005)(52536014)(186003)(966005)(7696005)(6506007)(55016002)(53546011)(9686003)(316002)(8676002)(110136005)(86362001)(64756008)(66446008)(76116006)(66556008)(2906002)(66946007)(8936002)(66476007)(478600001)(83380400001)(5660300002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?nH3PFQCwlXiv/VkzF8tCIDieDnCNZzpeU5GPFR+rqGIl+n5OS0iLQFMNODcb?= =?us-ascii?Q?q0Xxa1Js3ofxo03DaS1LbnUJkAPI9vASbvSSipDccqCcdPDgbaUHQ18lCAUv?= =?us-ascii?Q?16w/H0yRsejHzcUJalHkuuIO83Jmo/L/8ExPfADXQD/rGUJn9W/mYaQzslYa?= =?us-ascii?Q?r2dbsh+si7eLUkkA2w3dpugOZA6Znq30Vi6yleVlpc/ZcxRKPIl/OcLYgIeU?= =?us-ascii?Q?mhDC87q0pC/BYC48P0WTUq9PlXjOQQHkLMbyDRLDc91jY+1ECX+tc/AhqqiH?= =?us-ascii?Q?kRhQL3ANj70iDbMGuzV4NaDDSV5VO73EUIp8KBBedN12Gv8OvUY4uy4EBqvX?= =?us-ascii?Q?exB4yiXJK7X1/KAIiQwSRSyc/w4SMO7CjqXyRNXQ7pk2lV86q4fulqbcKcn8?= =?us-ascii?Q?60I6DUmuC02RKdcABH2HjQcA/3qv9pm/YOK0CqMAZzwM6KENH8De3Eo1w+4y?= =?us-ascii?Q?lWP7N7g+Pb1T7dKmb3h986NVxVUsPlh/ty7gAYbtAtN8LHGWrDhA4mP/3kfs?= =?us-ascii?Q?dBEnztwudVH1IAuGwlwMxg7ENdYcfTxfUwBcFT8XyYzWNeZJeMm5QJeXkte7?= =?us-ascii?Q?jT/3vkba8+xL0zDds8A5HmJT5e7MlGmz7g5wkMcKoJoDJI/jZkQieWxrKq7h?= =?us-ascii?Q?avVSdlKUDDHFcah3nJPxA8X0C2+6xKk2n89Wpw6PjiZdJ8zIXlaYdD6OlUMx?= =?us-ascii?Q?lt9AvGONOO/gvGmZo4vev5iIBG+ZB8id7JQDv/yosSg4ChJNmLIcODxfZy32?= =?us-ascii?Q?GmOW0Du9GpNBt/LJzuCpFldudtlKvl0rXtO9XaQppV7fL2zUhdqNovvjmpWs?= =?us-ascii?Q?ZNhQ2MmJzkKAoxl6iPnfRAUaGv7JW+zwkJCOc5Ikaxc+p+omv+Ss7iExid7S?= =?us-ascii?Q?eWj4Tn4j8V//sL/p1UUSYjaSN2LXrSXnnujopZV885K4XMhX+Wrk3oFQ94GG?= =?us-ascii?Q?kBWlCJgNi9yUXCjiySl0SiNnecOaLDUjFkIy0LGpiOU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0073eac-718c-44a8-b916-08d8b1e54752 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2021 01:49:17.3666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XXc4Ml0kKJvVo9vUk3m9DXBAtYP1+qQaZzUO5ASRql+KwfCkPE+sEJwGaTl6ALCSjor+2x3Cykw4l4RWVyUhPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3065 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Created a PR https://github.com/tianocore/edk2/pull/1297 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Monday, January 4, 2021 10:33 AM To: devel@edk2.groups.io; ipark@nvidia.com; gaoliming@byosoft.com.cn Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix the improper error loggin= g Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of Irene Park Sent: Tuesday, December 29, 2020 9:47 AM To: devel@edk2.groups.io; Feng, Bob C ; gaoliming@by= osoft.com.cn Cc: Irene Park Subject: [edk2-devel] [PATCH] BaseTools: Fix the improper error logging From: Irene Park EdkLogger.ERROR() was replaced with EdkLogger.error() to deliver the expec= ted error message when an error occurs. Signed-off-by: Irene Park --- BaseTools/Source/Python/AutoGen/GenPcdDb.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/GenPcdDb.py b/BaseTools/Sourc= e/Python/AutoGen/GenPcdDb.py index 0870c44..ad5dae0 100644 --- a/BaseTools/Source/Python/AutoGen/GenPcdDb.py +++ b/BaseTools/Source/Python/AutoGen/GenPcdDb.py @@ -894,7 +894,7 @@ def CreatePcdDataBase(PcdDBData): delta =3D {} for skuname, skuid in PcdDBData: if len(PcdDBData[(skuname, skuid)][1]) !=3D len(PcdDBData[(TAB_DE= FAULT, "0")][1]): - EdkLogger.ERROR("The size of each sku in one pcd are not same= ") + EdkLogger.error("build", AUTOGEN_ERROR, "The size of each=20 + sku in one pcd are not same") for skuname, skuid in PcdDBData: if skuname =3D=3D TAB_DEFAULT: continue -- 2.7.4