From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.15759.1601365817721417250 for ; Tue, 29 Sep 2020 00:50:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=D6C3+zST; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: bob.c.feng@intel.com) IronPort-SDR: RD4txuWr84nCaxLYICwWkgeRIDlvtvqDjqaVEXZ0RgG2MeOIHhQJSyEv2+Y/0+0iJALsRCr8xb BoxqfQ8uYF6A== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="159513371" X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="159513371" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 00:50:13 -0700 IronPort-SDR: QUpSkHnkHq4EO4JCnTT4DLxOwJv96hYXJ9I2b6NXfx98YhFHv0Wl/vYUxNS9X6hURjGjz+YF+6 uG+Y8hM24Ydg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="340761750" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 29 Sep 2020 00:50:13 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 29 Sep 2020 00:50:12 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 29 Sep 2020 00:50:12 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 29 Sep 2020 00:50:12 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 29 Sep 2020 00:50:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QOx7xzyH3/EehZUnekZ2Bxf9sRN6L/6nAypJsJbcioJh5m5Sl9aGZnRktl6jzMFn+VX9bntkL65VS1A+H27KYydtBpdF9d8xO2RwntEEhOWKy5m7c2OzubGk/YrJUmRUj8tqlWzo7vAhClqgkPfYnQoixHTOG7MxlNAzDUov1GeWX/YN2qanB/+en2N9oelKIvhZG7zeOvIIpwQVaKVg3eOOFbRmZQgJ5nAgRwyfX2i7UMwnMHciXlstm6tkloZMnP8TWnDtc+GZU7XFCYTo6/In4o2IKjZVv/0AhPQ+Gbt03MQG36I9Wi5NmJ8u3+0jEYsoLXxomnqBRWOdA35Rug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKHV8ENmxyCIXQDYpvkm1oA3NY9PoUIp2mEW5hM/N6o=; b=lxnxDRwkfDM3ISCec7GO9h7ltcTMQmnboj7byH9ErIV9ipn+8Y5Q2SKEqU4VcV8PiEipmZKR8BTvt0PTb7qqheRgOrod4JGg+jqtrHVIVZXLO5BBRqgZPq+GARDy5aEn9+9PWrJ57W7RPrwt+wSOcl2zq1MfsRKDJLjslB5R0LePtOBSnaQ3dgsqD7X2KBcjA9kLhMVHmQMt8iNe/UsAEWjw85Not3/G5s0pN4Yc6qCkmndL7TboCRTX9jJ5I/UBeWpt51BPtbh8aEPJ1AHTqa2h3n4sXbwVKsRd8P9pI2wQWrf8akDPchYRix6yq+zEK/QyjNkqYmGeIaI//9H26w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKHV8ENmxyCIXQDYpvkm1oA3NY9PoUIp2mEW5hM/N6o=; b=D6C3+zSTObE1mglFi5PWKutWhac+G3Kh4OjL5TyazDRqI9SM4WlLb4RvhUE8JT81TS9ZK/oXpcgT6UMzue4hF9rZH06GWl3BOGsL1u7vUUgnYjkur+kJG657EXmYu87rG2q/F0aNMQR2bqKfnYDb5qKwCzL5va1uONqV5la0lxY= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB3867.namprd11.prod.outlook.com (2603:10b6:5:4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Tue, 29 Sep 2020 07:50:09 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::88bc:d834:df24:ea90]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::88bc:d834:df24:ea90%6]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 07:50:08 +0000 From: "Bob Feng" To: Liming Gao , "devel@edk2.groups.io" CC: "Chen, Christine" Subject: Re: [PATCH 1/1] BaseTools: Move C tool flags before the common flags Thread-Topic: [PATCH 1/1] BaseTools: Move C tool flags before the common flags Thread-Index: AQHWi8UvsDVCKiGxiUi8jOzt8dYNjKl/UfdA Date: Tue, 29 Sep 2020 07:50:08 +0000 Message-ID: References: <20200916010301.1247-1-gaoliming@byosoft.com.cn> In-Reply-To: <20200916010301.1247-1-gaoliming@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2038ae37-1899-4c60-dd91-08d8644c49b3 x-ms-traffictypediagnostic: DM6PR11MB3867: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:287; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b0ybMlJpCNf292J6W3NwLMyKNs20CMZWX3+X95tR4R43GOEeMiq0fg+rgWXNYuRcMQRBEDYJJeD+39Hn6eHPdygr++8PvMMBIglaNvohJOGPUeoMQoOoecoHY/MCA7wjxr4kHtjbe6YiBznK5a712POTPGgzhDImiMnTPXfc+7dTbT72hAY2GoQuZNP0ngDf2UDOlkDBaijTOPmOzDBcgIex/BwNJcoBD8pNm6uyNKPznlkwLg0SO2aWv2+TXfLjhbY4PSpE2gFWikUTF/Xk1p+z8+6hUhXqPYYf7znY0hIhH3K1tojDq3qZrlM7qpA7yZburmn42HxA5KK8LYdR0gxU1EH7vBuDHnGUG6aJ9n2ZsTqNe44l6KLB/5RfxNJXblWvTr1l14sKKQU3HLT/L+dJCyWhvlEwDPDFchsZ5hxnaI9uVzp2fMY+77zvDlfy8QwaVH8l5mLDc6SjBXyxMS3/nKR+f6gPwS3j/A9GLOk0WrMgeTppPA4vh0P4eB+fggGk9Q3Zjqx5C+fC56MvGYCQonowWPfVLt5PqZOSK5o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(966005)(26005)(8676002)(71200400001)(52536014)(2906002)(107886003)(9686003)(76116006)(66556008)(6506007)(7696005)(5660300002)(8936002)(83380400001)(66476007)(66946007)(55016002)(66446008)(110136005)(64756008)(86362001)(186003)(478600001)(33656002)(316002)(4326008)(53546011)(545624004)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: iIGCQkJYPVDsgta7iQyF1VArdi8NcqveV7zbUk8zZCu4f0WfXKTZj/umAk5pTbS9K8YMi7cYtBkaHq5hGpO87cALdgMYJ+RKqHyx5kR4daJQMV4PXvTDXwXhadt15/a/AB1YRzC3hC3k0T9DPxtkGzlRfxg/Xautf1/z/xnQziVtrdn0DOwJPvL+L/kpAv6GDWOJoQLuGmq2iXVkPCDi4rxgNzd1vXxY4b7SBn7UKeb0wxuIFM7VCek0qMRzpH+lDbYCoXR86GwMfbeFsSlITCsf0cEdKO+FPYrUurPvpEWWpdLZBrfr80CaIJDc0xIzHPZ4OrsRwhjAt/HsOJGuYSWBizNJSvjyFJe40wLyL6hOJICbVU4xcu2IggBHmEOe2qu2tRLmXSmaw1wLsTNFS9OXFGfN4+2p5Tmcyi9SsJZLha4FJQOWC93yelqhb4eGVGB9elbVkQ5jufY2Zq+dq4QWAnM1djtyOF8ujI3pBrIpRMOk9E9u/r+55qdcCNhE352VmsfvzKwbyHVKQJcWt9z7PylHvwLWt2arh+RqqomGXkHe9hB4GpitAC65H1k7uTdiCG71Y8vt3WYx+xxPSE4TCX5WTubreqJvcmjjjnO72Dg9Wx81G8XR588d0x1sAQmGQWAMwCTymMTo6Ka9Hw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2038ae37-1899-4c60-dd91-08d8644c49b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 07:50:08.8772 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1A8BfCVOmTGB9Ke8gS3bhwURqbngc9o8PIVKR1ZYYMnkCkBNjXcIudyWggCyry+isZJJj3cSY7PW+LvfOp6DDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Would you explain the purpose of the change done in DscBuildData.py? Thanks, Bob -----Original Message----- From: Liming Gao =20 Sent: Wednesday, September 16, 2020 9:03 AM To: devel@edk2.groups.io Cc: Chen, Christine ; Feng, Bob C Subject: [PATCH 1/1] BaseTools: Move C tool flags before the common flags BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2938 C tool may add the additional INC include path. They should have high prior= ity than the common INC include path. This fix is to resolve the structure PCD issue to refer to the same header = file defined in BaseTools and MdePkg. The one in MdePkg should be used. Cc: Yuwei Chen Cc: Bob Feng Signed-off-by: Liming Gao --- BaseTools/Source/C/Makefiles/ms.common | 2 +- BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/Makefiles/ms.common b/BaseTools/Source/C/Ma= kefiles/ms.common index f5f77fdc0bc5..b2dbcf376c04 100644 --- a/BaseTools/Source/C/Makefiles/ms.common +++ b/BaseTools/Source/C/Makefiles/ms.common @@ -55,7 +55,7 @@ AR =3D lib.exe LD =3D link.exe LINKER =3D $(LD) =20 -INC =3D -I . -I $(SOURCE_PATH)\Include -I $(ARCH_INCLUDE) -I $(SOURCE_PATH= )\Common $(INC) +INC =3D $(INC) -I . -I $(SOURCE_PATH)\Include -I $(ARCH_INCLUDE) -I=20 +$(SOURCE_PATH)\Common =20 CFLAGS =3D $(CFLAGS) /nologo /Zi /c /O2 /MT /W4 /WX /D _CRT_SECURE_NO_DEPR= ECATE /D _CRT_NONSTDC_NO_DEPRECATE CPPFLAGS =3D $(CPPFLAGS) /EHsc /nologo = /Zi /c /O2 /MT /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE dif= f --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Sou= rce/Python/Workspace/DscBuildData.py index 1afbd3eefc6c..eba65625337a 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -2639,7 +2639,7 @@ class DscBuildData(PlatformBuildClassObject): else: MakeApp =3D MakeApp + PcdGccMakefile MakeApp =3D MakeApp + 'APPFILE =3D %s/%s\n' % (self.OutputPath= , PcdValueInitName) + 'APPNAME =3D %s\n' % (PcdValueInitName) + 'OBJECTS = =3D %s/%s.o %s.o\n' % (self.OutputPath, PcdValueInitName, os.path.join(self= .OutputPath, PcdValueCommonName)) + \ - 'include $(MAKEROOT)/Makefiles/app.makefile\n' + 'IN= CLUDE +=3D' + 'include $(MAKEROOT)/Makefiles/app.makefile\n' + 'TO= OL_INCLUDE +=3D' =20 IncSearchList =3D [] PlatformInc =3D OrderedDict() -- 2.27.0.windows.1