From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.33627.1608516512142622280 for ; Sun, 20 Dec 2020 18:08:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=eozXOuUD; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: bob.c.feng@intel.com) IronPort-SDR: HHWhGuHZsLEMf/yLWudEOML63LAWC8PQhyfa2nyLfMwJEhmSBM8fACxgnTbtVpkC/vMoEN6h0W kV6rtqr3g5cQ== X-IronPort-AV: E=McAfee;i="6000,8403,9841"; a="173099430" X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="173099430" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2020 18:08:31 -0800 IronPort-SDR: Xt+WJl1nO3qI4DHNRZKcKZ5kXz8VThVAJe1nX/CGUI0r8WKTLSLoscDhz2fUKCEF/1H+u6VnXD CJaXa1mBXcBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="491308650" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 20 Dec 2020 18:08:30 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Dec 2020 18:08:30 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Dec 2020 18:08:29 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 20 Dec 2020 18:08:29 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 20 Dec 2020 18:07:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AGvQMMzDwBrxK6wr+iwPjcnptihCK4KAWN/McRCrpb1KKcgICZ16VHs6/B19/ctoHzx8Vjivhmm9OX3BqQ8lUbdzxtomAHMjN/AqoyjxCVnvZ39oz+fIA8P4Y503P+KghhcIbzLcKGJtu2cBHQkBgx7MHuPldHPYGRVM8uzGawv9o0SX6dU6jNizUyUqjZ8qbNecypN0jFfVSgDPH9rcePJHH2av92A9BDovQlubf8+dh8/FQsIwyo2pZEzeSNAzC0s7fIPYMg/x72aegTxl3omTa3fwaybgNkqtfw2P1xRDLqqo4GN9PxfAXK3tcjvTIiUzDlU4q+yhEcCXZIE9OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tcq1QqdZf4w/I7Pkqc8Do5H4kg8SmJZ3LH0nvYU/TCs=; b=a0xe0DO7a1aSwzdsOmOvLRSYGyvczr7FqWPwkFAPYFj+RVaKwd4PXD/kQ+lxfw1bfjuxb83GAGd5woBdOdZ8M4ibT/1SciF8gOeu4SW1QEYz73+HzIR9QDSUXEXiwwcR7R3sB4FfOalmrLtjlanbTNihqf78zvzRvIQPLDu0DC79X+IGgqBairQrOvQCwxP93Hhece2BzHEA9pkiLaHwLAavuLGKXjQ+0bRidsyM8aR1t/beNFh6RtC3cWf9JBdhO5k9X3kj0UFFfXJ8aFzNSbIw5glVQcQ7H1MsvKc2jtCYo7TkeUXWVhlDPTCaWtFOiraaV9g0xeNczJVSZvqd2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tcq1QqdZf4w/I7Pkqc8Do5H4kg8SmJZ3LH0nvYU/TCs=; b=eozXOuUD3TpYBc/lkBV+UfRnvsn5pmXjZAleBNEEyt4Pit75kBrT/fGUFAr+xlWLl+aX3PYm5k2mx0v89OfFX0ccM7LBvoO+O86fVO4KG4boxpuKvNNmzO2UGUSchnIc7bZ7c5U1w3zo7byzj7Ae1+WVkTRCJRDzta2GDFiMhuQ= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB4530.namprd11.prod.outlook.com (2603:10b6:5:2a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Mon, 21 Dec 2020 02:07:07 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb%3]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 02:07:07 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "xiewenyi2@huawei.com" , "gaoliming@byosoft.com.cn" , "Chen, Christine" CC: "songdongkuang@huawei.com" Subject: Re: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing else if statement Thread-Topic: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing else if statement Thread-Index: AQHW0qwhCZlEOlNuskG13ux6iJp9/6oA1o6Q Date: Mon, 21 Dec 2020 02:07:07 +0000 Message-ID: References: <1608013846-109318-1-git-send-email-xiewenyi2@huawei.com> <1608013846-109318-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1608013846-109318-2-git-send-email-xiewenyi2@huawei.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 827c15b6-bcc9-487a-e5ee-08d8a5551e7e x-ms-traffictypediagnostic: DM6PR11MB4530: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4LwefHQnzUPyyANP1LlOvqyt7RpvbwklvulWVRnrwLQqtgxRR8bh41fRIdTrEiAvv/ZAMl82SYuXyih/o+MitO0N0uLgBcgvKBVJU2tqUbkoayo0pPYGbwb6fm4ysXiDaNWKdh498TWQCcELAV7HcR3m9387yXWGsCAurWwBVNdFq0/F3H8NtPVUp/r/h+68/D/bDtIaQ9tfWv/gAC8wOuSxZW/KRIxXm5vMLeVJPdL8oj6kfBVYuCSCyHFwiFeAUwkKhwbEal9VhftRvYTy2e32oHgW0cVo6LiU1lZdzyoQDiYGmGiL099FagyWYlo6LBnFcLBKwPVQLmy8MRpc2V7KB0T01OLZ8OPrOjKX8IAwfzkO5nwADDzrXZmCryqj4F83CCE2wK0imM7uiu6QgD3ZhCs5n9+MY/xGjh3G9o36nLPnG2kXjcZfopILOCQrGnj3WgrvpwXxAp+J2BGHGA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(33656002)(8676002)(66556008)(4326008)(9686003)(55016002)(66476007)(53546011)(6506007)(5660300002)(76116006)(26005)(66946007)(110136005)(316002)(64756008)(6636002)(186003)(966005)(8936002)(83380400001)(66446008)(2906002)(478600001)(7696005)(71200400001)(86362001)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1Tcfj0F+bLT5AayFneqpVSZSMQaKGnnnuqoUruj2JwePBYgF301Iw7RnGtoX?= =?us-ascii?Q?axtsuwuikMiOC7pKe0ZH7f6M2E8RlMKxoa2pQ9pnKGPhl60PVgSM1iqSkBv2?= =?us-ascii?Q?CTsJCAUVTQ0iA2ydEQxkFaz4aKDym7dlPgInHn+xbOlzfS4D6uWI2qB3CHfp?= =?us-ascii?Q?XkkkwPcVURLVV12NWPNOocLj6nMa+aX4AjgRsF4fob1UXlBsHy+nSp5hFqGg?= =?us-ascii?Q?fjMaAxaubBbER1jGfc/Qve6muA8MPzhhhyKuLsi4aR3QVFp4dkp5H0iD9Agk?= =?us-ascii?Q?amn1/VfNVkeSwdhenVakfh41Ok7cwGyX3vdhdU4jnvC53P0t0X9F2iCPGM9N?= =?us-ascii?Q?4hWfhnPsWGnJzMfabXWO+DnfisaNqG8yPII4tWb+cReczlpfNW6JzyiwQxii?= =?us-ascii?Q?FeXtTmnvGg15h2elSb2tTJXP980yvdDFqQwQMu575bua23ip9LlGZ8r3eZa+?= =?us-ascii?Q?HViw9TPwttyokz/UZJXYqhVqIdaZvN4qnC6jm5XigYH8E86XysD//ILvFL+1?= =?us-ascii?Q?vuAy0OsnDVsM3S1IQ3sM/g5LnIEp6k5MgRsARMMaMTp7YTmmJmSTE9gtoF+M?= =?us-ascii?Q?OUj+HYswaG4obdTH+gS+cMxt6Z1ubDT50Z++ZZXvtYpVDdWU71yilZhjPxDL?= =?us-ascii?Q?VtNEGgw0BwEqdMDi3VAvyJxk2bl2kjBP4NdWjn82g6+wLaLwDqeakH9F4Jx1?= =?us-ascii?Q?vhq5S43kkND2Tj/plpwEIwEAo/GFN+o2FZjMaj1ZwKwv8rBQ02TeGNsH+0ki?= =?us-ascii?Q?1FarJZxQh9I14hLgOP8pu/hkueRp4fxU/h16nIy5mz7tJ0ch55bYDWGXddnO?= =?us-ascii?Q?ulYepRtlI0mtAQEopRC4PRun60CjHaQU5e65vP/QlAfz0kvVYflx/ZIvXwiS?= =?us-ascii?Q?Kr/MwutuYWJhLP+Eds7+o67XoxPI3B5kSlU+csUBv7SRrENdi0RdaX8Rl9lb?= =?us-ascii?Q?AeFHXH5XlGOR1OW9QykN1yn8acuki/jky6gPw4IzTT0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 827c15b6-bcc9-487a-e5ee-08d8a5551e7e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2020 02:07:07.3682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O05w5KL6wFoUrXSNXc/bjLru1dGJBS+npC7R6kt2Qo8bbJFnkW8TMPbC+duSl+q+fAtr2rvcEhvVM3l/vVtyTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4530 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of wenyi,xie v= ia groups.io Sent: Tuesday, December 15, 2020 2:31 PM To: devel@edk2.groups.io; Feng, Bob C ; gaoliming@by= osoft.com.cn; Chen, Christine Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com Subject: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing els= e if statement When Alignment < 0x400 is false, the expression of Alignment >=3D 0x400 is= always true. So extract the expression from the else if statement. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie --- BaseTools/Source/C/GenFfs/GenFfs.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c b/BaseTools/Source/C/GenFf= s/GenFfs.c index fcb911f4fc34..949025c33325 100644 --- a/BaseTools/Source/C/GenFfs/GenFfs.c +++ b/BaseTools/Source/C/GenFfs/GenFfs.c @@ -821,12 +821,11 @@ Returns: if (Alignment < 0x400){ sprintf (AlignmentBuffer, "%d", Alignment); } - else if (Alignment >=3D 0x400) { - if (Alignment >=3D 0x100000) { - sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); - } else { - sprintf (AlignmentBuffer, "%dK", Alignment/0x400); - } + else if (Alignment >=3D 0x100000) { + sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); + } + else { + sprintf (AlignmentBuffer, "%dK", Alignment/0x400); } Status =3D StringtoAlignment (AlignmentBuffer, &(InputFileAlign= [InputFileNum])); } -- 2.20.1.windows.1