From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.3937.1608103031198536812 for ; Tue, 15 Dec 2020 23:17:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Sz/GNKaU; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: bob.c.feng@intel.com) IronPort-SDR: 1hzpklwMdgRxgaHiwhItjJOJwi1zm857K7mk6SOYpg1q/G/LkvEIDysoqMzFBNVttGtTscdstj V2M0U1xiH9vw== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="154250474" X-IronPort-AV: E=Sophos;i="5.78,423,1599548400"; d="scan'208";a="154250474" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 23:17:10 -0800 IronPort-SDR: IK708hKBuFyBoe27Vz6IPTFPSJ9DRUwxJyn3f8YPEfOiOutd0yVyQa7q4fLls0hjAc/lJ7ZSej wY+8RkSle0IQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,423,1599548400"; d="scan'208";a="352427576" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 15 Dec 2020 23:17:10 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Dec 2020 23:17:09 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Dec 2020 23:17:09 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 15 Dec 2020 23:17:09 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 15 Dec 2020 23:17:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TxIfjroq/MkD8J6m5L9s358QFCzuTiAQ6GToK+HCp5v6XgcoPflVwxK0h2z5GoVGA81t7DtlDKI/HQGpLspvKp29sYwD5Vs0zOF+Nex0GtP74H6RGZ4GMiH7HL4wZVIJgr4keGKPDpDq9mzsgq3YnleAPtn3uxBs9H9gotd+UD7Jii+6aPxk2yvnAUFIvGhbljw8bQSb5cN82TmLfLGG2nNSOMzMHWkQC+0bzlA0blOjSMivH91qQMnMPALk/luHJ3yBdezsyIQatPAfEYoJJ/hgxV3wFe1vKH/7N19vVcM6d6pxQAHvYTSGxs9vqzyWa7Xa1SXhbPXhniOi0OfeNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y/NimmMCH3xUMnj/yMz5Xe5WQAagyMmt8cnoui8XN0U=; b=BckXVX1+z06fXJyKmHJJTuC2IkFEjHtusiP78xa//JfqSryxmW2nunE+Ixi0AXb98ST50q0u11rkq22FOJcvXWtT5S3QHRaIUsl/kfOF7fF2RFhm4VBm4RaKP+7KY+Ix5rUDAfa2LheECbia/TKLQuzrsSqeG+WTbIAx7qtPTIRoSWTF35u82DnUBjEfiMWDXRncbEWWuQ6dgMbmJMFMQ6j6YhmCWmosmrhMbzRbWNt7BOBT+UclllctnNFOiOJHJe6mXWCfDIprDJH7zZoy9JqkZAP9yDDLqHUH+oZcLIT1LYxWZw8sZaTWX/EFdwx5rEUE4Sa0BOI1kgsQCjiu0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y/NimmMCH3xUMnj/yMz5Xe5WQAagyMmt8cnoui8XN0U=; b=Sz/GNKaUHy2RNq9ZjE3LAse02PT7hAYXuofaN33d5McWou23yCQiiAoj2yygG96TC2WhGUrCCOm58xiDjG/Vb5OgqZt/rmdEDejK48uwBFs3JK9fWzUTMau717DGsMn/oxZL6Ksc6UVFIqnKYvF8onPSnHfQxw4UTOtZ7n3R/5I= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB3801.namprd11.prod.outlook.com (2603:10b6:5:136::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.17; Wed, 16 Dec 2020 07:17:05 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb%3]) with mapi id 15.20.3654.025; Wed, 16 Dec 2020 07:17:05 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "zhuenze@byosoft.com.cn" CC: Liming Gao , "Chen, Christine" Subject: Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH Thread-Topic: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH Thread-Index: AQHW03TgNSd7zIR48EmyfswHoiMu6Kn5TqVQ Date: Wed, 16 Dec 2020 07:17:05 +0000 Message-ID: References: <20201216062929.527-1-zhuenze@byosoft.com.cn> In-Reply-To: <20201216062929.527-1-zhuenze@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb71aa98-4388-4b42-0951-08d8a19297b7 x-ms-traffictypediagnostic: DM6PR11MB3801: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H/oi0c2cuNzFgv6xnBAzFOTKR1MYd80XsyLsW4/aBHN9hh63cCoyP4LtfQCV54KEGoLIYPQIoskOFiBXmtJjscjGiRjJyhy4GfmbgbZfENKzjUZFVZ+BLJ+O9VutRU6yhRZT66szit5k8wJS7NIhYkAgVE+VrKDTbE6K0xVAiR4SQasYexkJQSC3F1+/NzU0kQTGNWeXccefbAS84n7Z+SsYm5FM+XmvmZ1ISRWIuZPQ9pt1TsYvZZzxVMTMcsn5sYHEEIW/miRQfLVhCafle4ieXWhTFEWbM/q3f99fPay4iUf+uxUXVehu2ci+GxzPoCRHE+b4AHrQ0ZfRzYupzOQy3sG/UTS0MLqO76Nm/LHH6hfZ2C51zNJQFms3uCoyoWJHtQLCNcTzQPr/qXx1Xw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(346002)(39860400002)(376002)(86362001)(64756008)(110136005)(53546011)(8936002)(478600001)(71200400001)(83380400001)(66446008)(55016002)(33656002)(66476007)(9686003)(107886003)(5660300002)(8676002)(7696005)(6506007)(54906003)(2906002)(26005)(52536014)(4326008)(966005)(66556008)(66946007)(186003)(76116006)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SeXXVwA3Uex2D+NFSUujLNgbfPHc/+yyQtT8TT4OjSjl+4T4RrudJ5vUM9N1?= =?us-ascii?Q?QKjF8bzJiLZUWKooD5Bu2kQwcENA0HlR0OO07rNtw4sRKoPTrC3GIziUlJyd?= =?us-ascii?Q?L6rfRBLjLKPAcGHm3MtLX/vs87bJGkfAJXPMNFkYNJmhkJPnjSvBbgvxTzy8?= =?us-ascii?Q?RAYwVpcem+ttAZsxyZJkGoZXbzHUSS9RoqCR2ilTVNJ1RcCs4dmY07rkv/Lt?= =?us-ascii?Q?LH+NNGiM17CRrtcmdn3z/k3Ofyb3ef49ZBvyOIFV8ZO97baOjoI85QeS+yU9?= =?us-ascii?Q?ZQeVD/+O3q/Vn+hYvPG+VQ0RSyVyTqWZ3lp9vgi/xJYSzWjHvLvb89iSQTU4?= =?us-ascii?Q?eT7I8OOHTF6SRXs/nojwkqlqsZ3y/q8a8NucSrWeadkJwtEvV+9FEyhN6Qv0?= =?us-ascii?Q?LWj+3voIKVzM+quGH5WnCP4i5xB0v4VAIZTeZTWqpbXPWkYlyyQO9s1Y0Wtq?= =?us-ascii?Q?yVmezmQl5qH3jTQSB5KVGdomQsl8dz9sIPt1qN10CC9dwr3Nt8CdRTUBvLr0?= =?us-ascii?Q?SdXNC2SqmKL7MKclnaGnkcvgkHl/7kgkP8pAKtKDFKPUABYaWAW0xyFJwoKM?= =?us-ascii?Q?EI3A2T0+Womh4eDC3pEl8AunIf7SGncERokiA5YJwqnqCOigIDw6yg5NeROG?= =?us-ascii?Q?AJwllZ2UwtDdyjpfV96dOZcVjcrxs+Z9JQ3K6oBlUe9AhqsWJskyZ6QB/KuZ?= =?us-ascii?Q?Hf9WFNgULophd2v2Zif/T2ZTrLDsVcaBRq5qYbF+sExbVq7p+IeDYGm4ITDF?= =?us-ascii?Q?fLiYjHUiQmw4aIyVrhzJSr2xURTEjZImqpbjkKVvnuHIhykUw1AfPeU8AyBr?= =?us-ascii?Q?YekisNHDbK8lxJM0xMqROLC9O1p7+FED7ojqUeSli3684sm+A7cSq5rKfM0I?= =?us-ascii?Q?WvtkNQ/5YRb3aUYvd/cztTIEzFT1EDas1bMluD5Z1MOdXHRYlCvfdeLZ/fTF?= =?us-ascii?Q?urZxqrxIOLyWrlNKbhJMWGt5MosBK4SHjB2dtoPhf8I=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb71aa98-4388-4b42-0951-08d8a19297b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2020 07:17:05.4727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pDWB7wtJKC4UNlUBaObFc6oQyxeQcHloqn8lHPfS4GvUMcm8O/3Zmlz6aSltdFmGG7dGhuUJyArppq75UnzDbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3801 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Enze, Please remove the "Reviewed-by:" from the code review mail.=20 Reviewer need to reply the code review mail with Reviewed-by. Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of Enze Zhu Sent: Wednesday, December 16, 2020 2:29 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to M= AX_LONG_FILE_PATH We had a build fail due to the hard coded MAX_LONG_FILE_PATH value. We should use PATH_MAX if it is available. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Enze Zhu Reviewed-by: Liming Gao --- BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Co= mmon/CommonLib.h index e1cce985f7..0f05d88db2 100644 --- a/BaseTools/Source/C/Common/CommonLib.h +++ b/BaseTools/Source/C/Common/CommonLib.h @@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include = #include #include +#ifndef _WIN32 +#include +#endif + #define PRINTED_GUID_BUFFER_SIZE 37 // including null-termination =20 +#ifdef PATH_MAX +#define MAX_LONG_FILE_PATH PATH_MAX +#else #define MAX_LONG_FILE_PATH 500 +#endif =20 #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL) #define MAX_UINT32 ((= UINT32)0xFFFFFFFF) -- 2.27.0.windows.1