From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.7850.1604902619310976024 for ; Sun, 08 Nov 2020 22:16:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=oY9UcJlz; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: bob.c.feng@intel.com) IronPort-SDR: N66bi2gCl68UtgPxuEM18PaPoW9OE70LoJM0A0ahS+OKkdlX68aEHi74jx71St9g8Wg+O5ThDN sy6CUhGq2wiw== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="149034045" X-IronPort-AV: E=Sophos;i="5.77,462,1596524400"; d="scan'208";a="149034045" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2020 22:16:58 -0800 IronPort-SDR: 9tEMYQEgZw3Ij6jIn/0eh7LnXRC2xi2RF+3NImh6pRwwsVjy5DSBIOLUZpWlxt5PKikswtjlWP nrtZSs6zD+RA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,462,1596524400"; d="scan'208";a="427890546" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga001.fm.intel.com with ESMTP; 08 Nov 2020 22:16:58 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 8 Nov 2020 22:16:57 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 8 Nov 2020 22:16:57 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 8 Nov 2020 22:16:57 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 8 Nov 2020 22:16:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UzuTAMDIkqNyKX/yb8v+QIhOLlPfGWwh3BjBlQ02z8PL8SjffLN520gkHs2l3E4sWLQm1hZmqItLZkwAkGotSqTCOTZQJxVmRwBkZjyeIT+M4fx/R0ThvVau4BrVEV1HZUBTRqqC50VntNx95bsOBC5vIQ4bCf+ekr5evVk7+d7CB/A6dKZwgKWw3bPZFZoUGVnoCM7sxT3eDJKlRjujdCgteSXbKWmXjpAnwK9oIXXb9lirThuBHLMbudcxmTqrsQJ7YggUdRN/LdV9coqY9A1UkTqR2GUoqyrna9wtE4r1rzre0QsyAHXvJNeTGFp4kjAWquFCS6EFFRcwhVtvVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8vFMaWK3L5ENW5xkwKxjoKYmSOsfoG1x5ZrtZEFyKz8=; b=aq4UPOBHhI9+3APjmxcQ8ifjO0uvQtgL5XWH5TWi43QPvdkQSJib+Mka5tUSYHGqNAL6t2FAvPbmO/5UaFSqHeTY5xPBeuG6+7siJj6l8StmIqNdAEPh8f1MQy3MzNf/ETrdzsAiNDRWj0GlB0Cw0tzWyVQnk3iK9p0r/kCFVXWTvTx/godd++9Os5Bv+quIlW/4RAVu8iiRHj2R2uSGKYMK1lA92dJWLnG62RYJW4hQGGzLTCuF7QfG2qesz62MeQMUNjqXrmdF+38wAATYfmWuuvXHbXLuHXxyJ+s4YaRj3fYFN4IM4eCmAefbgxx2Y0IDqGxmQjeRdRWM4YZDFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8vFMaWK3L5ENW5xkwKxjoKYmSOsfoG1x5ZrtZEFyKz8=; b=oY9UcJlz2AyKUsHVv17U1ASsSPBVn5OSmGRPM9Xvf0lUcmdhchOrSRTUKR7KH7izNv+Jl1dICF8kwq2opZvmpS7WjTnbqfpKBM1Go+ujYAv9M5Oxu9x5GNwqzplqQ3Mi2ItV3p7Wo93KmFVhcjpKBLNcFtwrI+u04Pl6Ll/S2GA= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB2715.namprd11.prod.outlook.com (2603:10b6:5:be::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 9 Nov 2020 06:16:55 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb%3]) with mapi id 15.20.3541.022; Mon, 9 Nov 2020 06:16:55 +0000 From: "Bob Feng" To: Yunhua Feng , "devel@edk2.groups.io" CC: Liming Gao , "Chen, Christine" Subject: Re: [PATCH v2 1/2] BaseTools: Add image type into generate map file Thread-Topic: [PATCH v2 1/2] BaseTools: Add image type into generate map file Thread-Index: AQHWrm5u9z0kodONCk2E73zeWgGe8am/YoAQ Date: Mon, 9 Nov 2020 06:16:55 +0000 Message-ID: References: <20201030033939.2094-1-fengyunhua@byosoft.com.cn> <20201030033939.2094-2-fengyunhua@byosoft.com.cn> In-Reply-To: <20201030033939.2094-2-fengyunhua@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d28f8f57-851e-471f-76b6-08d884770e9d x-ms-traffictypediagnostic: DM6PR11MB2715: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1265; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jacsqOUP6yNWF9VA6KpM3gzmoPRf3oeSZBz6yQa9/wMXkYxuax1DtGp3T1zvRF2i+ZW+KKFywdhlvQCwZDNcyR5PZtF44OdjhIXPAjAK8OKcpEB/Zt5xotHUxO/RUrAvR6XzGk4865O/4hBKzghwufbLJ4+l2BvqMhy6JNXSOPpuPtdWXjI547wi3StKfZDANQeZc7FX4t3VENvbBNQxn6tKslLX6K3jE1ovJnlko6nj8lhb3ejO1ofw1S6D4kK2K3W9beRORUSusN3Ps9KWauSvrayJTeZ++KkrNwv+3yc/GxJOkkZX6ZPBZN8gxYxLNNDDa9lhr2X3TE4x1AA0E+3NTFwSjL6dUgkM98VivvN5a9i8IDwXvcKnMGC+FvYytKkpvy286AwtAGKswL3Mig== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(8936002)(83380400001)(8676002)(64756008)(66446008)(76116006)(66556008)(26005)(107886003)(4326008)(55016002)(66476007)(6506007)(53546011)(33656002)(9686003)(966005)(7696005)(2906002)(52536014)(478600001)(186003)(71200400001)(54906003)(66946007)(110136005)(5660300002)(86362001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: e6//706BniS4H7rvII1zkJQ82+GiRInGBve9fMoLPLoUpVqRvQAnoewF1Q+n0dOnQzipTHQBBqw8Nm8/B+qep8J7tNl2y4Ux0/+W91IvfVvPwPWT9DJT7TGa/HlJIG54KQy3dq9lQfdp6hNqmz/KKzb3Ab4uISzPjkEHjzZxzmgQ9t/iUd0u2c5tY5A4BWBXqY17aaus5H5hiwkVrfZffdXxdDRdysSXxaRTM69wqPONKvLCjfBmwz7bPSWlVZBiRbTSCCAOBy3QPAPuowP6ZbZvFEx4lg45kJ6ed1qqd6nMQnN9U4grl1+nGOzMKlj+pARFTtNbszLJWCeY+a/wQOSLUwPSNR5p30AqLnYcXDixjHgXjSh705koVvt4pp8w01h12JgHtzRtFyVH1m9+g1VSZI/0JN/EY+qEr69VSrQW4Ey21XuhaTLszBrB4aA3DiKbiDxWbH66tifNG1LYco815dcSzOTDRHHwWeVgJ7gCnvt3pTYgksm2E1k0pYNOBtxr4ovWgMopVX4EhFc3t5P3WkVhVXA+EJTSWjTsI7gqTbCT2OVuWf63nBsbXm7v3VHz1UjpOJgtPj97sfPDAAx/jdrgLozik2CnQfG5+h07rf/dCxZ3BhYgMLyI3jEuc4RHfqCHMOB5Dw6Ln72ZNQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d28f8f57-851e-471f-76b6-08d884770e9d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2020 06:16:55.3160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VajkeON5EeER7h1wgovFMtnLEMVGWRKTBnk4TnY3E3tnpQ4uh5lEDKk1Cf3Bn5qbzKVlX2CkGOILrV8/HVIAAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2715 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Yunhua Feng =20 Sent: Friday, October 30, 2020 11:40 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [PATCH v2 1/2] BaseTools: Add image type into generate map file REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2977 For a source-level BIOS debugger the .map files are quite useful with one m= ajor shortcoming: the debugger cannot know, solely from the .map file, the = format (PE/COFF vs. TE) of the image included in the final BIOS ROM Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source= /C/GenFv/GenFvInternalLib.c index b5ffed93a9..6e296b8ad6 100644 --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c @@ -903,7 +903,12 @@ Returns: fprintf (FvMapFile, "BaseAddress=3D0x%010llx, ", (unsigned long long) = (ImageBaseAddress + Offset)); } =20 - fprintf (FvMapFile, "EntryPoint=3D0x%010llx", (unsigned long long) (Imag= eBaseAddress + AddressOfEntryPoint)); + fprintf (FvMapFile, "EntryPoint=3D0x%010llx, ", (unsigned long long)=20 + (ImageBaseAddress + AddressOfEntryPoint)); if (!pImageContext->IsTeImage= ) { + fprintf (FvMapFile, "Type=3DPE"); + } else { + fprintf (FvMapFile, "Type=3DTE"); + } fprintf (FvMapFile, ")\n"); =20 fprintf (FvMapFile, "(GUID=3D%s", FileGuidName); -- 2.27.0.windows.1