From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
"spbrogan@outlook.com" <spbrogan@outlook.com>,
"shenglei.zhang@intel.com" <shenglei.zhang@intel.com>,
"abner.chang@hpe.com" <abner.chang@hpe.com>
Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>,
'Sean Brogan' <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] CI test on copyright
Date: Mon, 19 Oct 2020 01:24:47 +0000 [thread overview]
Message-ID: <DM6PR11MB40735BBFE002CFF55684E72CC91E0@DM6PR11MB4073.namprd11.prod.outlook.com> (raw)
In-Reply-To: <000601d6a5b3$59da0e00$0d8e2a00$@byosoft.com.cn>
In the ECC, the rule to check Copyright is to see if the Copyright is the first word of a line, and the Copyright should be followed by a (
Liming, for your reference, the code in ECC
## _IsCopyrightLine
# check whether current line is copyright line, the criteria is whether there is case insensitive keyword "Copyright"
# followed by zero or more white space characters followed by a "(" character
#
# @param LineContent: the line need to be checked
# @return: True if current line is copyright line, False else
#
-Bob
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
Sent: Monday, October 19, 2020 9:01 AM
To: devel@edk2.groups.io; spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan' <sean.brogan@microsoft.com>
Subject: 回复: [edk2-devel] CI test on copyright
I will check this issue first.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66349+4905953+8761045@groups.io
> <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> 发送时间: 2020年10月17日 12:46
> 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com;
> abner.chang@hpe.com
> 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> 主题: Re: [edk2-devel] CI test on copyright
>
> ECC stuff was done by Intel. I would defer to them.
>
> Adding shenglei.zhang@intel.com
>
> On 10/15/2020 9:21 AM, Abner Chang wrote:
> > Hi Sean and Bret,
> > I got the CI test error which says the first line in file header
> > section
must
> have the copyright information, however the copyright is there and
> looks
to
> me fine as below,
> > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > [cid:image001.png@01D6A351.31688460]
> >
> >
> > The interesting part is CI seems happy with below format of
> > copyright,
and
> this issue only happens on INF file but not on the *.c and *.h.
> > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> >
> > Any idea on this?
> > Abner
> >
> >
> >
> >
> >
> >
>
>
>
>
next prev parent reply other threads:[~2020-10-19 1:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 16:21 CI test on copyright Abner Chang
2020-10-15 16:24 ` Bret Barkelew
2020-10-15 16:32 ` Abner Chang
2020-10-15 16:34 ` Bret Barkelew
2020-10-16 1:07 ` [edk2-devel] " Abner Chang
2020-10-16 1:15 ` 回复: " gaoliming
2020-10-16 1:19 ` Abner Chang
[not found] ` <163E54449E0DFAB5.31077@groups.io>
2020-10-16 1:25 ` Abner Chang
2020-10-17 4:45 ` Sean
2020-10-19 1:01 ` 回复: " gaoliming
2020-10-19 1:24 ` Bob Feng [this message]
2020-10-19 1:28 ` gaoliming
2020-10-19 2:24 ` Bob Feng
2020-10-19 2:48 ` Abner Chang
2020-10-19 3:01 ` Bob Feng
2020-10-19 3:25 ` Abner Chang
2020-10-19 4:56 ` 回复: " gaoliming
2020-10-19 5:08 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB40735BBFE002CFF55684E72CC91E0@DM6PR11MB4073.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox