From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.9340.1597368014176301576 for ; Thu, 13 Aug 2020 18:20:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=SUyhFuP1; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) IronPort-SDR: 1/yevKJe7xMuA6piet2KzMygdKZKP55ZN9OAFQBgzGnHOEQ+LLxHetTTSvD+GYOfFOJv8oF8+f YO39/5hyG1lQ== X-IronPort-AV: E=McAfee;i="6000,8403,9712"; a="134402175" X-IronPort-AV: E=Sophos;i="5.76,310,1592895600"; d="scan'208";a="134402175" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2020 18:20:12 -0700 IronPort-SDR: MvcnC+/qAOfgorowCLG8JEears0lxjFvwYok8eHzBUbIWJgV/6olZ2ydZMXfUC9qnk8dNsYcNH lzJwBRi+EMMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,310,1592895600"; d="scan'208";a="496041399" Received: from orsmsx601-2.jf.intel.com (HELO ORSMSX601.amr.corp.intel.com) ([10.22.229.81]) by fmsmga005.fm.intel.com with ESMTP; 13 Aug 2020 18:20:11 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 13 Aug 2020 18:20:11 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 13 Aug 2020 18:20:11 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Aug 2020 18:20:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WS2Jk13bwPDHEw6ILG32kQXZWSnRqStkaUqF1kSstOLgTcVZULqJfLfBKKVhr9B4MzGnKqIESqBjo6itrUR5z9aNrHy/nbSlXoCWYc4tpFMSBUfj0uAgLEZHG5NGezd152w7/TKLf+Uum6ZfPVMLfwYit0iFKNailJ19C3WuHMY8i3UYDb9yGY3ht8Lrw+nik5A7dsZ8u6YypGy8c4Miwj/Oy8WZlkMk9gSSBthSWJG/w4Z9PqsnpjAKeZXC53cvTPIsGoZXlYfHsl79YdLhfDwLgxK3RNHRUiJVJQxUGzJM+xvkIjAunMezb6rS3Vjo7G7HhIjuqW1x5bG621+9VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TOsd1ambf7Mmx+ifM3JnTvVkDXUBlVTHZSnj/t4SZXc=; b=JQFWaTWfb1IB/3bak7RXGGfaSerhFBCBb5lIlo+X0MIYrBE/jQq4S/r58mj3wBRR+4MqKdQd8JZJV/9Ji91tCo1vRr940dmJebGTVgYVqOSMxTm3Fd/DfFM8wfpv04RqfO4LwuETppS5YiC1XSjskY692wroTJOaMCEzjXZN6ZodY/bqSd+S6SWWXq3ecg1FFDbRaVaHwTCCY+gwiTvSUNCERfo7cEpQ89c3CCZffMw0QWYYmo2XuIcyODfkcOolWsZK2Ym578JhDdYAupZU04Ma5GZRYehyZDEl5llUHxFANfIuA86SLj/fHTF/NJBXd5q0rswvlrwKwmVJeYv5Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TOsd1ambf7Mmx+ifM3JnTvVkDXUBlVTHZSnj/t4SZXc=; b=SUyhFuP18sQXuk5+Oun4Sb8Kun/mzslUnsPvl22iEilejDRW2Xz5bKmS766bFJxapN3PBPAxp6smGAsOWAiUB8cPVwspg472C+mRcxEvT3/pXaQOJg2JWtGI/8l9z0uSVA8CUNRZUanagyvkZStPKEjCirmEV/3vNZaCwZGoYnM= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB3145.namprd11.prod.outlook.com (2603:10b6:5:6e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.22; Fri, 14 Aug 2020 01:20:10 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::88bc:d834:df24:ea90]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::88bc:d834:df24:ea90%6]) with mapi id 15.20.3283.020; Fri, 14 Aug 2020 01:20:10 +0000 From: "Bob Feng" To: Cole Robinson , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH 2/2] BaseTools: Work around array.array.tostring() removal in python 3.9 Thread-Topic: [PATCH 2/2] BaseTools: Work around array.array.tostring() removal in python 3.9 Thread-Index: AQHWcAVh0k1BA4v0NUaGpW2R7zZTjqk20fPw Date: Fri, 14 Aug 2020 01:20:10 +0000 Message-ID: References: <95d3490d62f9d320e61efa10cba7424a6f626f66.1597166808.git.crobinso@redhat.com> In-Reply-To: <95d3490d62f9d320e61efa10cba7424a6f626f66.1597166808.git.crobinso@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d22d708-5352-49b3-2fd1-08d83ff03004 x-ms-traffictypediagnostic: DM6PR11MB3145: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1332; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2kzjVJkPT2dwTzy8sVXdqMePORYy0j81QfhIGzNZtM0D+TJ/ASimsmX2q5QS2e9PmMA2JAVSDMK5UKAOrojwi81FfltgORxlWxFQ3O43a9cOZsnN02A6qL2fuV3z7iR2b32p+1mnoyfE8cqyAGv+E8jJ14E5eY2ML41Lr9FChEQbQxxrblZtZ0kMsTBovrb0yeAEvcQyzy7voQTPoRjJFHSGsbe+sUq8730VkHtd8jEYSkI+dxdgigKygT34zb6alRlhjs8XSRBXYLMwiyKEc386WVkXhXcneEtkkwIqyrkpnsO0HxyrFtmWGSWaOxvgMyrCnG6uNgVrwrV4F6Jh6w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(39860400002)(366004)(376002)(346002)(86362001)(4326008)(26005)(76116006)(478600001)(2906002)(9686003)(316002)(71200400001)(66946007)(66446008)(7696005)(64756008)(66556008)(66476007)(8936002)(110136005)(53546011)(8676002)(83380400001)(55016002)(5660300002)(107886003)(6506007)(52536014)(186003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 9OUn2H0KfA297ZIDdSu8iom1KpDyDrCGFjpOS+stts2keVDGlRuMWn6MKqEi/AeISdVochj8/c/fCboD+02FNV48IFrgL53uZ65L6zKNeggfzI2nNN5X4FfEpiULIy22diO2mlpQFT9ZHu6L7MJHqPpjQttQKFtoCg8N97eMbkvHoz9v10JIQQPVO9OwUUY8zCeAMCQiK8QNS0RdXm9MoOLD68Uq818lGAnsD8WvGDkrMEW8csUM/cyynFt1eyQ1F29JvS3zSmUDiIBfVbvy0SJA1TTB8zUQ7MeXDX4MmdwWfuQssdauwfztV7jSOjrnCp6dEl9qWu59LI3GC5h7AXxATMAQwNWgotwqh9wy0xAuEKWKhD4B+JUXmnu9WdFlX6CzwfQfF/3ylDIPLaKn7MLvSdiUJYlX86gV6NxAfnztorQOA/F3btuB/qHIPI9NgfxgQr/oEcsHnGRXGgEd40gvE+ESWkYaP1x09SthM9Sm69n9GHibr3mia9zIKjLj2flb5kA+bMdBxnBNEGNJm7lgS3Z6A6rCw2cjcWVPrWH+RjXVSPQnyDi7UVfa31sHEPexp3HoLuW+NFbmhpH94HBrErt8rkcth0o9Ho8yfskUnFsARaz6dFhQ+AMdIF7kzb4mPPU2rGJPZmwmgLf+og== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d22d708-5352-49b3-2fd1-08d83ff03004 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2020 01:20:10.1447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d2u/7H0pknF3gLstpVga/oc2lOOoAwBXLZTdFtpEfxV6q5q0W4Yh7xn0AUhMPVTP2w29DN1L7FwFq/DQV8fF1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3145 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Cole Robinson =20 Sent: Wednesday, August 12, 2020 1:28 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ;= Cole Robinson Subject: [PATCH 2/2] BaseTools: Work around array.array.tostring() removal = in python 3.9 In python3, array.array.tostring() was a compat alias for tobytes(). tostring() was removed in python 3.9. Convert this to use tolist() which should be valid for all python versions. This fixes this build error on python3.9: (Python 3.9.0b5 on linux) Traceback (most recent call last): File "/root/edk2/edk2-edk2-stable202002/BaseTools/BinWrappers/PosixLike/.= ./../Source/Python/Trim/Trim.py", line 593, in Main GenerateVfrBinSec(CommandOptions.ModuleName, CommandOptions.DebugDir, C= ommandOptions.OutputFile) File "/root/edk2/edk2-edk2-stable202002/BaseTools/BinWrappers/PosixLike/.= ./../Source/Python/Trim/Trim.py", line 449, in GenerateVfrBinSec VfrUniOffsetList =3D GetVariableOffset(MapFileName, EfiFileName, VfrNam= eList) File "/root/edk2/edk2-edk2-stable202002/BaseTools/Source/Python/Common/Mi= sc.py", line 88, in GetVariableOffset return _parseForGCC(lines, efifilepath, varnames) File "/root/edk2/edk2-edk2-stable202002/BaseTools/Source/Python/Common/Mi= sc.py", line 151, in _parseForGCC efisecs =3D PeImageClass(efifilepath).SectionHeaderList File "/root/edk2/edk2-edk2-stable202002/BaseTools/Source/Python/Common/Mi= sc.py", line 1638, in __init__ if ByteArray.tostring() !=3D b'PE\0\0': AttributeError: 'array.array' object has no attribute 'tostring' Signed-off-by: Cole Robinson --- BaseTools/Source/Python/Common/Misc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Common/Misc.py b/BaseTools/Source/Pyth= on/Common/Misc.py index ad55671080..4be7957138 100755 --- a/BaseTools/Source/Python/Common/Misc.py +++ b/BaseTools/Source/Python/Common/Misc.py @@ -1635,7 +1635,7 @@ class PeImageClass(): ByteArray =3D array.array('B') ByteArray.fromfile(PeObject= , 4) # PE signature should be 'PE\0\0'- if ByteArray.tostrin= g() !=3D b'PE\0\0':+ if ByteArray.tolist() !=3D [ord('P'), ord('E'),= 0, 0]: self.ErrorInfo =3D self.FileName + ' has no valid PE si= gnature PE00' return --=20 2.26.2