public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Yunhua Feng <fengyunhua@byosoft.com.cn>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [Patch] Basetools: Fixed FMMT Linux build break issue
Date: Tue, 13 Oct 2020 09:05:52 +0000	[thread overview]
Message-ID: <DM6PR11MB4073698CB5FF016B54049576C9040@DM6PR11MB4073.namprd11.prod.outlook.com> (raw)
In-Reply-To: <93808d6e-10a3-0cac-b4f3-e2ae6155e35c@redhat.com>

Sorry for confusion. I'll update the patch title, it should have [edk2-staging] prefix.

Thanks,
Bob

-----Original Message-----
From: Philippe Mathieu-Daudé <philmd@redhat.com> 
Sent: Tuesday, October 13, 2020 4:48 PM
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io
Cc: Yunhua Feng <fengyunhua@byosoft.com.cn>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [Patch] Basetools: Fixed FMMT Linux build break issue

On 10/13/20 10:32 AM, Feng, Bob C wrote:
> Hi Phil,
> 
> Since the FMMT tool is in the edk2-staging repo, branch FceFmmt, the 950333853b5fe2b73a7b5148501458cc97a01481 is in there.

Well this is confusing. Some contributors use the staging/ prefix in their patch subject.

Maybe the contribution guideline could be updated.

> 
> Thanks,
> Bob
> 
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Tuesday, October 13, 2020 4:02 PM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
> Cc: Yunhua Feng <fengyunhua@byosoft.com.cn>; Liming Gao 
> <gaoliming@byosoft.com.cn>
> Subject: Re: [edk2-devel] [Patch] Basetools: Fixed FMMT Linux build 
> break issue
> 
> On 10/13/20 9:23 AM, Bob Feng wrote:
>> Fixed the FMMT Linux build issue which was introduced by the commit
>> 950333853b5fe2b73a7b5148501458cc97a01481
> 
> fatal: bad object 950333853b5fe2b73a7b5148501458cc97a01481
> 
>>
>> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>> Cc: Yunhua Feng <fengyunhua@byosoft.com.cn>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> ---
>>    .../Source/C/FMMT/FirmwareModuleManagement.c      | 15 ++++-----------
>>    1 file changed, 4 insertions(+), 11 deletions(-)
> 


      reply	other threads:[~2020-10-13  9:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  7:23 [Patch] Basetools: Fixed FMMT Linux build break issue Bob Feng
2020-10-13  8:02 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-10-13  8:32   ` Bob Feng
2020-10-13  8:48     ` Philippe Mathieu-Daudé
2020-10-13  9:05       ` Bob Feng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4073698CB5FF016B54049576C9040@DM6PR11MB4073.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox