From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.15372.1601364581829270205 for ; Tue, 29 Sep 2020 00:29:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LKjVfmCe; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) IronPort-SDR: 5acqHncCbpPGuCJjmpto40VNUBnW+nyLBiUZFx3m/FkVPZJgVF9eahIKwadPh3tIYTMoT0LxlJ 2hwHDkqHLFKA== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="142155117" X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="142155117" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 00:29:38 -0700 IronPort-SDR: UvN42jSheaQzqM/uK/HNejiyRBKp1kk4wY40rxpTJdFbt7bcCV2kfdjWFFbL1qXme/PSQ5IuNa ZR+xlfBYRmbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="324577009" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 29 Sep 2020 00:29:38 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 29 Sep 2020 00:29:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 29 Sep 2020 00:29:37 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 29 Sep 2020 00:29:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QxgC3oRmhSvlX0ewObu2F387K3oWhqQnms4iLMiby+N6JcC8/JDmhmtZuqfRnkVbtgBxqJnW7kdKAiKA2ssCwSujb7z9r3g9sqSzIT4Gl7VdzUEQJ72Vk/e1THL97Ke9NdsdngnrLQJ+wo21mgCmD3jVIYCjgZ0Bwj1bmQZ1MrqdidwsMI2cuFVZGpAFQWxZu4MFZnz+85hoE0qUuWpHnpnzJRen9E3jk9INcYFbaGmQX+/7/12O4BcbxPv2uck5336YEc0pAyzrlFDYgBS73TAz5LjfM2uuyv8BnmdZdNwhKn7Zfk14RHcSCXsV5Mgw4uQfZn+SIDIyM1gguxUlQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGSaNZnw0YwUODmzmL2WSJx1Y8rL4mpqZjlE7/xkiiE=; b=X6TP3m1rwJftCM0YL/0NkH7fTXYdPwgEHrwQUQey8g1m4UOoRcz5mDQCwsuG7XWw78T+/Ye09Dg2L9g53TY3qrxkTlrR1I0qcfGG3i13hUUnFp1HUGvshgAsPakf29n5Z9O0wPUUzP8jeHDU0ZwQ0E/acseerYEdIhrsJZQmnC6wQSQRBPlP6fFZ9nUqPmLJL1IQjq0uptIpV6cBIPBgvYjD4ZNzf8PlMI0jvmBmUBlbFz5up+hXA9rAuq0QSI6/j5m01lTx+5pVja1PM1+U5OMaOlxS9FRc9/09WcA0fjNpHG0/R7U/lkO/M6N24dSlKfPfn8wTTzmhSO08y9DVXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGSaNZnw0YwUODmzmL2WSJx1Y8rL4mpqZjlE7/xkiiE=; b=LKjVfmCe5d9HlDZbmw/DLrb8x89yPxf8O2NRvfkopOlw2//VEC0rrAk5w+1j9GmGks9B9qKKvN3bm3dSokxxZIMZZ4+H4PdPxvOj4J8y0GMn2DkbtIHjess1LAlS4tnmD0OO6mbjtk+c31THS7jlHmewlUJdhFBu3DVpj9RndeE= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM5PR11MB1963.namprd11.prod.outlook.com (2603:10b6:3:10e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Tue, 29 Sep 2020 07:29:34 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::88bc:d834:df24:ea90]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::88bc:d834:df24:ea90%6]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 07:29:34 +0000 From: "Bob Feng" To: Liming Gao , "devel@edk2.groups.io" CC: "Chen, Christine" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h Thread-Topic: [edk2-devel] [PATCH v2 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h Thread-Index: AQHWkxB97jsA6GJw1kasyYmUZybical/Plow Date: Tue, 29 Sep 2020 07:29:34 +0000 Message-ID: References: <20200925074918.221-1-gaoliming@byosoft.com.cn> In-Reply-To: <20200925074918.221-1-gaoliming@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23ec1de2-546d-4b85-bf65-08d864496a03 x-ms-traffictypediagnostic: DM5PR11MB1963: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:612; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7W8d17oDyORd8NltEtCYRHaMuPaEobp8kyn62UzoU2vunn6Wikn1rzn3jm2jO5qgu4BXsJfTBvN+yPscUw/e6bIrVD8SZEVRy7CLDl0w8EEoYD+XnDIjUUPLy0EpTy+joN+UgVZRONounVUqI/DDZCmNauFdnLji7qRwv9SC5q9fRZXJe0b+za57HNJ6vVyXYfv0Yvo9MvPXxl8Ty40oXaYPqDVyVD37q402JqM53JdAs6t/J3EmLEWXynL9btyYclkJW/GY7jWXuSnFkYW/6Bs3LUg8dsUZU347QQwKxjnq8YrCtmmglJQ7SMDC9UanlO7RS5jX/xEjna+QjvCjy+hH9wp6KeTRQVuiIPgUA37H8Zv6fdp/Ux2oZ6NnxkVnGOvfhzz/EgNQFj9XTidUPjRd5Xq8jJmxXXG+kI7k53RKWbWBim2KoisJgnnVE2AP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(346002)(376002)(396003)(39860400002)(54906003)(110136005)(186003)(316002)(8936002)(6506007)(52536014)(478600001)(53546011)(7696005)(66946007)(26005)(5660300002)(76116006)(4326008)(107886003)(55016002)(966005)(9686003)(8676002)(33656002)(2906002)(83380400001)(86362001)(66476007)(66556008)(64756008)(66446008)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: NdfOSy0vaXQ/bGidbT6BYBtWg9hT0fPDW7HKx24csWUPr8hTIWyPkCmYe52Di5EpyzHJCJz7SU+7IhCJeycBC/pY0RJcFgJcLB/7krnetNHpr7pzD7gdO3nPYF0dkKfy+Mf6pZyYudaTudopQg5fejsQPUPC9k6pLs0qa4MSrze0Np3mdlrsyzctE20eokN5u93VQvrysgFKm4cPMlhdx73DHBpYWgURIIrSMUhvU+LzS6jOkFsg7uH5fyb4M5NMy936MvMjdN6bFZwEtYvO0u3liDNNhaT6WYxkU+kaj9h7Y+nR+GMjAumyskoplTJizQhZbhrPyCBxrxjF7BSTH8tstrvl63wDmmgUQrzvr2AQRZ7s4itjp9R+a2RVmHuZF+Ar4Ud3FhkstI98VGQE1hDgiSJpR/W+zAtrRq2ri1fDdk23rmoyAKpnXP7jH9fgWV9Eq0NZPV6wm8Mfzg6sZYY0eb0Nq/wc+EhMQRlICs9JGMzd52TwiymmQDKvz/tJl17Z/AXMJx4zQL6TyJ4IQT2KEnWkDtYutBOit4NtE3G9XIUrYxuE6jQlnbmMwjqL4a69XZJ8dGeqe8VwWFBvQPMW29B48ZLQ7rOH1TtMsCXDO0OdSYMKCk6jycFCx3f/uVaQYH1JqWw4soPP81jljQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23ec1de2-546d-4b85-bf65-08d864496a03 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 07:29:34.5896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BAUhCLiKSSTHXmYBo3LPLDXEUbywP2u4jrCu8d9ObJPgq2LO3uhpEHh//lyTl1hBHE2Ofyd/Wsb7pHpbXpS/+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1963 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Liming Gao =20 Sent: Friday, September 25, 2020 3:49 PM To: devel@edk2.groups.io Cc: gaoliming ; Feng, Bob C ; Chen, Christine ; Kinney, Michael D Subject: [edk2-devel] [PATCH v2 1/1] BaseTools: Copy PACKED definition fro= m MdePkg Base.h From: gaoliming BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2938 MdePkg Acpi10.h definition depends on PACKED. When structure PCD refers to Acpi10.h, build will fail, because PACKED def= inition is missing in BaseTools BaseTypes.h. C source tools include BaseTools BaseTypes.h. They don't include MdePkg Ba= se.h.=20 When C source tools include MdePkg Acpi10.h, they also need PACKED definit= ion.=20 So, add PACKED definition into BaseTools BaseTypes.h. Cc: Bob Feng Cc: Yuwei Chen Cc: Michael Kinney Signed-off-by: Liming Gao --- V2: update the commit message. BaseTools/Source/C/Include/Common/BaseTypes.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/BaseTools/Source/C/Include/Common/BaseTypes.h b/BaseTools/Sou= rce/C/Include/Common/BaseTypes.h index 31d0662085a8..150980b4c0bf 100644 --- a/BaseTools/Source/C/Include/Common/BaseTypes.h +++ b/BaseTools/Source/C/Include/Common/BaseTypes.h @@ -57,6 +57,16 @@ #define NULL ((VOID *) 0) #endif =20 +#ifdef __CC_ARM + // + // Older RVCT ARM compilers don't fully support #pragma pack and=20 +require __packed + // as a prefix for the structure. + // + #define PACKED __packed +#else + #define PACKED +#endif + // // Support for variable length argument lists using the ANSI standard. // -- 2.27.0.windows.1 GitPatchExtractor 1.1