From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.6226.1618821256300544092 for ; Mon, 19 Apr 2021 01:34:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=OBlZjtBl; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: bob.c.feng@intel.com) IronPort-SDR: wK0/kR8yn9syDar8Kbr6FqN2ChMW0T1CMKqGKhhzgh+8Rvld2LdeDiUFFf6F3yZotKCenew4zz NGa7hAT2a3TA== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="280613531" X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="280613531" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 01:34:15 -0700 IronPort-SDR: uk9pucBJA5WwQNSG73O3SL73wb9d5aWLU0A59O5Yl9AWV/m1epNEePsXlVNlYr3t1Tw2lcSDc2 +rII/amQqktw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="419918400" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 19 Apr 2021 01:34:15 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 01:34:15 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 01:34:15 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 19 Apr 2021 01:34:15 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 19 Apr 2021 01:34:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BXCqGoFQlRuWFpJ5D/VPvux69KUyi/NVaf/YDPTHDsCrWicUIaNvrmN/4ILh8JH8M+Is7VB7caF7YqoMwdJDRVGvcg6pTvYhCjWQ9T87mR58HfwSQUZA6qa9PsUDZBAnuaFRFEuAZfnK7Mm7iW7VCvrivOrvEaS5RO0jr0K3WfnDY9nlBSFxp8jYnxLrfoGGTZhQSfIwuSJFC4hupktrGRrJ9HvPwJNMh4DOqLWblVzZZZHZfrdZHfcPSNIg/XHt69qdAjVTYFEc17AbkGlrp6eRVfhDkvvE1v7mra2M6MWgKHzWM0r6hK/L80gRdtBDWNUfEmG3RRSz/ER+FKv52w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fb3eWS41xQd1gf59bl0sgvgR5mJcrwUf4CogFIUD1EM=; b=Bl3BDFh7iPviPS19kMGotyqgu5gUqsPqOlJICD5Tw010VamZoZT/90GbxtjmbigFB/urtt0xZXipmvmkR7E8aLKCPlpZ+z+Uxr4e9q13DD/vwyDJUlA5/hxkUovGqmMXYaI+HBLmzLhnk/um8NYNu2F8bRI6LlPQoc8TICDSHbzcgWAlDw0pwsQgE1z9WJ1N3ZOUB36PEGzVId73J4+2atXKasj4thz+PLfnr9moVlM2oPmXkCZarQqKnfKL77PVyjIDqXfp5vZw+YG4gMaCCX2vnv9Hkk0K5eYe7mTn1s943FFAJvh8LjN0MqGqluxUz1P85GH1XZFNyOzUWa5RHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fb3eWS41xQd1gf59bl0sgvgR5mJcrwUf4CogFIUD1EM=; b=OBlZjtBlnkBQlQV/kdn0uKWi6dfbxr2ON9n5i2tEKgjP2w0O9UuU9e6VoQlmnna+qaks6aSBEm4uPYZ7GmVJLOFPWLkKedj8aSZBnO2VXF5cTsqlzlcoN+4H2Kgpbz+OP+h+vM10Mgzs1p6IC29jU9Yw4AotqC0lVKNrtuIpZg4= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM5PR11MB1994.namprd11.prod.outlook.com (2603:10b6:3:e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.21; Mon, 19 Apr 2021 08:34:14 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18%3]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 08:34:13 +0000 From: "Bob Feng" To: "Shi, Steven" , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" Subject: Re: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Topic: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Index: AQHXM4RRbPrDgRbISkKYtP8/09FtlKq7hg7w Date: Mon, 19 Apr 2021 08:34:13 +0000 Message-ID: References: <20210417122133.1879-1-steven.shi@intel.com> In-Reply-To: <20210417122133.1879-1-steven.shi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 838327b8-b8bf-4b0c-138e-08d9030de998 x-ms-traffictypediagnostic: DM5PR11MB1994: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K/Fr8Lok+3gdmVK/AMsMqvfh0JVBzHoz3L9KUTRj0jHniONnwSwEFXUde4AiEywjBwcqeDi76brykzs+xwfxT9FUdcW21mYUkoXgDj9NkeVR6zjxXHGJ59lvGFhU+2kUC1cNXCdYOzTQXXfKZoBYeP2eLxjqL5yiKYG35fdALoJgsMvx5PDhEthvjpaNV3M3uz4Oa8pUlunz4Ls1kpL/Y65Z31NSDUGe5QUixNAEbDCUAfGjn93LJG3laESigWQcr2Xo7UsyD8FpJVhpr62TqMBhXt1UElKgjzAK9452cIBvXB6bt62F6V2WOwv4FIM70iufEVDSRYI+y1M45usxaKRXfOqMu1wRpqy/0Ll1aT133W+enZ0d4qkmAEKVinkobp0Qlc5u4BGmkiQGsnCR+wOVQt11poekhogNGaB8vvEnu2hLuP7LmNdePhEk7eJoP+p6xa8abgkqVgVaUE7ONw1ygm2VLTZ9M7eE8l/+XvK9K9h8trwNvSNE5yTqvMLlZi0tCI8gl6OUvFZQYuzLo7H8xomuQU9XifbjYfFEsViSfollWc3zILP37N5LcC+tVXv4SOGL+sFD+0KNx8AZ1B6LlCkHrx6jN8JPdDkJwtUtRQRnUHLm8tKMY0JjgypKOGVlAR7VdgZ+VUoDJEtoTmkshqqm6aZcI1Ud7AuVSlXq4FlzIoLvnTD/TBYplbCdTHXEctzOEacgTES3wudwX4FrfzFGJiyFoSDcnPaluVU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(376002)(366004)(136003)(396003)(186003)(52536014)(7696005)(33656002)(966005)(2906002)(66446008)(86362001)(71200400001)(8936002)(6506007)(26005)(478600001)(76116006)(122000001)(53546011)(8676002)(55016002)(83380400001)(316002)(66946007)(64756008)(5660300002)(4326008)(66556008)(66476007)(110136005)(9686003)(38100700002)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1mhCCh+LIWY7P8SQFMQuzjIA2Sj48zXZpLFXdjdfB8FCiqZkU0cX5y0nrWWD?= =?us-ascii?Q?h0PwALluM/bY0jHk/ijO1CcXqyNo7wtdXRdCIqY+y57FL993Ub/JWKZ3DU9u?= =?us-ascii?Q?W6kSOW4JpD1IG1tWqP6qH9z/6QbTAQhxsSWMi70Kz+jO0fLIat4UuNnDDVI3?= =?us-ascii?Q?epCVbY6+VISBZpv/eLzXvHDtAn5JEJTeZQAqfja7QzO9jVUJpa9hyjc/M2Xe?= =?us-ascii?Q?KUQJtqoS5fBNj3xz09uZnMtC9izOC9o0FB1Q+8ESJa3na4XAQEO9uF4RHa40?= =?us-ascii?Q?ZuYbhjLUhQ+hm9Nsw3aJGoNfPs4XuJ3tZWknjazVlBB6DoAvVo8uAdBQ6bQQ?= =?us-ascii?Q?pamzrvqpEVz0k5RxRoz79aeMa2fuEUTSqBm88hegV+qpa0q3Vmkhv3Bvjp+r?= =?us-ascii?Q?ghr3ORZ8CWfojyKHHpcaTeBZhx8jg8Dcot5DCZIUadZZuLUV3zYMZ8TUzbDV?= =?us-ascii?Q?tLmZN8DBkmIy6ctMX7WsmUz0fCQUYx53/br8K8EClRAUikM6Ibo3Xa11xK3N?= =?us-ascii?Q?ZB9HQvLIlHfkyFCwpyecXQ1CnNN3nD9cHol9taLGvKK8hc6zi6ICafUQ0e1Q?= =?us-ascii?Q?/0Ykl89NMwXwB8gOQ2pDVkqvu4/dDL4jLm2jpfSkzxKDEkmNb3vcnsBOP8HA?= =?us-ascii?Q?m+FWB3DiY62fMf98ztqikuRKlDpyfQIHFmhohQWWDRq8eneuT6v63AY6r8Pi?= =?us-ascii?Q?gWmPTZgxAXb7CcZxiKA6uJQpwu/RMXPwThbrmlXfQHCv6yQTvg3MGBXcwott?= =?us-ascii?Q?5a7t4bN0Cw5OLnnP36k5VL4XDDl9V/THU7NnrYHoRWXrOcjQZ9uC1E23V0UQ?= =?us-ascii?Q?66joPONcklInYwc3yo8ZRT71G6azyJPHVtdvomk52Cqi44wc0pFCkaatBKrG?= =?us-ascii?Q?U/hmJSOujG8kevQB7uJ0ANLpOv7IRfnc4y0ITVaRg7b9YHfWIlwI5n+A0j4c?= =?us-ascii?Q?laos99wB1j+djS52z298GAf82sTMd+YlmM8tM0W/ez9NvbbrOPaX8pmQoU8o?= =?us-ascii?Q?xmqU7KKmlF4B2vCN6yxY38mzIrrvTfF9AWw8T8uCpxma5VbnwErzdG7dKRLF?= =?us-ascii?Q?ZxFLOExSPKELWVhC05/JqTNhfFazns65sfpKy0ZjfWrqI+9xiOzxz7ULEMvH?= =?us-ascii?Q?6AlN1LpCds3mxc/2vEvsz020XhYbxu2gvnUL+1Vm9NUpXLQ9gTD3jQoYIAhS?= =?us-ascii?Q?0y48A6wvujWAB5MI79GbO6SRKhZxmyaufcZogWvweH0gGBz25N0z4qU6ar1K?= =?us-ascii?Q?vFOqgZdFewR8upwC4VfBB474gSHTa0iGNCCz7Yu8tl/QGZTtCNg/d3NUb2r4?= =?us-ascii?Q?HKY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 838327b8-b8bf-4b0c-138e-08d9030de998 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 08:34:13.7192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: defitvykoZUD7yhylZ4K8RdCw8o0OOpiShFOInDBTMKohj1p0EWAtikR4VvWaOTQ0KhJwmqVIknnJrWONiMOvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1994 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Steven, Would you do a little change as @set CLANG_BIN=3D"c:\Program Files\LLVM\bin\" I think the double quote should be only round the path. Thanks, Bob -----Original Message----- From: Shi, Steven =20 Sent: Saturday, April 17, 2021 8:22 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; gaoliming@byosoft.com.cn; Shi, Stev= en Subject: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path stri= ng REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3341 Current CLANG_BIN env variable is set without double quote around the LLVM = default installation path string in windows, which causes some CI build ser= vice cannot find the LLVM path in windows. This patch enhance it to add double quote around it. Signed-off-by: Steven Shi Cc: Bob Feng Cc: Liming Gao --- edksetup.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edksetup.bat b/edksetup.bat index 7b9377aaa5c2..7ad137bb3e9b 1= 00755 --- a/edksetup.bat +++ b/edksetup.bat @@ -120,7 +120,7 @@ if not defined CLANG_BIN ( @echo. @echo !!! WARNING !!! CLANG_BIN environment variable is not= set @if exist "C:\Program Files\LLVM\bin\clang.exe" (- @set CLA= NG_BIN=3DC:\Program Files\LLVM\bin\+ @set "CLANG_BIN=3DC:\Program Fi= les\LLVM\bin\" @echo Found LLVM, setting CLANG_BIN environment va= riable to C:\Program Files\LLVM\bin\ ) )--=20 2.28.0.windows.1