From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.8959.1622869633463278273 for ; Fri, 04 Jun 2021 22:07:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=GmHOcZEe; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: bob.c.feng@intel.com) IronPort-SDR: 6jQwcMqSdZnGp8f71jpVVcU/sYfhY+wbc3n5DUO2g6gwoDfHBNRRBFrg0YqMwyne9hCUPeW8Rt kUFzrnA1kxNg== X-IronPort-AV: E=McAfee;i="6200,9189,10005"; a="204223969" X-IronPort-AV: E=Sophos;i="5.83,250,1616482800"; d="scan'208";a="204223969" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 22:07:12 -0700 IronPort-SDR: HN04zLqRojrMqy+jmp0rt+PXzPIImulPs/JbjylqK/3GF5bQjrFoQwtnCPlwezcpEhzRr2rmvl Xi/6hVdHClRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,250,1616482800"; d="scan'208";a="448500576" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 04 Jun 2021 22:07:11 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 4 Jun 2021 22:07:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 4 Jun 2021 22:07:11 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 4 Jun 2021 22:06:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L87h72SSrU+Xc4nHHZhrwbGChAgAnJ2tPMbi5zHZEcVDHKY4tzzpZXXNK+aDZrCsOvtL+LvluYajL0rL5YietkFvDVZVof/xrbavuiFbGKftQiB97Yy3czjOJbQn5vC5amRNnLdRGUQUT6lqr9xfftYAhkWea0sw2oKmGThpEuQ2uCmzK7Alsj92+x0cZoUkMIHwXIZkqnGTXwi2i3LcDHQIkbtgIIbKaSaQxqBkgs0OmDd6g3+ov5lbtqAOjbhH8qtTXGCMAVE4MhMgTTp7PCGFlGAYIdlL5PWlRmIQERAxGdKdFksKnG/vXt552CCbPoJPfEakYdpOthwW7SL1fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ChgTghlaMAaSNTG7oXc95ZCSlb+C863kur9v2qZM3+I=; b=S50jHDEtB4QbGj+lGJLbiG0KWx3bOq/I7ofrdFjLMpS4juouU3Lk9+rO8t8us442R/5i2G1eNP4CFWW+cZf75dY3urJGZccusVaV06zm/fKjzpaWGpkaCFoxm70wp5q4sUpCeP0mS+8XwfmxwcM6nsQg2HYQnlOEYuS6G3eCDKWKlH1N0NDOkN84tnW5kGQq46G/WEILBUNujCQNr4ucVjOJZmWhbSlVeo0zbyUwU0j3kuvMFdF7zAWVLePXYNkOwk4BurNYeDkYJnTG6NKeEe/n9GrF4Jk3qxW7U+n6lweui4HL3aRvWZdbCngh5pP/k23SYD48YiEUzCJxPoWPiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ChgTghlaMAaSNTG7oXc95ZCSlb+C863kur9v2qZM3+I=; b=GmHOcZEeVPtf6G7q5iaSqo/O9X5RCXEax24vPzTuxvCj+KaqI+z1ZzExtjn/GVrRCBiN0RVPIuwH0KyKjfQyQDALgPcODKSCBCdBJX2WhhZmwgaHHxc07UknHfd2FzrQA6ZO8w3zNh7CgTdbHuPokxQTtPgNNN5FnSs/oqlUMIw= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM5PR11MB1242.namprd11.prod.outlook.com (2603:10b6:3:14::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.20; Sat, 5 Jun 2021 05:05:23 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18%3]) with mapi id 15.20.4173.030; Sat, 5 Jun 2021 05:05:23 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "gaoliming@byosoft.com.cn" CC: "Ni, Ray" , Leif Lindholm Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to convert the image to ACPI data Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to convert the image to ACPI data Thread-Index: AQHXWajTma+w2GfzqUSR7lKLkyDk6asE3Kjw Date: Sat, 5 Jun 2021 05:05:22 +0000 Message-ID: References: <20210605011854.1938-1-gaoliming@byosoft.com.cn> In-Reply-To: <20210605011854.1938-1-gaoliming@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.26] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ec47520a-111a-45ad-4183-08d927df8616 x-ms-traffictypediagnostic: DM5PR11MB1242: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SvnmqjXy87e+xX8KPaN3vWfPXJR6koneTdJVEf5YW+7Z4L8vNbZgzcWGtvBaP1W5c9I1H4+Zpzu8NQ7ezuCm5OLKk8SqQlbum6y1GijUoU8/ZdUlHZbE3hIp+bwW2kfhEt0pk2gXqamxWVcCBfmCORudqEfYxLiBO7Un2SYIAi98o4p4dTRwwpIiWG3+Q5AIchSo3dEhYV9cA9dzACeKdEi6G6hdKFH2rvpkAyI6YdA4K6w2UX+8JFXiEYI5DWA0yH/DCC11DMOHHqSzjbPqvI0RS50kArfFA3ashFy5pUT5jKMorraxKBxrssj0/m72QKeGJHAMadQN3WySFJkoGTyQPsZK4oGpNV3iHMqYXHbovBPetbHhMq/vxzP6/Wa3FVjEd/D0kyFi6EodjS22jBCPf8Paa25EweuJVJCEyGVgj+BC4LiMUFiQejPEErvgI9U/bHA8lmVetMm639b1yTZ8skMazTKHgt5GhSuoF7vWwquu6kVLaDMYd4iEAsXkMneOChg2DSZXZnYxVXX706PWarcnGWnjBr04s8qIiuEDJXgISGCM4x/4IMtaijvzjsPnQKqb3Uy2VKFIZsapCp5KQvqxUU86KMC/yIHkDBBcEmpOklCGjEnNyd7k020NMGpWPSbxTF2dMpKLJ0VFESmQgsimq8xu+aUpBOmfccxF3p/vqY/NURWdBTwTQIUbCibKUwxtuoTXPpUsTzrDaqHqQ5SmBdGgS6VGx1/qlKj/1PGcGYuox/VNCL3PmpTO x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(39860400002)(136003)(346002)(366004)(396003)(186003)(33656002)(966005)(26005)(54906003)(316002)(110136005)(19627235002)(2906002)(4326008)(478600001)(53546011)(122000001)(38100700002)(83380400001)(52536014)(66476007)(66556008)(64756008)(66446008)(66946007)(55016002)(5660300002)(8676002)(71200400001)(7696005)(9686003)(6506007)(86362001)(76116006)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?YMPGoKGw14Qgnb9veky4PLnVplFjUolO4UoB+UjHDetn9B9XgGYocguaQ/jk?= =?us-ascii?Q?qA/ROiITbbsUrY4YOmXATNTYlwIsCVfR6gi4sHrlJ2mYJ49YwrDufq2bzFq1?= =?us-ascii?Q?2sn7laU8W5e2M9pSQFtKbvlsXmahiCdZYtXN0T+RnncjsAqUBaBq4trKjcqj?= =?us-ascii?Q?seOHKrTxCqK0jsXGQHXdbRydxNJ4+q0BdUWqsDsKHQY/lrJ6qCQGLs+n24ov?= =?us-ascii?Q?88Nv7kp+kdgzh20AQnxcd8mzeQonN4m8vy0tq0Guq8WiHWYmTzrrEw54HMy6?= =?us-ascii?Q?3WFx4i+W9BTTbYzlIvIxlaNhJamwEBeIMJl8UysrSXIXOB1gN4izsLSTsemm?= =?us-ascii?Q?FWaFogq03yfAG1EvVcbaNC7y3qsrTgvq2HdVLGlZ4LftkWuJ1z9Mb0fV7gKd?= =?us-ascii?Q?u9a6nMZe0FX1GoHin+G2Ki/1B4UFsWxugoZWeEdsWoy8uVKhOORRtDm4sVPM?= =?us-ascii?Q?PnBC5PWobGRhKbwnTez1iC1ugPyua9yVGTbvulSj38Y4t1pM5VLclehYGfNk?= =?us-ascii?Q?wGPrq/R+rzud/ym2IJCz0FI9afyLWpWdQ80YmXb29bYGmHdgbPc9mtTtovV8?= =?us-ascii?Q?re+7j6uRd4aB1GWUASDG2Z90g6IwA72fMpfJuSUcGbvoT/jqpkGUW9kv7EoK?= =?us-ascii?Q?pgH0g1R0UotRqua7tIev6GQoFWqH2LFd89iDZmoQeMG0jLLmBL8kFPJHArks?= =?us-ascii?Q?qmcU4g9w/O6qGs93RD6256RjEmQWsK39mRkdGnkealNErVJOWO08CUA6P1Qt?= =?us-ascii?Q?eHp7Pa3EaFlyLJfNmwrFdZFrYgtNlPKEzppfAhMfRxI8fPPcu5M+5WOcaBUN?= =?us-ascii?Q?48IAt6idYEL5HDvfD4RK6/nvBMhEAonjsmi2T52rvDXhd4Qm/nqemfJpWltj?= =?us-ascii?Q?Lst8TfRfaSK0h7L3OOIDxRqwkD+1CjA3gSduhdCOCOTb3LrCIPEqNDWQojvH?= =?us-ascii?Q?BpyddC/8Bdig9NoAt7AvQrabQ/yljjeWKs4CbVA/J3zZOAs4PLWUrGOnDUN/?= =?us-ascii?Q?GkPvtnwssKZ7G9zYFT4RwLaRKO7pFRJrDFSwk1mdruDBmL2s5LS/9x3Rxo/R?= =?us-ascii?Q?95Ain6pj7nhgO1I5YAssR+znwAf55+1sfGicBRwOQpA+Uyiv63DFneTyfHXE?= =?us-ascii?Q?XuFKgIDS5542p6Dr+IeguwczvH/GMjYTO1XlrFJFrqx1t/ZdhoRBnbdfMJwn?= =?us-ascii?Q?rTRq+TgVXXbxo/1VzLX88rCDo/XI8dbU/KE9DluA0oY0JssVO28j/fSFnGA1?= =?us-ascii?Q?+QkJOudQ/E05w/HvE87ICLleYag2dkIMZ5AvdsQHHH2FU1jD3c8LpI/jvN5Z?= =?us-ascii?Q?38aQlrFwr+XvNng/rTlyg1Es?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec47520a-111a-45ad-4183-08d927df8616 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2021 05:05:22.9282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DIn2bCsBJ8iudUVK30/vTPa7jwRkx+dQ9cyn7Y1qHn9QwXYQo8zLWdu3UyponDU7FcwTvAzOHPn+IbZHdbktVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1242 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Saturday, June 5, 2021 9:19 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Leif Lindholm ; Feng, B= ob C Subject: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to= convert the image to ACPI data With GCC49 tool chain, aslc file is compiled into elf image. But, its text section has no CODE attribute. So, it can't be detected by n= ew GenFw tool.For this type file. its text section is not required. Its data section will be converted to acpi table. This fix is to remove assert check when the generated image is ACPI data. Signed-off-by: Liming Gao Cc: Ray Ni Cc: Leif Lindholm Cc: Bob Feng --- This patch has been verified on GCC49 for AARCH64 platform.=20 BaseTools/Source/C/GenFw/Elf32Convert.c | 2 +- BaseTools/Source/C/GenFw/= Elf64Convert.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c b/BaseTools/Source/C/= GenFw/Elf32Convert.c index 7c8a065678ac..314f8233234d 100644 --- a/BaseTools/Source/C/GenFw/Elf32Convert.c +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c @@ -435,7 +435,7 @@ ScanSections32 ( } } =20 - if (!FoundSection) { + if (!FoundSection && mOutImageType !=3D FW_ACPI_IMAGE) { Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' section.")= ; assert (FALSE); } diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c b/BaseTools/Source/C/= GenFw/Elf64Convert.c index 8fe672e98448..8b09db7b690b 100644 --- a/BaseTools/Source/C/GenFw/Elf64Convert.c +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c @@ -714,7 +714,7 @@ ScanSections64 ( } } =20 - if (!FoundSection) { + if (!FoundSection && mOutImageType !=3D FW_ACPI_IMAGE) { Error (NULL, 0, 3000, "Invalid", "Did not find any '.text' section.")= ; assert (FALSE); } -- 2.27.0.windows.1