* [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
@ 2021-06-13 3:56 Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Rebecca Cran @ 2021-06-13 3:56 UTC (permalink / raw)
To: Bob Feng, Liming Gao, Yuwei Chen; +Cc: Rebecca Cran, devel
The words "overwrite" and "overwriting" are one word and shouldn't have
hyphens.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 4b5256ab6e..1fb44aaeff 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -227,7 +227,7 @@ if NOT exist %CONF_PATH% (
) else (
if defined RECONFIG (
echo.
- echo Over-writing the files in the CONF_PATH directory
+ echo Overwriting the files in the CONF_PATH directory
echo using the default template files
echo.
)
@@ -240,7 +240,7 @@ if NOT exist %CONF_PATH%\target.txt (
)
copy %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul
) else (
- if defined RECONFIG echo over-write ... target.template to %CONF_PATH%\target.txt
+ if defined RECONFIG echo overwrite ... target.template to %CONF_PATH%\target.txt
if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul
)
@@ -251,7 +251,7 @@ if NOT exist %CONF_PATH%\tools_def.txt (
)
copy %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul
) else (
- if defined RECONFIG echo over-write ... tools_def.template to %CONF_PATH%\tools_def.txt
+ if defined RECONFIG echo overwrite ... tools_def.template to %CONF_PATH%\tools_def.txt
if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul
)
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* 回复: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
2021-06-13 3:56 [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat Rebecca Cran
@ 2021-06-17 1:36 ` gaoliming
2021-06-22 9:38 ` Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: gaoliming @ 2021-06-17 1:36 UTC (permalink / raw)
To: devel, rebecca, 'Bob Feng', 'Yuwei Chen'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:56
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and
> "overwriting" in toolset.bat
>
> The words "overwrite" and "overwriting" are one word and shouldn't have
> hyphens.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> BaseTools/toolsetup.bat | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
> index 4b5256ab6e..1fb44aaeff 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -227,7 +227,7 @@ if NOT exist %CONF_PATH% (
> ) else (
>
> if defined RECONFIG (
>
> echo.
>
> - echo Over-writing the files in the CONF_PATH directory
>
> + echo Overwriting the files in the CONF_PATH directory
>
> echo using the default template files
>
> echo.
>
> )
>
> @@ -240,7 +240,7 @@ if NOT exist %CONF_PATH%\target.txt (
> )
>
>
> copy %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt >
> nul
>
> ) else (
>
> - if defined RECONFIG echo over-write ... target.template
> to %CONF_PATH%\target.txt
>
> + if defined RECONFIG echo overwrite ... target.template
> to %CONF_PATH%\target.txt
>
> if defined RECONFIG copy
> /Y %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt >
> nul
>
> )
>
>
>
> @@ -251,7 +251,7 @@ if NOT exist %CONF_PATH%\tools_def.txt (
> )
>
>
> copy %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_d
> ef.txt > nul
>
> ) else (
>
> - if defined RECONFIG echo over-write ... tools_def.template
> to %CONF_PATH%\tools_def.txt
>
> + if defined RECONFIG echo overwrite ... tools_def.template
> to %CONF_PATH%\tools_def.txt
>
> if defined RECONFIG copy
> /Y %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.t
> xt > nul
>
> )
>
>
>
> --
> 2.32.0
>
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76443): https://edk2.groups.io/g/devel/message/76443
> Mute This Topic: https://groups.io/mt/83503170/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
2021-06-13 3:56 [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
@ 2021-06-22 9:38 ` Philippe Mathieu-Daudé
2021-06-25 1:53 ` Bob Feng
[not found] ` <168BB0660551BC0A.31827@groups.io>
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-22 9:38 UTC (permalink / raw)
To: devel, rebecca, Bob Feng, Liming Gao, Yuwei Chen
On 6/13/21 5:56 AM, Rebecca Cran wrote:
> The words "overwrite" and "overwriting" are one word and shouldn't have
> hyphens.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> BaseTools/toolsetup.bat | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
2021-06-13 3:56 [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
2021-06-22 9:38 ` Philippe Mathieu-Daudé
@ 2021-06-25 1:53 ` Bob Feng
[not found] ` <168BB0660551BC0A.31827@groups.io>
3 siblings, 0 replies; 5+ messages in thread
From: Bob Feng @ 2021-06-25 1:53 UTC (permalink / raw)
To: Rebecca Cran, Liming Gao, Chen, Christine; +Cc: devel@edk2.groups.io
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com>
Sent: Sunday, June 13, 2021 11:56 AM
To: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
Subject: [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
The words "overwrite" and "overwriting" are one word and shouldn't have hyphens.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index 4b5256ab6e..1fb44aaeff 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -227,7 +227,7 @@ if NOT exist %CONF_PATH% (
) else ( if defined RECONFIG ( echo.- echo Over-writing the files in the CONF_PATH directory+ echo Overwriting the files in the CONF_PATH directory echo using the default template files echo. )@@ -240,7 +240,7 @@ if NOT exist %CONF_PATH%\target.txt (
) copy %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul ) else (- if defined RECONFIG echo over-write ... target.template to %CONF_PATH%\target.txt+ if defined RECONFIG echo overwrite ... target.template to %CONF_PATH%\target.txt if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul ) @@ -251,7 +251,7 @@ if NOT exist %CONF_PATH%\tools_def.txt (
) copy %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul ) else (- if defined RECONFIG echo over-write ... tools_def.template to %CONF_PATH%\tools_def.txt+ if defined RECONFIG echo overwrite ... tools_def.template to %CONF_PATH%\tools_def.txt if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul ) --
2.32.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
[not found] ` <168BB0660551BC0A.31827@groups.io>
@ 2021-06-25 4:20 ` Bob Feng
0 siblings, 0 replies; 5+ messages in thread
From: Bob Feng @ 2021-06-25 4:20 UTC (permalink / raw)
To: devel@edk2.groups.io, Feng, Bob C, Rebecca Cran, Liming Gao,
Chen, Christine
Merged.
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Friday, June 25, 2021 9:54 AM
To: Rebecca Cran <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com>
Sent: Sunday, June 13, 2021 11:56 AM
To: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
Subject: [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
The words "overwrite" and "overwriting" are one word and shouldn't have hyphens.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index 4b5256ab6e..1fb44aaeff 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -227,7 +227,7 @@ if NOT exist %CONF_PATH% (
) else ( if defined RECONFIG ( echo.- echo Over-writing the files in the CONF_PATH directory+ echo Overwriting the files in the CONF_PATH directory echo using the default template files echo. )@@ -240,7 +240,7 @@ if NOT exist %CONF_PATH%\target.txt (
) copy %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul ) else (- if defined RECONFIG echo over-write ... target.template to %CONF_PATH%\target.txt+ if defined RECONFIG echo overwrite ... target.template to %CONF_PATH%\target.txt if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul ) @@ -251,7 +251,7 @@ if NOT exist %CONF_PATH%\tools_def.txt (
) copy %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul ) else (- if defined RECONFIG echo over-write ... tools_def.template to %CONF_PATH%\tools_def.txt+ if defined RECONFIG echo overwrite ... tools_def.template to %CONF_PATH%\tools_def.txt if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul ) --
2.32.0
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-25 4:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-13 3:56 [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
2021-06-22 9:38 ` Philippe Mathieu-Daudé
2021-06-25 1:53 ` Bob Feng
[not found] ` <168BB0660551BC0A.31827@groups.io>
2021-06-25 4:20 ` [edk2-devel] " Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox