Re: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string

["Bob Feng" <bob.c.feng@intel.com>]

Created a PR https://github.com/tianocore/edk2/pull/1580

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Monday, April 19, 2021 5:13 PM
To: Shi, Steven <steven.shi@intel.com>; devel@edk2.groups.io
Cc: gaoliming@byosoft.com.cn
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string

OK. 

I also find a similar case in toolsetup.bat line 411 set "PATH=%BASE_TOOLS_PATH%\BinWrappers\WindowsLike;%PATH%"

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

Thanks,
Bob
-----Original Message-----
From: Shi, Steven <steven.shi@intel.com>
Sent: Monday, April 19, 2021 4:47 PM
To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io
Cc: gaoliming@byosoft.com.cn
Subject: RE: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string

Hi Bob,
I tried @set CLANG_BIN="c:\Program Files\LLVM\bin\", but it cannot work with my CI build service. Only the @set "CLANG_BIN=C:\Program Files\LLVM\bin\" can works. So, it is necessary to use double quote around the whole setting string, which includes both "=" left name and right value parts.


Thanks

Steven Shi
Intel\IAGS\SFP\FIA (Firmware Infrastructure Automation)


> -----Original Message-----
> From: Feng, Bob C <bob.c.feng@intel.com>
> Sent: Monday, April 19, 2021 4:34 PM
> To: Shi, Steven <steven.shi@intel.com>; devel@edk2.groups.io
> Cc: gaoliming@byosoft.com.cn
> Subject: RE: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN 
> path string
> 
> Steven,
> 
> Would you do a little change as
> 
> @set CLANG_BIN="c:\Program Files\LLVM\bin\"
> 
> I think the double quote should be only round the path.
> 
> Thanks,
> Bob
> 
> -----Original Message-----
> From: Shi, Steven <steven.shi@intel.com>
> Sent: Saturday, April 17, 2021 8:22 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; gaoliming@byosoft.com.cn; Shi, 
> Steven <steven.shi@intel.com>
> Subject: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path 
> string
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3341
> 
> Current CLANG_BIN env variable is set without double quote around the 
> LLVM default installation path string in windows, which causes some CI 
> build service cannot find the LLVM path in windows.
> This patch enhance it to add double quote around it.
> 
> Signed-off-by: Steven Shi <steven.shi@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  edksetup.bat | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/edksetup.bat b/edksetup.bat index 
> 7b9377aaa5c2..7ad137bb3e9b
> 100755
> --- a/edksetup.bat
> +++ b/edksetup.bat
> @@ -120,7 +120,7 @@ if not defined CLANG_BIN (
>      @echo.     @echo !!! WARNING !!! CLANG_BIN environment variable is not
> set     @if exist "C:\Program Files\LLVM\bin\clang.exe" (-        @set
> CLANG_BIN=C:\Program Files\LLVM\bin\+        @set
> "CLANG_BIN=C:\Program Files\LLVM\bin\"         @echo   Found LLVM, setting
> CLANG_BIN environment variable to C:\Program Files\LLVM\bin\     ) )--
> 2.28.0.windows.1