From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.8494.1618913876995204819 for ; Tue, 20 Apr 2021 03:17:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=fWvb+ABO; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) IronPort-SDR: 2FvhyAWlMy/9r9e7H8aOZ8wumuN2gDc8HSH4y6/NEH7GNAZonhEFrnUYQt6CoHyJ/ne5AJXjNO uc0wpKf4tpOg== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="195508449" X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="195508449" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 03:17:55 -0700 IronPort-SDR: dSnJH6UPcuWWJ/il/anm5vA3k5LVooFzRdIpAnofEIes0d60OkNG6V/QY7YFUCMfw2ORYqGkjt XGX8sENiUnxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="616861642" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 20 Apr 2021 03:17:55 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 03:17:55 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 03:17:54 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 20 Apr 2021 03:17:54 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 20 Apr 2021 03:17:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OdkVO8ieilZPqa5G7PWAGhr+bb/UBiyxaYPXWRGALDG1SM0CUmxE8XwJkih6g4m9K5RVXDiVHOkCQFbA+9MbNu3eDrSDc4hdgZcxShTkAhoa9TIVvgOg0Te0U8f40hhRWwSbSxBZC9n8B/TG6i6t6EnrR+F5AksHerUF/FBj2/uu0s5Cs52/hVbdyCLjlEoXVVrVAiQPdUOiMiMrapbt1IfVERtLQAbT8zDBlPUJ0JDojkWvMZlPadNeG4uDEBr677Mmebinv74KPbmFVaIHWKFrxUr1qIqxc8Ccma6TeoES2+PE3p82wuIPuvTUpfu4gclGcZGodAokdw3s9YdzHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=azZrkIwhQfgzO9X+dga7hQJwzviCH2c9OGGC2nzLpnY=; b=JN4qSSuEFnTVdqv0893vKKxy9DTGj+JFfheu16d3xZreca+Xw7XiBkgtYLOt42TB8Lr2FrLcWBYCplHlTjsh1BrZd26jhObvESawJyMOTy3FLsqRcpEcXB066FM70PYLOvuJG4olXIeOE26BVP3s2pXj/7nRD0ZMqXKTzBUmovHmF5GEfoyoTUB9hfuhQiTRSwl0OU9+t0fubN/+vDFQte79gxf3PQCRqCTFsVd0UMAf/uVk70xidOy5aLxtlY+8Xftc3UAVcnhmu+lInBO7JpAINXd7AWs9kOoCdaYXwFjQ2n0q11EbdpXcoJdkWe6ycXSdwvsqB+9xwexrdLcQJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=azZrkIwhQfgzO9X+dga7hQJwzviCH2c9OGGC2nzLpnY=; b=fWvb+ABO6LmTRXRMm6yrWFl5HaTPTR6EI/eV8oReIU6KaHTSDO9UCrHhazrmDOaBbJfsm5MoJqCaQ5nbpjtfPIHJdfvI48FpkihTeyt3/MC1C5YpM3h8AUM3iydd1+LwVRNS5PVd0nx4i3V2mqFoE/QKvFhWdraSuuM1Iiv5uVI= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB4233.namprd11.prod.outlook.com (2603:10b6:5:14f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Tue, 20 Apr 2021 10:17:51 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::cc64:a87c:5cf:5f18%3]) with mapi id 15.20.4042.024; Tue, 20 Apr 2021 10:17:51 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" , "Shi, Steven" CC: "gaoliming@byosoft.com.cn" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path string Thread-Index: AQHXM4RRbPrDgRbISkKYtP8/09FtlKq7hg7wgAAEHYCAAALcoIABqLjQ Date: Tue, 20 Apr 2021 10:17:50 +0000 Message-ID: References: <20210417122133.1879-1-steven.shi@intel.com> <167737869DB0B53D.14647@groups.io> In-Reply-To: <167737869DB0B53D.14647@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8e267ec9-a3d8-4c57-d740-08d903e58de3 x-ms-traffictypediagnostic: DM6PR11MB4233: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3yZfgnwc8mENjyTWBHzq2tMQRk1i9aeW1axSggG5UuoquCTCX6b0iDph6BgjKH/oVlbJPWdUKaAQZHWEEv+8vMIGlo0wYUeAUxrwXNTCWHgp+n60JNgHbZ4qyGsDB+SPaVn+09iNHM0jghrHeONxXYU+jkam5HSwlQptiG0M23mF+pM7BO34xCu1agWzbW6rlq+2MZ0+zQAl8t7rrR2GQbIgv3ENIBMe/vZDoMngZ9SOIX09MJYQpycrHbnI3cdn5pv9qHc6ZjNGw5OILFRtDjF4ZXpuFfT/xUOwiQnttswqK8TpTYFBeQQusB0+JNWiSPkSVMkYhf7UTUA8DszwzI8gBgQI/wp/6Leb+lLseNu0+vli9MytOo+j+9yP1N8i/UHDRo7SsIn+Asb2UvZ5VGO+mvfjpGLiX21RL4l6axL/ipCpG/yjZz5tcD+/pksFU1les9ZMi1IvXTvCe9ijVeSLeqQ9icZC6JWQRzRSDsilPRWj+YuBgRQ/rSLNsA2YH1U0uVn2CbNzppeqbqWDcPmfwQDqqGuWiQPSnXcOhapMrGHATdMdHwH0fEHxt8m+RfdSGhtAc3YTfrwTSN2XEIDxLMS8A4oHMs95abiGvoKEp22nsmWLA3WDdtWUqid1FoqEomf6wVQBqiy9oS9/HE0DNJ00BA8zM2jZiK6Bncteh+pEsMB4BRTVhCDErT4F6A3xSoUGVSLZ/WFFk8/A7zQo8LJ1bS/W6u6qR2ogadk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(396003)(376002)(366004)(39860400002)(66556008)(7696005)(66476007)(64756008)(66446008)(186003)(86362001)(2906002)(5660300002)(6636002)(8676002)(6506007)(26005)(55016002)(52536014)(966005)(38100700002)(122000001)(53546011)(478600001)(83380400001)(4326008)(110136005)(71200400001)(76116006)(8936002)(66946007)(9686003)(316002)(33656002)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rjVkR73SpRy/Td1YESBEsZIuVZMi8kRlQ/NNjsDjsZOvbVCJIuinIIgoyJim?= =?us-ascii?Q?Kpc0Kv1d52rQBHyoVgcoPB/4B2CKlgnUrUeUpablLaC4ozMwYlGwBhz7aQN4?= =?us-ascii?Q?ZWowg12dV+R99oj4kl6TxDWHhl5GUHiZCoPBKVcEGtLHtE+DgH4f8vnKmGuS?= =?us-ascii?Q?iAXr++PyteSBHxNruZM8bj0zZM76SF+wQawL9U8WQXIPBsYaUi0DI83OFr2w?= =?us-ascii?Q?c+jkjbDGxt7bxdDi8MnGvtqk0W5q8FyRsbu6E2iofrPLeDujb6TU5f/VHz1J?= =?us-ascii?Q?mVoilrivb5UCfx8pR7Kh4wRRjezdiS6VySVJVrU8qLwdPhrb8HgOH6TXxs6F?= =?us-ascii?Q?GQVWsBMWBlpWygNTp2Pxzzaj0xyB5oxSw4Vbu2vfZGTf6x52ZZLFl046awCu?= =?us-ascii?Q?ZmubJ74T6fhXzNJ9pWJsvzbwZpXTVCniyuFIz+6v/pDNSCsDRG58dRZXPJLG?= =?us-ascii?Q?IJwV1KiWgOt8lwCbni+1b/kQQBRlKK70x1nUuCW65+b+umqHbcQBmnwQw9+9?= =?us-ascii?Q?iFwGgFEGplonnjHDxGHvvFNz9/mImFSEkbBnERvBu0GTCJN7KxlcWkVvIZip?= =?us-ascii?Q?xOfr6kHxAi3dcJayh0QcDWrreTQKcWR7GzMaAVf+vWAhtiPQ+nJXbxBIF4nF?= =?us-ascii?Q?L+eEIUK4arooJkii90gXUrUq7lVF3dRKQQb7oDWOMQf49Xz1fMup99FL30jo?= =?us-ascii?Q?UJLuIjoVOP3ay3J0tg4z4yH4SKniJPl3OyvNxkSfNp5I5QM37KwTlsaMPLbO?= =?us-ascii?Q?lmx7zZH7aq+v8jO5kuQdLvvEIASlVyDAL3CgjnMr8EWi27tDH3rWtQ4E2lWA?= =?us-ascii?Q?D5/4IQlNLzz2hQdZ7wHleD2uDLhd9NeKAbd9QdnqYOGkk5NfJc/lOXrQYFQj?= =?us-ascii?Q?2A7IQPYiKs6IqblcEj+ZdurSXes1Km1Esg6vMLEWtjKUNXBmwejcGM/xrIs8?= =?us-ascii?Q?RBxJ16ABI8LASxFAEUGl005YtOxxD+MIC8299BHhZc8vcNTy+cZHkJWnLOns?= =?us-ascii?Q?FkLHtIWR8Stw7Tzdn/3Ag59UKrfBQ4ZpnuGooRwGsTQku3uYzQk88UlszoUT?= =?us-ascii?Q?H+226Z9eBr50ueojsIa+IARk/9hQwBoFGRXOqOA8jbGKpVHQz11EqnS4+CKH?= =?us-ascii?Q?tHvrMB1/y3ZHgO/RIT0EQHMzWaT6sHUCnjWGSdnDhTj+NtBI1lilQIZNvcIi?= =?us-ascii?Q?8obC04iRnsWmDWX8UsyfT+5bmvfcGr83TzEUNMELni2jzQk0F5kxQJ9XZv8Y?= =?us-ascii?Q?wzJ07g5/HVZRGAsBuE92mmdexMkS1k2o+fnoAQLC7MHcZ5osgR7PFNHAJaeA?= =?us-ascii?Q?osuSgpcXbZuO5YiNfMZifHTd?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e267ec9-a3d8-4c57-d740-08d903e58de3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 10:17:51.0970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3mmWv/KKo7IA0S1D4GgY0rlm5DtjN0GhYkrMjb7HfwlQlJBf9zHkL0zzYNq1PAoTF6CN/H/yHT5jykp5nfMPcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4233 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Created a PR https://github.com/tianocore/edk2/pull/1580 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Monday, April 19, 2021 5:13 PM To: Shi, Steven ; devel@edk2.groups.io Cc: gaoliming@byosoft.com.cn Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Add double quote around C= LANG_BIN path string OK.=20 I also find a similar case in toolsetup.bat line 411 set "PATH=3D%BASE_TOO= LS_PATH%\BinWrappers\WindowsLike;%PATH%" Reviewed-by: Bob Feng Thanks, Bob -----Original Message----- From: Shi, Steven Sent: Monday, April 19, 2021 4:47 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: gaoliming@byosoft.com.cn Subject: RE: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path= string Hi Bob, I tried @set CLANG_BIN=3D"c:\Program Files\LLVM\bin\", but it cannot work = with my CI build service. Only the @set "CLANG_BIN=3DC:\Program Files\LLVM\= bin\" can works. So, it is necessary to use double quote around the whole s= etting string, which includes both "=3D" left name and right value parts. Thanks Steven Shi Intel\IAGS\SFP\FIA (Firmware Infrastructure Automation) > -----Original Message----- > From: Feng, Bob C > Sent: Monday, April 19, 2021 4:34 PM > To: Shi, Steven ; devel@edk2.groups.io > Cc: gaoliming@byosoft.com.cn > Subject: RE: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN=20 > path string >=20 > Steven, >=20 > Would you do a little change as >=20 > @set CLANG_BIN=3D"c:\Program Files\LLVM\bin\" >=20 > I think the double quote should be only round the path. >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Shi, Steven > Sent: Saturday, April 17, 2021 8:22 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; gaoliming@byosoft.com.cn; Shi,= =20 > Steven > Subject: [PATCH 1/1] BaseTools: Add double quote around CLANG_BIN path= =20 > string >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3341 >=20 > Current CLANG_BIN env variable is set without double quote around the=20 > LLVM default installation path string in windows, which causes some CI= =20 > build service cannot find the LLVM path in windows. > This patch enhance it to add double quote around it. >=20 > Signed-off-by: Steven Shi > Cc: Bob Feng > Cc: Liming Gao > --- > edksetup.bat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/edksetup.bat b/edksetup.bat index=20 > 7b9377aaa5c2..7ad137bb3e9b > 100755 > --- a/edksetup.bat > +++ b/edksetup.bat > @@ -120,7 +120,7 @@ if not defined CLANG_BIN ( > @echo. @echo !!! WARNING !!! CLANG_BIN environment variable is = not > set @if exist "C:\Program Files\LLVM\bin\clang.exe" (- @set > CLANG_BIN=3DC:\Program Files\LLVM\bin\+ @set > "CLANG_BIN=3DC:\Program Files\LLVM\bin\" @echo Found LLVM, set= ting > CLANG_BIN environment variable to C:\Program Files\LLVM\bin\ ) )-- > 2.28.0.windows.1