From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.33856.1608517667607391288 for ; Sun, 20 Dec 2020 18:27:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XnOKF9+2; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: bob.c.feng@intel.com) IronPort-SDR: i6lvRQYl6odfHhYfvmu6/kADo1V79XHTgNajzrRIJoNzoDgNiMjsF3oLcD+g0UGGxL+HStLGPA c3SRJqEajLzA== X-IronPort-AV: E=McAfee;i="6000,8403,9841"; a="237235461" X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="237235461" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2020 18:27:46 -0800 IronPort-SDR: R/9fBisJARZnztu3p+66BTx5ItA37Ghf96gSfHu0niRo9XVQE9AAmyjdL7iaITGCRHo7uNEW40 JBKrFT7R7ugA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="560001171" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 20 Dec 2020 18:27:46 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Dec 2020 18:27:45 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Dec 2020 18:27:45 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 20 Dec 2020 18:27:45 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 20 Dec 2020 18:27:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VDFqPOEWgVkQD/ya5pQZwbNHAuzRNzViuX0O0e9f/6pFKHbIdndl8162pjkwUGAtXyseDoiAdX0DosPs1he4T9CL+VFh/dW3jIaDcILYO3Pbmz0x3JzYChsMXSXKWbCnIjxOEp9wlfnXrNoMcyukMdEY/PuSkSDQ/ekHHKwcUPUCibcJEMgWUBG7Yrs8qFeX090JKJfJpU4KiW4n9b2jm8Daq1SiHlqlDbfzMdCeJlPX3M6xQ0xnGXIb54MbeZwz1o7fIKvjWy7o6IzDtFI/LT+RLUMujRG4nXbNOu9e+YUN5yS3LDGw8E3Mv8XUZQfSPHBhd9JO87bKPXlTJulkrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R48V0557jAhk/InkCdZ/7iHCu+w8g5QklLOLqLJjK48=; b=BXBqE9LL5t/75KLoPffOOUA4Xif2sU73d/x82oG+5WInxLQuQ/JCOv4fnoqVbDxM5ykZbQIQA8vMZ7N+TLLs2lHbSpg94QLwnhqxNRERU2Gs6a1kNTBtVj9I1aQ5oPrQqah1d7qom/bcyym0ZWtuQVnpMWddiQMPGQqK226HXLMenxy0A8/2cgct10DLZW1jgj7Qf2r0AV6EMPAUUiWeKfPW/3z0K0r52axVtiVbqbBp5WzaFi35G3S6YkuIQ/UMDj0F7iwws375x3x4U+Ci+o4+s/t3gdHZ9r3/XvSFAf9kclUlz4PdO4DyA/VzvFtIb7ssfGhdgoqTg0FrN+hYIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R48V0557jAhk/InkCdZ/7iHCu+w8g5QklLOLqLJjK48=; b=XnOKF9+2ZGZlCe1kpUz2y/VLtex74XFgPuxBUoLBbKOYv3ml+ivSlCzui2gc6ImxhjEZVAniLECmmqVg1X8MmuBb6GfzG8WD/AO8+u9hnp49cAFc35QvDTfPR0yozJUmEZBbXu2ekIUySwySihBYe6tRML8eJRdRVZJ5VLbjb3g= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB3515.namprd11.prod.outlook.com (2603:10b6:5:6c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Mon, 21 Dec 2020 02:27:44 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb%3]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 02:27:44 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" , "xiewenyi2@huawei.com" , "gaoliming@byosoft.com.cn" , "Chen, Christine" CC: "songdongkuang@huawei.com" Subject: Re: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing else if statement Thread-Topic: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing else if statement Thread-Index: AQHW0qwhCZlEOlNuskG13ux6iJp9/6oA1o6QgAAFrcA= Date: Mon, 21 Dec 2020 02:27:44 +0000 Message-ID: References: <1608013846-109318-1-git-send-email-xiewenyi2@huawei.com> <1608013846-109318-2-git-send-email-xiewenyi2@huawei.com> <1652993EE39DFAF7.21743@groups.io> In-Reply-To: <1652993EE39DFAF7.21743@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cff1c3b4-1bda-42ce-ebf2-08d8a557ff8b x-ms-traffictypediagnostic: DM6PR11MB3515: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wGmT9O3WzlGyaHbuSBw2AecH9xVdA7pbSMI2MYD0buyNwBLr3IABlq4eOCXIfzXCxKzO82rSYlMBFTYYlnSxOOPtGC323dnMtKYCnS5QLU7HXvBWg71dE47x2OQwDeAiNwBJuetf3jhy2Cnvp/lNJsmzJAQCR55GNjlxg3C06j7ulyC8iqGsZmyFG7ei5G2xn4msXjkZeREYzfZzj8oufKbqunAhcrRWHhdkowDjjFpsJY3SdxqyhTEWTeLQdBud7fUN6auAxecBLlg05jWL3oOicMwFwXbVyU5nv2BTd/LEetiWt2xZkQH6RRNZn3so/nfiflnScNKMJTOi1aAjsq2XX+m3gtZcpaQxvbHGKJX505zBwFujJ7txJd7S8vmM1LGqrVb89T+6HW98DRjKwFzQp9XhjN4hzSNtz8gIuI5oe1ak//pE1ifLeirMx5+4zvm27o2pnKpwhrGgQbN7cg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(66946007)(478600001)(9686003)(53546011)(55016002)(966005)(316002)(4326008)(6506007)(8676002)(71200400001)(7696005)(186003)(66556008)(52536014)(110136005)(66446008)(2906002)(83380400001)(66476007)(26005)(33656002)(64756008)(8936002)(6636002)(86362001)(76116006)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?4WP/hmXxpDUtCwuz/GKir+lMm2lvBkDp0LT+w9Fqap2U/QGCbi/sg8xWBqEj?= =?us-ascii?Q?tb/0HlxHOOdfuMw17fyCut7L6d4BnYQcLwVm6M6oVV4NJ1Zb+JM0Pj4zpE56?= =?us-ascii?Q?n3QdquWu3Ca2VEzgllA1IBZ3bjj9ldz4m0pjR+C5vKMsALOzKSk17CnbPsj2?= =?us-ascii?Q?fNWQz1VRqdfo9zTQDhDtjIesIlgfsDlAYZGKHii1VBJELjBUVB8mA6D29Zq+?= =?us-ascii?Q?rilRuqoLY0vFS4nZByP0M9nJRVw4xHNfziN+PJ14bJVmCu6JZ1WUetE95o4p?= =?us-ascii?Q?aKNpWqvHXbNiT+LQ1FyUugOEXBjplfyTByEX8o/6jGT+YmtoK2UtC+oVQfE9?= =?us-ascii?Q?8NZk04nx9k+kZi6INQO0vPGbk8T4Mb45TMDX8/Ajv5su9CygpjJiK9pOmu1y?= =?us-ascii?Q?obhMm2Z2lUr/d1nvvyN83fzFYDr4go/8FIoext9UmoCIBI6xiNHYhlkpHP+b?= =?us-ascii?Q?EWpMHnY3WdjLRuOnWjSPR6us/EQwQ9Z7BZPubIMdvwPNYyueb3agvMngANE8?= =?us-ascii?Q?OiRRsYDgSNR80KUIvUR5Q6cY+2cGcQiXZATkNtU56YPyKgFmRiH0BEslHgnw?= =?us-ascii?Q?u+dmYvWWWAcHM0cIGu6x/W8LKRkOCcFrgldRTXi+Mm2wNOzuR6rEyfqjEl6x?= =?us-ascii?Q?71k+W3Ka4B5pJdRL1SyYbxBZKZ6dVRcFrG1MySJbhSbMA6qtIDIZShuOfG2V?= =?us-ascii?Q?d10e9QRkhBDdnrECYS5a4bvGu7NnbmDq8Ay1Thuw9hnwZy0ai1XxtxAzx34z?= =?us-ascii?Q?/r/Rpr/af2U4JhF2NhCHDW2pB/O5Zx/uU45rOY4d/R9gQw+SWxeNbdJepoyo?= =?us-ascii?Q?lwlExccyeFRUb9Z14GIHCUmdkLQDuxXLjU2+BOk+n1TQXeDGAaGIBwIXnFUx?= =?us-ascii?Q?zVfVCADKF1FTAEhVVDgIUiS14fiPBBEjvQ2kUSYwpb6mBKlk2fbiM7GJ28cD?= =?us-ascii?Q?30AypH+kkIbBQ/9V9Wk2TL+5J6cWe75X++QbPNJoYio=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cff1c3b4-1bda-42ce-ebf2-08d8a557ff8b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2020 02:27:44.0373 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mGg8Vj//ILPSRSi2746qHO7YZCR+N+LT9cqakLNsIIN+c/mFUQFI3n9Kj9ekiuHxeLNANQokwgm9DQtSg3Vhng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3515 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Created a PR https://github.com/tianocore/edk2/pull/1250 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Monday, December 21, 2020 10:07 AM To: devel@edk2.groups.io; xiewenyi2@huawei.com; gaoliming@byosoft.com.cn; = Chen, Christine Cc: songdongkuang@huawei.com Subject: Re: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing= else if statement Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io On Behalf Of wenyi,xie v= ia groups.io Sent: Tuesday, December 15, 2020 2:31 PM To: devel@edk2.groups.io; Feng, Bob C ; gaoliming@by= osoft.com.cn; Chen, Christine Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com Subject: [edk2-devel] [PATCH EDK2 v2 1/1] BaseTools/GenFfs: Optimazing els= e if statement When Alignment < 0x400 is false, the expression of Alignment >=3D 0x400 is= always true. So extract the expression from the else if statement. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Wenyi Xie --- BaseTools/Source/C/GenFfs/GenFfs.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c b/BaseTools/Source/C/GenFf= s/GenFfs.c index fcb911f4fc34..949025c33325 100644 --- a/BaseTools/Source/C/GenFfs/GenFfs.c +++ b/BaseTools/Source/C/GenFfs/GenFfs.c @@ -821,12 +821,11 @@ Returns: if (Alignment < 0x400){ sprintf (AlignmentBuffer, "%d", Alignment); } - else if (Alignment >=3D 0x400) { - if (Alignment >=3D 0x100000) { - sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); - } else { - sprintf (AlignmentBuffer, "%dK", Alignment/0x400); - } + else if (Alignment >=3D 0x100000) { + sprintf (AlignmentBuffer, "%dM", Alignment/0x100000); + } + else { + sprintf (AlignmentBuffer, "%dK", Alignment/0x400); } Status =3D StringtoAlignment (AlignmentBuffer, &(InputFileAlign= [InputFileNum])); } -- 2.20.1.windows.1