From: "Bob Feng" <bob.c.feng@intel.com>
To: Yunhua Feng <fengyunhua@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [PATCH] BaseTools: Correct report the line number in INF file issue
Date: Fri, 18 Dec 2020 11:10:42 +0000 [thread overview]
Message-ID: <DM6PR11MB4073ACF2E90DA5F3F1C61962C9C30@DM6PR11MB4073.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201218030750.2993-1-fengyunhua@byosoft.com.cn>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, December 18, 2020 11:08 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH] BaseTools: Correct report the line number in INF file issue
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3127
If one protocol is not found in package dec file, Build will report the error message that module.inf(-1): error 4000: Value of Protocol [gXxxProtocolGuid] is not found under [Protocols] section in MdePkg.dec.
Here, -1 should be the line number of this protocol in module INF file.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/Workspace/MetaFileTable.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/Workspace/MetaFileTable.py b/BaseTools/Source/Python/Workspace/MetaFileTable.py
index 20cb80e36e..bebf9062e8 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileTable.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileTable.py
@@ -154,7 +154,7 @@ class ModuleTable(MetaFileTable):
if BelongsToItem is not None:
result = [item for item in result if item[7] == BelongsToItem]
- result = [ [r[2],r[3],r[4],r[5],r[6],r[0],r[9]] for r in result ]
+ result = [ [r[2],r[3],r[4],r[5],r[6],r[0],r[8]] for r in result
+ ]
return result
## Python class representation of table storing package data
--
2.27.0.windows.1
next prev parent reply other threads:[~2020-12-18 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 3:07 [PATCH] BaseTools: Correct report the line number in INF file issue fengyunhua
2020-12-18 11:10 ` Bob Feng [this message]
2020-12-21 1:41 ` 回复: [edk2-devel] " gaoliming
2020-12-21 0:53 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4073ACF2E90DA5F3F1C61962C9C30@DM6PR11MB4073.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox