From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Feng, Bob C" <bob.c.feng@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
Date: Fri, 25 Jun 2021 04:20:28 +0000 [thread overview]
Message-ID: <DM6PR11MB4073D9558393F9F3B4F502FFC9069@DM6PR11MB4073.namprd11.prod.outlook.com> (raw)
In-Reply-To: <168BB0660551BC0A.31827@groups.io>
Merged.
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Friday, June 25, 2021 9:54 AM
To: Rebecca Cran <rebecca@bsdio.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com>
Sent: Sunday, June 13, 2021 11:56 AM
To: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
Subject: [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat
The words "overwrite" and "overwriting" are one word and shouldn't have hyphens.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index 4b5256ab6e..1fb44aaeff 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -227,7 +227,7 @@ if NOT exist %CONF_PATH% (
) else ( if defined RECONFIG ( echo.- echo Over-writing the files in the CONF_PATH directory+ echo Overwriting the files in the CONF_PATH directory echo using the default template files echo. )@@ -240,7 +240,7 @@ if NOT exist %CONF_PATH%\target.txt (
) copy %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul ) else (- if defined RECONFIG echo over-write ... target.template to %CONF_PATH%\target.txt+ if defined RECONFIG echo overwrite ... target.template to %CONF_PATH%\target.txt if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\target.template %CONF_PATH%\target.txt > nul ) @@ -251,7 +251,7 @@ if NOT exist %CONF_PATH%\tools_def.txt (
) copy %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul ) else (- if defined RECONFIG echo over-write ... tools_def.template to %CONF_PATH%\tools_def.txt+ if defined RECONFIG echo overwrite ... tools_def.template to %CONF_PATH%\tools_def.txt if defined RECONFIG copy /Y %EDK_TOOLS_PATH%\Conf\tools_def.template %CONF_PATH%\tools_def.txt > nul ) --
2.32.0
prev parent reply other threads:[~2021-06-25 4:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 3:56 [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
2021-06-22 9:38 ` Philippe Mathieu-Daudé
2021-06-25 1:53 ` Bob Feng
[not found] ` <168BB0660551BC0A.31827@groups.io>
2021-06-25 4:20 ` Bob Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4073D9558393F9F3B4F502FFC9069@DM6PR11MB4073.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox