From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.839.1608081965082551723 for ; Tue, 15 Dec 2020 17:26:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=tkbt+v4d; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: bob.c.feng@intel.com) IronPort-SDR: Q2Sp/cxgLDB/2QAWNLm2oKkrITyn7/Sf7d83tabqhyZrBHTh9iUknM1+W2a3ZnMG3QstAWAPK5 Oej0z0GngFnQ== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="174210761" X-IronPort-AV: E=Sophos;i="5.78,423,1599548400"; d="scan'208";a="174210761" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2020 17:26:04 -0800 IronPort-SDR: w7qdErlS9MaOuHxYylGAqSlH1TV2CfWoxsxW0y+n5f01dJ2XJLismUnmbtdQBVpmwMllrrDwHL rbf8WTXOuItA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,423,1599548400"; d="scan'208";a="378898996" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 15 Dec 2020 17:26:03 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 15 Dec 2020 17:26:03 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 15 Dec 2020 17:26:03 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 15 Dec 2020 17:26:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fgNWcXW953k09NS0ptJImwjOzll55ka9+AR2o2pzXU4q/37wQIbf9npucSQR7AwB+QTBh4NJxeDPDdEqWhA/A/QbfGWw8TMZbgqI1HcznU1Q+TRmdeYyx5/7NvNyXt0SLSocr2tYTqarJGaFGv64gWWMImfTL6c8EoO5w6GsiAw20WNBInLh5kPjevNjXpFIRuJVkpOyta6DWgwUdAtr4i834YvsP+iKi3CIe6TG/IUOb8j22IarANX4LNkdMC4cWeDNsvl/9l/c4iAuniPmpgdpw9OTHbF5yVoBvkyELIMp7xzG1wqlII1Yg4xu7qEwdchN9wk7hb3soPR/hdkatQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LXx373UTu2AnxhfNk94+4fVnujcfx4q0N/SeYH7nMFc=; b=RhvGrwx4SBiZSlRuEFcrxZwYloHOjfmhbQKd/g7HAvOwWqUYkYVLtpONDArHO16cdj/XvpjsY5P2fNi5vz/2IwrkyZiMfFuXLMYQsLpG4bjqOS2X5ekqY7N7SCfmlybowW+6G2om9G2UKiYrm/KfEAMxpC1X8s9bvx4qmhuY3RahdTUZHUsRRmdMT45xEgISSbKr6++c225V6zibetBctGkw/tbPD2LroSS0tl9dghWkF1j/oZuyeyL542+exTMxAjIks0i9CFpbRyhINae5/OGCFIMZdhX128JTjFFVReEdlCG3/DrvzIAqIZpXvWQz6r9EBEY2t2pur7b+gm5N2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LXx373UTu2AnxhfNk94+4fVnujcfx4q0N/SeYH7nMFc=; b=tkbt+v4dJ1uwKmSbJ4KZep1CukJXFctMHV6GdceOj+pkIlYN9JucLw0JN8zDMR1MrKr/u5ST4/wAkuSyABQUzF8Z1OkmNiQeH71BWC/YvXEOMAM0qF8zyIG0XEO2GTMV9JNxwJ85s1Kiyu+hMXzxjFpkbDjyhpE+UanipZSfq/U= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB4612.namprd11.prod.outlook.com (2603:10b6:5:2a8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.17; Wed, 16 Dec 2020 01:26:02 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb%3]) with mapi id 15.20.3654.025; Wed, 16 Dec 2020 01:26:02 +0000 From: "Bob Feng" To: Yunhua Feng , "devel@edk2.groups.io" CC: Liming Gao , "Chen, Christine" Subject: Re: [PATCH] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Thread-Topic: [PATCH] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Thread-Index: AQHW00dTgSE79wTyiEKtNcEVYMuTQqn4694g Date: Wed, 16 Dec 2020 01:26:02 +0000 Message-ID: References: <20201216010301.2467-1-fengyunhua@byosoft.com.cn> In-Reply-To: <20201216010301.2467-1-fengyunhua@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be4786ed-aee8-4f72-b579-08d8a1618d0f x-ms-traffictypediagnostic: DM6PR11MB4612: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:422; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jSYJtY3DNiXtkL6954HSKzWRTfCFd0U2vtM4FLzsMPtP9/HGQXlWPbsb7PVzdiq73xg/UJ4EinsHshmgHWw9uhsyZzVXYXCaF2eRbhfFTAffu+/foPpOrQQA+BalZHzqWlgU720Ajx16E7oopTiKxk4VqAh0Dramy+CbpPEiDv3VxjOaUYcgUtOepB9N+iK8er/OEJmMnwr98foIMti3F2hao8WzYUa4bamCy9GQ0+3utOYra8c/CWuj9J1UOJM/cW3295i3GFlJdnJ4QAkaYrlwJfvtwIPo5oRrXtR3HBBuvafB/+StYHH2Bny9PbTp1ePO2rnVb3egZ6pG02/lmZOWGUOGjr8Awt24dGUYaJZ4g671a/URPm8TThK0ty1f11KFOH1fQE9lb0nlZR3FZQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(55016002)(4326008)(110136005)(7696005)(66556008)(33656002)(64756008)(8936002)(66946007)(186003)(316002)(2906002)(76116006)(52536014)(66446008)(53546011)(5660300002)(6506007)(26005)(107886003)(66476007)(966005)(54906003)(9686003)(8676002)(478600001)(71200400001)(86362001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?bd3yPJpRnfyZB73+QS76WPjB/zUxqpfMd+zOhD/2CuUx+0OD+fcGn6+Vm27X?= =?us-ascii?Q?oEV6JN7vfAr5PYH7NnkD/KM6GIfSzByd2XksFbxH+eEDTKduAGR54w0MAJeB?= =?us-ascii?Q?V7kxEZh3lvwI0QCf1rxZBOspT/qOw3rEZhUvBaD0kmvE4NZWxiKq50LnqBaz?= =?us-ascii?Q?5x9HqPqec1+aWYpVepPYuxSqsRt5t6CyhrtB3ZsbMRP5lulGyX6wUQcdETj+?= =?us-ascii?Q?HTv2DvSPDwlWxrz2h87uSTUbG1hVJCk0o51PM7mlDuoudvc9bTtfBa6ZNZGi?= =?us-ascii?Q?oH6vNeeqy+1LaVZqaotNIJxgl5bFAXrP2mc+Sc7Fio2bv09zrrKtdq1b4iz2?= =?us-ascii?Q?DXUgtDvzgJYYrBfYrF0M0Na0+G7VOzj//S7Fbwv+z3AHCrqEB08wkSHpwFFG?= =?us-ascii?Q?63RfUMXz1xa8ohdRKSgWypKEdgRSeCDoc6KaHYsBBmNrm+1RgwVW4hYo/51e?= =?us-ascii?Q?/h2LRZOtlmDcc491RzWHo1jY1MLj41VKyGxojtI/lJgS6pcMMsIxojPtDbGv?= =?us-ascii?Q?Mmgiz4s+qYv0fMLY5cI1glI3JioqSTnHNcRVUpsR/lxQY+nV6gC8ZMDC/TNe?= =?us-ascii?Q?g4h3n9IKlTOG5iBXMoXXDIKyZ48hn1wPdvfrZvSph2FD8myt35RMOeFRBGHT?= =?us-ascii?Q?gyGOKGv/ER//FbAuEoso36667k4bAT6fTVbE5lE0ckZeQgoxngzxNz1W/tC0?= =?us-ascii?Q?6sq0788IcEZhkmbkwM2l3ooL7T+EyEtukjiYZZaZGiRF+0zrlQ1Z8fN3XsbV?= =?us-ascii?Q?Ee4zACspNSvsJh83v16ZvYruHkkzC5ShzY2Ix0DCxMv5tMmTNL3a9SjKuj7W?= =?us-ascii?Q?7nNcWVdh44lKnCNnYaT3c5iRLfKor7/FdX34BdXMh+hil3CCoMw5fEIhr/cq?= =?us-ascii?Q?AdfELZYzashlDl3XRu4kWOoUSiUdqspC4Eqitz1QyzQ2pNeqt9oR6w/jwCq5?= =?us-ascii?Q?aEOc3vRmPn0Vrn3gHe8vzw9uVgAsSnWl4XIna6ZJpMU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be4786ed-aee8-4f72-b579-08d8a1618d0f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2020 01:26:02.1892 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r7s9POnsDEb8I8QI7+sNHkZyj//FFFku8CRhSLx1l5zBM3EqOtNr38gdLut4Ds2Z5XKX6YTBo07kPMvUGltaMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4612 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yunhua, if FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PC= D TOKEN, maybe it's better to remove "#define PcdTokenName TOKEN" statement= for those static PCD from AutoGen.h. Thanks, Bob -----Original Message----- From: Yunhua Feng =20 Sent: Wednesday, December 16, 2020 9:03 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [PATCH] BaseTools: Should always define PCD TOKEN value as Zero fo= r static PCD REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3120 FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN. Their PCD TOKEN value can always be zero. If so, AutoGen.h will not be chan= ged when PCD is added or removed. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/AutoGen/GenC.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/Pyt= hon/AutoGen/GenC.py index a2053d5485..ac561ba82e 100755 --- a/BaseTools/Source/Python/AutoGen/GenC.py +++ b/BaseTools/Source/Python/AutoGen/GenC.py @@ -913,6 +913,8 @@ def CreateModulePcdCode(Info, AutoGenC, AutoGenH, Pcd): ExtraData=3D"[%s]" % str(Info)) else: TokenNumber =3D PcdTokenNumber[Pcd.TokenCName, Pcd.TokenSpaceG= uidCName] + if Pcd.Type not in PCD_DYNAMIC_TYPE_SET: + TokenNumber =3D 0 AutoGenH.Append('\n#define %s %dU\n' % (PcdTokenName, TokenNumber= )) =20 EdkLogger.debug(EdkLogger.DEBUG_3, "Creating code for " + TokenCName += "." + Pcd.TokenSpaceGuidCName) -- 2.27.0.windows.1