public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Feng, Bob C" <bob.c.feng@intel.com>,
	Enze Zhu <zhuenze@byosoft.com.cn>
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
	"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH
Date: Wed, 6 Jan 2021 03:07:31 +0000	[thread overview]
Message-ID: <DM6PR11MB4073E64909C3FB454CC5462DC9D00@DM6PR11MB4073.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1651CB07AB6014B1.25767@groups.io>

Created a PR: https://github.com/tianocore/edk2/pull/1299 

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Friday, December 18, 2020 7:10 PM
To: Enze Zhu <zhuenze@byosoft.com.cn>; devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Enze Zhu <zhuenze@byosoft.com.cn> 
Sent: Thursday, December 17, 2020 10:20 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3032

We had a build fail due to the hard coded MAX_LONG_FILE_PATH value.
We should use PATH_MAX if it is available.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
---
 BaseTools/Source/C/Common/CommonLib.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/BaseTools/Source/C/Common/CommonLib.h b/BaseTools/Source/C/Common/CommonLib.h
index e1cce985f7..0f05d88db2 100644
--- a/BaseTools/Source/C/Common/CommonLib.h
+++ b/BaseTools/Source/C/Common/CommonLib.h
@@ -12,9 +12,17 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #include <Common/UefiBaseTypes.h>  #include <Common/BuildVersion.h>  #include <assert.h>
+#ifndef _WIN32
+#include <limits.h>
+#endif
+
 #define PRINTED_GUID_BUFFER_SIZE  37  // including null-termination
 
+#ifdef PATH_MAX
+#define MAX_LONG_FILE_PATH PATH_MAX
+#else
 #define MAX_LONG_FILE_PATH 500
+#endif
 
 #define MAX_UINT64 ((UINT64)0xFFFFFFFFFFFFFFFFULL)  #define MAX_UINT32 ((UINT32)0xFFFFFFFF)
--
2.27.0.windows.1








  parent reply	other threads:[~2021-01-06  3:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  2:19 [PATCH] BaseTools/CommonLib.h: Build failed due to MAX_LONG_FILE_PATH Enze Zhu
2020-12-18 11:09 ` Bob Feng
     [not found] ` <1651CB07AB6014B1.25767@groups.io>
2021-01-06  3:07   ` Bob Feng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-12-16  6:29 Enze Zhu
2020-12-16  7:17 ` [edk2-devel] " Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4073E64909C3FB454CC5462DC9D00@DM6PR11MB4073.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox