From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.33378.1608515300586193273 for ; Sun, 20 Dec 2020 17:48:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dhqVBi48; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: bob.c.feng@intel.com) IronPort-SDR: iC7qq5rAjCcLkZN1ZadbI1Yufc1vPDRuraLbUN+wd27cskXzuM0w280qpP98kUxzrXgGEsZK7O g/sVSW0JOR7w== X-IronPort-AV: E=McAfee;i="6000,8403,9841"; a="194090830" X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="194090830" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2020 17:48:19 -0800 IronPort-SDR: MOS7r6HP7GJj+GVTxsYCJ7VTD6w1UC62U/SnwxD87OdkdqNmiIt8pLB0p4OFnKWRBgkfDSVJa9 aLm1yS1QEsJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,436,1599548400"; d="scan'208";a="388566261" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 20 Dec 2020 17:48:19 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Dec 2020 17:48:18 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Dec 2020 17:48:18 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 20 Dec 2020 17:48:18 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 20 Dec 2020 17:48:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bnitD4OGAAHxrnnHoosgnIeh93Iu9nohpnfxLkdoarPkFhILekwbYsEqfwkZ2jR2y60a9ZQsrTGe7V0kYKtEMSt+lHiV6Hd0qX9S41xu6MI+AIfsAE68OcTq96tpcZa8luxVZhmM19JKCux3lzAAMzwu1LXQ6EDYp9S98eZR3bUyG/K46pIelxN9L+/Bwzu6+DBsUOaWDlDZg+S5uKVsvrxSJ4iBg3mYXt8kbHPIbcLk4vpA1M9SyflRBbgj9NbLdDcxHU2p5AVQt1tE3jX9OsgcE9oUEGkGJglG6oKm0ZH+QDwamgTHG6acdXPvnfMmnXHgwnANlGKWFwGxfIA8OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEQnkDP7/4/OqaAxQBUzLd/WhgpIIhgVN3umlqr+cM8=; b=KR7kw3f1gjNzQbKNrjWQvk3gNHsNV9KUuhu/ntV46s+WE+mGf0ZLkASDaXEJ0QVdxpzNaErEiSMU5pX7xLtVBQrvrwxiwxkQPU++vJ5+ChvgmGUrZ3KpWjHu4eR1JPtxKlcE2Sr+WUW+okBrKXtWT3eCIVRsP4ImqjEy0P4oCEG20BHy4WcVoz8RcSHSoEE61zmV56+686VA3egIMhApQPelMme/z6Oe7Csn4dzQunD39QXaJEQScMATwuDGXfHjRq5ndnU7MwSm3842NWVCjzGeplh+ZL5Ijr9owvkHHr+uAcPVFFBiQFT3hQnLXjAlAODE6Z8MeojoHj/9V5jctQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEQnkDP7/4/OqaAxQBUzLd/WhgpIIhgVN3umlqr+cM8=; b=dhqVBi48ekQE89UzJCc1kz5UQRewrbLmmpvaGNktyKrDJqqzudClnMouJSSLTcxuJ+x+DRmrHS4Cr3S6RNGvHPGm1VnI/TlWH4vsIgFFXafMB3ha+f+iC7cT3rVLCorlGQNnZINyDyl7s1dxbPeVbGYZ/T83h3wz/akheIqdQTk= Received: from DM6PR11MB4073.namprd11.prod.outlook.com (2603:10b6:5:19f::22) by DM6PR11MB4346.namprd11.prod.outlook.com (2603:10b6:5:1dd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.21; Mon, 21 Dec 2020 01:48:11 +0000 Received: from DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb]) by DM6PR11MB4073.namprd11.prod.outlook.com ([fe80::c9f:47ea:6321:5ccb%3]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 01:48:11 +0000 From: "Bob Feng" To: Yunhua Feng , "devel@edk2.groups.io" CC: Liming Gao , "Chen, Christine" Subject: Re: [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Thread-Topic: [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Thread-Index: AQHW1BFwqnbJn+hn8k+hoU+8QP9ET6oAzmZg Date: Mon, 21 Dec 2020 01:48:11 +0000 Message-ID: References: <20201217010951.2098-1-fengyunhua@byosoft.com.cn> In-Reply-To: <20201217010951.2098-1-fengyunhua@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: byosoft.com.cn; dkim=none (message not signed) header.d=none;byosoft.com.cn; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4dad6357-70ab-48cf-1d6f-08d8a552793c x-ms-traffictypediagnostic: DM6PR11MB4346: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OH5Hv+daplZKUBvCSsE+2cGQkcWtM0luwG3AfiEjIJM1RLIwqPps4FUe0m2rDJ7OZYtChMUhKONENsXNnp+Pd64whE0GNzntZ5iNY5evvbw9x4j7iVpERT3bX+7ln20bEBkIV7mAxuRw4IjOb4eHwmelSxWxSPqArd5i6xJq0MGA5b868q+lgLNeGerHhtxu737Bdwh05Km4U1QoqimKlUf/7jXE59eAjVy19xcHxHx0rs7imvjMlVfwAuzm118OzHr0T0xkUJg5kg18ZenEqbVZp4m4xXN3ot4KuC3lW9IbfnduZGKPhvXUl90phQUl9QFeBt9gxsKBa3yvlKnGCqvo7tP/vcMEm6XmO79XdgEzCyZACx0YoVhIfLqABKXLdo84JWM75tB6zheFch3zaw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(346002)(366004)(376002)(83380400001)(64756008)(71200400001)(66446008)(53546011)(76116006)(316002)(110136005)(26005)(33656002)(66476007)(5660300002)(55016002)(186003)(8936002)(7696005)(6506007)(54906003)(66556008)(2906002)(107886003)(9686003)(8676002)(86362001)(52536014)(4326008)(478600001)(66946007)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CsP4CJCeKNlBfinjpPQU1A5zUE0DzMP9nNDH5E/fZa5dwgwlWIfFe6oH0kDX?= =?us-ascii?Q?c5CMo+NNgdqKSIfsBg3m5Fc6dhls2VPNJ39rZyupQNMegFdNIStnWETZhCzL?= =?us-ascii?Q?js6DTcfAth6HTAL5za7TzbrL7Qf6Nm5t9mMBgHhu2yBd4GFqLrG42s722jH5?= =?us-ascii?Q?UDTm0+J4o5Vh9scFR/cXN2+atHoE4N1EcbiXh1IfvAMN7Y/SpfD6lun4N3FR?= =?us-ascii?Q?GTIBUiqet5Ya2rR2TpucTupqUpgxdV+1aVGJluOiA07f9aBsnYgCuBPuxxG2?= =?us-ascii?Q?v+0yeMbs9QoT7jD2++diStrgO1fng3I/8sqsUEhFn2ZWYFW7Sx4xdiRJqfKM?= =?us-ascii?Q?rVs1jUKK+m5sbkMKtGeWf3IVPwX9mYpA2b6t9/t+ifItEh+zb8yy9S2sa5FZ?= =?us-ascii?Q?NoNJm0r6HGZfO8EYT2oidNM1y5vdQifpvrQDI+e0GyROlocZd+zXWG+Rlivu?= =?us-ascii?Q?0YiVSXnW83Y1fHm1Bj4VyKEOIk1f+nf8/lK+WBCDh1cxfTrEisVWCf60AAXK?= =?us-ascii?Q?pZIAaqZPHIchb//y1gKdSLc2D5pspPM1WNlsC63g3JzgBXCdKXODR/GMv2du?= =?us-ascii?Q?AWcluEORKU+QaR2HG4lIAwtDb0E5fYowvM9J5xdCkkqNrLcnhNsNkQXYE3A7?= =?us-ascii?Q?rG2Sjk7IyJxapdXHee+hnuLKLJsJDZKW2QYx0PNGJTSugVol/qt+jjpmEiI8?= =?us-ascii?Q?JvNzDs52KOJk3ZR2ecDfkOyfsodZEl82h6LqfRQ+uYSDc2XNeRux3HLbBNw3?= =?us-ascii?Q?HJBt6PIXvCL9fOBrUg9Z5a94yaDgz9aEsqP6abd8RPnBtZLOq/A1O+3JSsgd?= =?us-ascii?Q?WS+ohxfbu93ktq18tt4ah/Vx0hhoMD2lrYtqAQhmj01y+mA9eqk/4Wnwudej?= =?us-ascii?Q?Lhh7QAkbARXd3jahJGJNFXWDbxOx8frNfTAbPATIXcBWuNViDTSkrBzQs1qC?= =?us-ascii?Q?eqRM9O1ckWpRkexxQzopSGp+7OodIV4iyDFKQjwbsLg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dad6357-70ab-48cf-1d6f-08d8a552793c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2020 01:48:11.1669 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kgT/IW83vs2InE1CyVyZaZyELucI4FK5QxJpP043rz/BXNHLx6q7qQ4X6icLCmPjAkDrTjMQk/u+ZkDOcJ0SJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4346 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Yunhua Feng =20 Sent: Thursday, December 17, 2020 9:10 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero= for static PCD REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3120 FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN. Their PCD TOKEN value can always be zero. AutoGen.h will not be changed when static PCD is added or removed. Dynamic PCD add or remove will still cause dynamic PCD token value be chang= ed. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py b/BaseTools= /Source/Python/AutoGen/PlatformAutoGen.py index c001828937..7d8e7b3c7c 100644 --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py @@ -1037,8 +1037,7 @@ class PlatformAutoGen(AutoGen): TokenNumber +=3D 1 =20 for Pcd in self.NonDynamicPcdList: - RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =3D TokenNumbe= r - TokenNumber +=3D 1 + RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =3D 0 return RetVal =20 @cached_property -- 2.27.0.windows.1