Re: [edk2-devel] CI test on copyright

["Bob Feng" <bob.c.feng@intel.com>]

Yes.

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com> 
Sent: Monday, October 19, 2020 10:48 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; spbrogan@outlook.com; shenglei.zhang@intel.com
Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan' <sean.brogan@microsoft.com>
Subject: RE: [edk2-devel] CI test on copyright

Hi Bob,
So the fix was only applied on c and h file as your mentioned? If so then we need a BZ to add the same rule on the files other then c and h.

Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of 
> Bob Feng
> Sent: Monday, October 19, 2020 10:25 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 
> spbrogan@outlook.com; shenglei.zhang@intel.com; Chang, Abner (HPS 
> SW/FW Technologist) <abner.chang@hpe.com>
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: Re: [edk2-devel] CI test on copyright
> 
> For the .c and .h, ECC add the rule to allow (C) Copyright format.
> Looks this bug was not fixed completely.
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D2057&d=DwIGaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulk
> skz6qU3NYRO03nHp9P7Z5q59A3E&m=oWYb80tvgLGP9RZPAmJdv9pqtmSQb
> DbP1z9tdxINhI0&s=KduVFX0xp_qOfbmCqcRhYJ1r-19xwoTA6V4-
> mbW5cF4&e=
> 
> Need file a new Bugzilla and fix this issue.
> 
> Thanks,
> Bob
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, October 19, 2020 9:28 AM
> To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io; 
> spbrogan@outlook.com; shenglei.zhang@intel.com; abner.chang@hpe.com
> Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>
> Subject: 回复: [edk2-devel] CI test on copyright
> 
> Bob:
>   Now, the problem is the inconsistent behavior. The same copyright 
> style ((C) Copyright 2020 Hewlett Packard Enterprise Development LP ) 
> in .c can pass ECC, but in .inf file can't pass ECC. I want to know the reason.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Feng, Bob C <bob.c.feng@intel.com>
> > 发送时间: 2020年10月19日 9:25
> > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 
> > spbrogan@outlook.com; shenglei.zhang@intel.com;
> abner.chang@hpe.com
> > 抄送: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > 主题: RE: [edk2-devel] CI test on copyright
> >
> > In the ECC, the rule to check Copyright is to see if the Copyright 
> > is the first word of a line, and the Copyright should be followed by 
> > a (
> >
> > Liming, for your reference, the code in ECC
> >
> > ## _IsCopyrightLine
> > # check whether current line is copyright line, the criteria is 
> > whether there is case insensitive keyword "Copyright"
> > # followed by zero or more white space characters followed by a "("
> > character # # @param LineContent:  the line need to be checked #
> > @return: True if current line is copyright line, False else #
> >
> > -Bob
> >
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> > gaoliming
> > Sent: Monday, October 19, 2020 9:01 AM
> > To: devel@edk2.groups.io; spbrogan@outlook.com; 
> > shenglei.zhang@intel.com; abner.chang@hpe.com
> > Cc: 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; 'Sean Brogan'
> > <sean.brogan@microsoft.com>
> > Subject: 回复: [edk2-devel] CI test on copyright
> >
> > I will check this issue first.
> >
> > Thanks
> > Liming
> >
> > > -----邮件原件-----
> > > 发件人: bounce+27952+66349+4905953+8761045@groups.io
> > > <bounce+27952+66349+4905953+8761045@groups.io> 代表 Sean
> > > 发送时间: 2020年10月17日 12:46
> > > 收件人: devel@edk2.groups.io; shenglei.zhang@intel.com; 
> > > abner.chang@hpe.com
> > > 抄送: Bret Barkelew <Bret.Barkelew@microsoft.com>; Sean Brogan 
> > > <sean.brogan@microsoft.com>
> > > 主题: Re: [edk2-devel] CI test on copyright
> > >
> > > ECC stuff was done by Intel. I would defer to them.
> > >
> > > Adding shenglei.zhang@intel.com
> > >
> > > On 10/15/2020 9:21 AM, Abner Chang wrote:
> > > > Hi Sean and Bret,
> > > > I got the CI test error which says the first line in file header 
> > > > section
> > must
> > > have the copyright information, however the copyright is there and 
> > > looks
> > to
> > > me fine as below,
> > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > >
> > > > [cid:image001.png@01D6A351.31688460]
> > > >
> > > >
> > > > The interesting part is CI seems happy with below format of 
> > > > copyright,
> > and
> > > this issue only happens on INF file but not on the *.c and *.h.
> > > > Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>
> > > >
> > > > Any idea on this?
> > > > Abner
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
>