public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
@ 2020-12-02 18:41 Wadhawan, Divneil R
  2020-12-02 19:35 ` Michael D Kinney
  0 siblings, 1 reply; 2+ messages in thread
From: Wadhawan, Divneil R @ 2020-12-02 18:41 UTC (permalink / raw)
  To: devel@edk2.groups.io
  Cc: Kinney, Michael D, Bret.Barkelew@microsoft.com, Sean Brogan,
	Wadhawan, Divneil R

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]


o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
  required in building of MdeModulePkg

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>

Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
---
UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
index 96e40e973c..0dabd6a6f3 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
@@ -12,7 +12,7 @@
   FILE_GUID       = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
   VERSION_STRING  = 1.0
   MODULE_TYPE     = UEFI_DRIVER
-  LIBRARY_CLASS   = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
+  LIBRARY_CLASS   = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_DRIVER UEFI_APPLICATION
 [Sources]
   UnitTestLib.c
--
2.16.2.windows.1

[-- Attachment #2: Type: text/html, Size: 3782 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] [PATCH] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib
  2020-12-02 18:41 [edk2-devel] [PATCH] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib Wadhawan, Divneil R
@ 2020-12-02 19:35 ` Michael D Kinney
  0 siblings, 0 replies; 2+ messages in thread
From: Michael D Kinney @ 2020-12-02 19:35 UTC (permalink / raw)
  To: Wadhawan, Divneil R, devel@edk2.groups.io, Kinney, Michael D
  Cc: Bret.Barkelew@microsoft.com, Sean Brogan

[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Thanks,

Mike

From: Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>
Sent: Wednesday, December 2, 2020 10:41 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Bret.Barkelew@microsoft.com; Sean Brogan <sean.brogan@microsoft.com>; Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>
Subject: [edk2-devel] [PATCH] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib


o LIBRARY_CLASS for UnitTestLib has been extended to support the classes
  required in building of MdeModulePkg

Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>

Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com<mailto:divneil.r.wadhawan@intel.com>>
---
UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
index 96e40e973c..0dabd6a6f3 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.inf
@@ -12,7 +12,7 @@
   FILE_GUID       = 98CEF9CA-15CE-40A3-ADE8-C299953CD0F6
   VERSION_STRING  = 1.0
   MODULE_TYPE     = UEFI_DRIVER
-  LIBRARY_CLASS   = UnitTestLib|PEIM DXE_DRIVER DXE_SMM_DRIVER UEFI_DRIVER UEFI_APPLICATION
+  LIBRARY_CLASS   = UnitTestLib|PEI_CORE PEIM DXE_CORE MM_STANDALONE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_DRIVER UEFI_APPLICATION

 [Sources]
   UnitTestLib.c
--
2.16.2.windows.1

[-- Attachment #2: Type: text/html, Size: 41765 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-02 19:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-02 18:41 [edk2-devel] [PATCH] UnitTestFrameworkPg: Fix build failure of MdeModulePkg with UnitTestLib Wadhawan, Divneil R
2020-12-02 19:35 ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox