[PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

[PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

[Wadhawan, Divneil R]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]


o Recently, OpensslLib [LibraryClasses] has been changed
  to include RngLib which causes the SECURE_BOOT_ENABLE
  build to fail in want of RngLib

o This patch adds the RngLib for OpensslLib

Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
---
EmulatorPkg/EmulatorPkg.dsc | 1 +
1 file changed, 1 insertion(+)

diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index c6e25c745e..a27cb1beb0 100644
--- a/EmulatorPkg/EmulatorPkg.dsc
+++ b/EmulatorPkg/EmulatorPkg.dsc
@@ -113,6 +113,7 @@
   FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
 !if $(SECURE_BOOT_ENABLE) == TRUE
+  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
   IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
   PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
--
2.16.2.windows.1

[-- Attachment #2: Type: text/html, Size: 3394 bytes --]

Re: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

[Matthew Carlson]

[-- Attachment #1: Type: text/plain, Size: 50 bytes --]

Thanks for catching this!
--
- Matthew Carlson

[-- Attachment #2: Type: text/html, Size: 59 bytes --]

Re: [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

[Samer El-Haj-Mahmoud]

Divneil,

Thanks for this patch.

However, it looks like multiple edk2-platforms are broken because of the OpensslLib change. I verified at least the following are broken:
- RaspberryPi/RPi3
- RaspberryPi/RPi4
- Qemu/SbsaQemu
- Socionext/DeveloperBox
- SolidRun/Armada80x0McBin
- Hisilicon/D0*
Etc.. Others are probably impacted. A quick search across edk2 and edk2-platform shows openssllib used in 26 DSC files, but RngLib is implicitly used in only 13 of them.

Mathew,

I think the offending commit (b5701a4c7a0fb185e0c5b9db9525939c78664bfd) needs to be reverted, and re-submitted with a series that fixes the build for all impacted platforms.

Also, what would it take to add the Azure pipeline CI that is currently used in edk2 to edk2-platform? I imagine some platform maintainers would appreciate that capability. Or should every platform look for their own CI/CD (possibly outside TianoCore)?

Thanks,
--Samer


From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wadhawan, Divneil R via groups.io
Sent: Saturday, September 19, 2020 1:39 AM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; 'Andrew Fish' <afish@apple.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Wadhawan, Divneil R <divneil.r.wadhawan@intel.com>
Subject: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib


o Recently, OpensslLib [LibraryClasses] has been changed
  to include RngLib which causes the SECURE_BOOT_ENABLE
  build to fail in want of RngLib

o This patch adds the RngLib for OpensslLib

Signed-off-by: Divneil Rai Wadhawan <mailto:divneil.r.wadhawan@intel.com>
---
EmulatorPkg/EmulatorPkg.dsc | 1 +
1 file changed, 1 insertion(+)

diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index c6e25c745e..a27cb1beb0 100644
--- a/EmulatorPkg/EmulatorPkg.dsc
+++ b/EmulatorPkg/EmulatorPkg.dsc
@@ -113,6 +113,7 @@
   FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf

 !if $(SECURE_BOOT_ENABLE) == TRUE
+  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
   IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
   OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
   PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
--
2.16.2.windows.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

[Matthew Carlson]

[-- Attachment #1: Type: text/html, Size: 13787 bytes --]

Re: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib

[Sean]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

This seems like a big enough "platform" difference that we should be testing in platform ci.

To do that you would need to add another item in the matrix here

https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L26

and here:
https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml#L25

An example in OVMF of how this is done is here
https://github.com/tianocore/edk2/blob/master/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L95

[-- Attachment #2: Type: text/html, Size: 993 bytes --]