From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last block value
Date: Mon, 13 Jul 2020 07:19:42 +0000 [thread overview]
Message-ID: <DM6PR11MB4425427B68E4B552CA3CFD9CF6600@DM6PR11MB4425.namprd11.prod.outlook.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C611468@SHSMSX104.ccr.corp.intel.com>
Sure. I would follow the 3 suggestion in next version patch set.
Thanks,
Zhichao
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Monday, July 13, 2020 1:59 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: RE: [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last
> block value
>
> 1. Can you rename LastBlock to LastSector and remove the MediaSize local
> variable?
> 2. Can you add comments to describe that sector size is 512?
> 3. Can you explain why this fix is needed in the commit message?
>
> Thanks,
> Ray
>
>
>
> > -----Original Message-----
> > From: Gao, Zhichao <zhichao.gao@intel.com>
> > Sent: Wednesday, July 8, 2020 10:27 AM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Laszlo
> > Ersek <lersek@redhat.com>
> > Subject: [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Correct the MBR
> > last block value
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823
> >
> > The MBR last block value should be sector (512 bytes) numbers.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> > MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
> > b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
> > index dac451a144..aa0b6cadcc 100644
> > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
> > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c
> > @@ -137,12 +137,14 @@ PartitionInstallMbrChildHandles (
> > UINT32 MediaId;
> > EFI_LBA LastBlock;
> > EFI_PARTITION_INFO_PROTOCOL PartitionInfo;
> > + UINT64 MediaSize;
> >
> > Found = EFI_NOT_FOUND;
> >
> > BlockSize = BlockIo->Media->BlockSize;
> > MediaId = BlockIo->Media->MediaId;
> > - LastBlock = BlockIo->Media->LastBlock;
> > + MediaSize = MultU64x32 (BlockIo->Media->LastBlock + 1, BlockSize);
> > + LastBlock = DivU64x32 (MediaSize, 512) - 1;
> >
> > //
> > // Ensure the block size can hold the MBR
> > --
> > 2.21.0.windows.1
>
next prev parent reply other threads:[~2020-07-13 7:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 2:27 [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Gao, Zhichao
2020-07-08 2:27 ` [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last block value Gao, Zhichao
2020-07-13 5:58 ` Ni, Ray
2020-07-13 7:19 ` Gao, Zhichao [this message]
2020-07-08 2:27 ` [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM Gao, Zhichao
2020-07-13 6:44 ` Ni, Ray
2020-07-13 8:14 ` Gao, Zhichao
2020-07-08 2:27 ` [PATCH V2 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Gao, Zhichao
2020-07-08 15:59 ` [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Laszlo Ersek
2020-07-09 5:03 ` Wu, Hao A
2020-07-10 0:40 ` Gao, Zhichao
2020-07-10 0:50 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4425427B68E4B552CA3CFD9CF6600@DM6PR11MB4425.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox