From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.1156.1594341653392572521 for ; Thu, 09 Jul 2020 17:40:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=y6GuFEZY; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) IronPort-SDR: xcp01HtD5pPvvsOF6QzF3fkjtsEH5zZIrfR8s8+cQ3dBxaUDnaQv3/n9ScJo9DbHl3ulc03a2y T8r6vdJy4kdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9677"; a="148118933" X-IronPort-AV: E=Sophos;i="5.75,332,1589266800"; d="scan'208";a="148118933" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 17:40:52 -0700 IronPort-SDR: a/U13JeYKviyL6+NUPG5sDrefY+jOCU7asEY4McUsV8ppWxaKk5N+1acpNnnrkw+Go/uMb/e5Z t/tf01bxVCHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,332,1589266800"; d="scan'208";a="483993273" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga006.fm.intel.com with ESMTP; 09 Jul 2020 17:40:52 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 17:40:52 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 17:40:51 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jul 2020 17:40:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i9vJyFKfpbZuNQRJxtiHOJJu7APf27PMf4toN9yWb9Q22EedeTiXrJ+aqvzTU41FnAPYyszpJaNL51bk6RfLG8eTCOOyWiuB0ksqnc09wzSxuO9k1ZpL063G/lXuJGzTBJo3oZKNnDux4w3lBIQRLKaDSAJjxYLr8fnCxaEYnhtPrI3FuLl05Da+0KCBusX3OzwTgPmcuoR1Kil/o4tsIuJGSl8pwydQmFwejJtLQNa/cJIHLpDrI8rSHcIkrEfl4yiogysdT9Chx9E0IPjTaFjd+ez2oFaoZKSb6VRNBA1W7Qfvq/PfztyPrzUO+AHBeVDczyo+L5VpKOmIQ6o5/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZQvuxLJjGlDJ2ahazC/kQtJ/VsNgphGkGn/jTgvGAk=; b=ClolGRW8dSYXW8S/IbYAWZUfTmHHs6qtU4NScyqvQdh54NquLogRnqa1nFgSsRbbYEy3rTsDSJIcTdIEHgEXbr/SZpkG55IcPh1faIHv5lULKj9ph1rlP4OS//NMoSh3KiJpGIHKuUbwo/4IbjwlJCEBeuyoHUEHKUzHhtOXcqNMmtWKcqqgYlTAMcynPdw656CKE37eJLSC7EBIpevtIFp3XPqy89axcm7OchcGYleI4r04EO+MgPGNHXNYxmTPpyMc7hORhedFbDMS3IuclmOOFuC9911sKcjLXPkUKkHjHmrP/0du1I6iC4kcyeGAIOdF+USaXzjfL1y9FKSalA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZQvuxLJjGlDJ2ahazC/kQtJ/VsNgphGkGn/jTgvGAk=; b=y6GuFEZYlQ92Ss6vyBfuFV+W+Spf/uZBCc6pg3YsndCRFdSp8bxBs4GksD7q8dWqlOc0hakWa7PefRjp9nvzeHIL0aaLe/JV6KfmOr6rBDqMrMJtHjpNlAtJfvzskHa97LcRclPj+lQfkf6JMOHE5xJoRy31G0iIAsf8e2Rfcsk= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM5PR11MB1658.namprd11.prod.outlook.com (2603:10b6:4:8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Fri, 10 Jul 2020 00:40:50 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3174.023; Fri, 10 Jul 2020 00:40:50 +0000 From: "Gao, Zhichao" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Thread-Topic: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue Thread-Index: AQHWVM9bZUG9RYw4fESc7hTO7Ljd/6j+srhQgABGxkA= Date: Fri, 10 Jul 2020 00:40:50 +0000 Message-ID: References: <20200708022722.27024-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4dfc26e-53ad-4bde-50db-08d82469e4ee x-ms-traffictypediagnostic: DM5PR11MB1658: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HrxLGH/tPR6ZXnMu4O+I0eANJEaTWF7VqxpArMC9euobRlzMJ1NLW4WOA5Rk75SDLT4/4kFv2Hub770EU+FC8AfH70a3YDqR9a+nVPK37GKhtgtezgrkJ6Ynbr5xJkxmI7TkpyOTr+bBJAU/jNOIPd5/gjT307SVHvh0cU2jQqtqQtP9v2e3we3tqRTOTAQZbK6OtIcRTLS0MWlYHM42hpBodCRoGGqrF0UtieOqBVU8PnAn636DU3wiegZhzHNLZOlHTtcQGwPE6Pnb9k2fiWUoBHpQo8qU+JznZm9bxUBj7f3qmsyDFeNv6Yj3H9BH5dPzsoewiSENffOW8vGgsia6f0nawAPAasSVnHjxMFE5hjJ+uxg3lgyMh/pYy6m91SnZJiv9Hmkd0grn1uRwKQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(7696005)(2906002)(8676002)(4326008)(83380400001)(8936002)(9686003)(55016002)(71200400001)(6506007)(53546011)(110136005)(26005)(66476007)(478600001)(5660300002)(76116006)(186003)(86362001)(316002)(66946007)(966005)(64756008)(52536014)(66446008)(54906003)(66556008)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 44vKxedig9c8QFIFFLjjGbDMriVV/IsI22rrk+k537kvGI86gqpebsz3R6HFVQ4RYk+fphwQNOQklBwdmRvtZYpopgOvUSZimMmCELlBlQbOLKm/mTb7uAxBQGUfxYetJCawobwDzmsKMIR/lCy9/P0U4xjNcIhvJuflaYcHj22nsy2weNrWyqX8j0fw9bl2nBFctQCPzQDiDxO5yZWJe6PhCFFnrgykQDctPD10lK6dMpjPIKwnevNxvXtrHZafy2grfCPBQjwSFd/pix3Z6Q1acyMgBElcU7J9peBYctwSKxzdokZtnWGszOQKVh9c8W7M1UhUTh2GnCrX+US+kyNqATN91FIXZLroimnH6Rwy5vOvpvvs/uLBrPnOM+jiOjIXEnI7+UYE+e7Wj1dattA3AhIpALV7epaN8kWKmXBTF1L394qne4Xki/18LO32lRe+Jv6QJWRQZYckIpL4YFHtX5/v/iSat5Cc2asJRnOY5VEyQ/VVY+YoyPQS2IKZ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4425.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4dfc26e-53ad-4bde-50db-08d82469e4ee X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2020 00:40:50.2635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1mRLEGWAqKasILx8FtSj8btzUxEqaM7iszpY0i4p1Bx0XS53EDjnftCBGO2Uc3iHcueNBfYqFtej5u2J4wrh8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1658 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have tested on the OVMF with linux iso image like Ubuntu, Fedora and RedH= at. It can enumerate under the shell and load the grub efi application. Thanks, Zhichao > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, July 9, 2020 1:04 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition = check > issue >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Wednesday, July 8, 2020 10:27 AM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A ; Ni, Ray ; Laszlo > > Ersek > > Subject: [PATCH V2 0/3] MdeModulePkg/PartitionDxe: Fix the partition > > check issue > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 > > > > V1: > > Separate the UDF from the partition rountine array and do the check > > for every media. > > > > V2: > > Drop V1 because it is a bug: there should not be two partition types > > in one media. > > 1. Correct the LastBlock value in MBR handler. It should be the number > > of sectors (512 bytes). > > 2. Skip the MBR check if the MBR is added for the Windows > > comaptiblity. We treat such media as ElTorito and do the check. > > 3. Fix the partition check bug: One partition type returns already > > started should be treated as success to avoid multi partition type be > > installed into same media. >=20 >=20 > Hello Zhichao, >=20 > The changes look good to me. > May I know what tests have been done for the series? Thanks. >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Laszlo Ersek > > Signed-off-by: Zhichao Gao > > > > Zhichao Gao (3): > > MdeModulePkg/PartitionDxe: Correct the MBR last block value > > MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM > > MdeModulePkg/PartitionDxe: Add already start check for child hanldes > > > > .../Universal/Disk/PartitionDxe/Mbr.c | 42 +++++++++++++++---- > > .../Universal/Disk/PartitionDxe/Partition.c | 9 ++++ > > 2 files changed, 44 insertions(+), 7 deletions(-) > > > > -- > > 2.21.0.windows.1