Re: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM

["Gao, Zhichao" <zhichao.gao@intel.com>]

> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Monday, July 13, 2020 2:45 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: RE: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add
> for CD-ROM
> 
> > +    //
> > +    // If the MBR with partition entry contains itself, i.e. start with LBA0,
> > +    // and have the same size with the media, we treat it as a El Torito partition.
> > +    //
> > +    if ((StartingLBA == 0) &&
> > +        (SizeInLBA != 0) &&
> 1. Can this check "SizeInLBA != 0" be removed?

Yes. I don't think the LastLBA would be the max UINT64 value. So we can remove this condition.

> 
> > +      DEBUG ((DEBUG_INFO, "PartitionValidMbr: The MBR table has partition
> > entry start at sector 0.\n"));
> 2. Can the debug message be refined as below?
> " PartitionValidMbr: MBR table has partition entry covering the ENTIRE disk.
> Don't treat it as a valid MBR."

Sure. Your suggestion make the change more clear. I would change this in the comment of the section as well.

Thanks,
Zhichao