From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.15038.1594628087047979408 for ; Mon, 13 Jul 2020 01:14:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=knOvkMCt; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) IronPort-SDR: cide4yKw7S65rgsOox7FcnXVAo1ieO/E2DA2z3U5p4n9WCak41DwQELClNAv9oH8Kf+ii82Xgi IaBPz67dlBjA== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="148572125" X-IronPort-AV: E=Sophos;i="5.75,346,1589266800"; d="scan'208";a="148572125" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 01:14:46 -0700 IronPort-SDR: kKL4IsF/hUESfTuvJSQ0OGoDbJjJoYLlETfM3T9omiz1kURXUcMm1/S2pHsxD3TAoTKXOI1XsL X+wB8NdylC0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,346,1589266800"; d="scan'208";a="268308177" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 13 Jul 2020 01:14:46 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 01:14:45 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 01:14:45 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 01:14:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sg8ST04PuNyok5UCxK3JrCiR3gne77FJmS2VomMto6zRP5eCZezZMIWA9OrgB4ATnT0IC89JQZWmIPc+dTgWx1M3T+zvpMs2lZt+20IY28zEN3Uf1UvYiXYA8GM8sewVssDiAejc+iTVTBpxpFvYN/1xRxU813WRNWLcEJ8bgVvGQbWQfQERWlgAGcmzL7QcEq4tULj6e0yDGpWhNrW1CLHgVmXubyNvX1ZMs88gkQGk95WKiLx5uR9LlOdeNaIWR5m/KScBYaouLe2DC2KLyt1IgZIBcU3LhwlxlMZVV4vOGXLYqlp8/WKT5dji17zSCI0Oy9NOPaHgJblBdCp5Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wlhz4uf/Ga97XVV5+Z/OeOSDH3anAjrxj8D6Bnf/9SQ=; b=mi+8J7tDoYBcgpeV4F4CB6ke+gxYa5XnE+tRSpTy6wWIqu/qCG7oj2nGr0/TCCfXD7YUGylEN/nP/125EYnC7wz0wBprlINOg5n/SvbQfhk1I3CUbLRjF0BbWkc+Ar6dlHCsBihl3Cd1xHlTR3ozjPZPlFzOfQoB6rRvHLTvT0hLEh0EABVmJz2I/1+Gtx3N+QZWu6Cn/gAXZZpN4bREtNn8a5b8LxVyRHZfzSUj2N5BhgmOx6TBaEl0nAj2UM3d36TTaNaLWE/znZ4AhCZajQBnvRSvEebyxo/+Wd4w8f/bEgAkXjQkYkwBm4E4wbTinWOgzzQDOqU+7IdmXSI9hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wlhz4uf/Ga97XVV5+Z/OeOSDH3anAjrxj8D6Bnf/9SQ=; b=knOvkMCtETRPupPWieIJnSGNq/jKbYX9xStidS+X3E0eQAmFX25hT3vF/F4pQjs1WTO35lHWc184TjH08T2G+J/QvHW3ZusFRwuOqvf7Cmiyw7RkUEM1W+zuHcE92tZRb1cVLhWFCUaFub/DbGTzX1L0svgsdykEo7OVMI0mXPE= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB3210.namprd11.prod.outlook.com (2603:10b6:5:e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Mon, 13 Jul 2020 08:14:30 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 08:14:30 +0000 From: "Gao, Zhichao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wu, Hao A" , Laszlo Ersek Subject: Re: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM Thread-Topic: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM Thread-Index: AQHWVM9XSINU2oIp/U6zZobkQzBNrqkFDAXQgAAWTxA= Date: Mon, 13 Jul 2020 08:14:30 +0000 Message-ID: References: <20200708022722.27024-1-zhichao.gao@intel.com> <20200708022722.27024-3-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C611527@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C611527@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9614e54-a016-438f-f789-08d82704c488 x-ms-traffictypediagnostic: DM6PR11MB3210: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4t8dBnCyEXwBuTrClGNPB8sK5G5cCyvH8en3rpIeTFBKK9E2gh+uvdwh+IAA689MBOw0+jbhhSkMzBFb8Lyy1K9lcMcBOjq/KWhYH2VxytdcX4ahE7r7xFWiEDpAPCUipnakyHHvtnF787nwVsUoLUvTcCIb3nN3fqt+3Uo+6NOpjz7AEzhG9M9q8Uv0AxnoszOJEwi4WRiXOS1rq4ogZFa639+lRxtSt8WxsnEK30NQFBT1ijhAsldfv5A/IbyWIbRWcIO/zX1MaZIX0mfslziKHVWHauBK63vRI67Yv5+wyBFfNR12fNRPS5HBsyfC4KzpO1Pz9x/v9WSJYpjWpw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(478600001)(26005)(83380400001)(71200400001)(7696005)(5660300002)(8676002)(54906003)(33656002)(6506007)(76116006)(53546011)(8936002)(86362001)(66476007)(64756008)(66946007)(66446008)(52536014)(110136005)(55016002)(66556008)(9686003)(316002)(2906002)(4326008)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: qrVnwL2YTchFnX0DGH+5wHzgAVf7mLqds9uVXS94xJg218B2+cporubglqgrApEAlTl6RS5Mwz+0hC3pAJXuMKtCKP75hLK4NJyHxSmXCi7lWr9qum/iZ11TATPm6lk5/e4LGtzvTNAfPmtHUp6KEzceEFGDZQTl0ntV+B52tUa8LGZNXo0A+nIy3iyX1L6T3qe7rfdous0ZaseTyxj7fx3mKPp94DlCkeHu8VRhwb/y+YcZUIxdp/rzzZs9oR+vkx4zlEwxg48GgLTCNGOVAHP52C159TpniauKA3ttEWFKNpY0WGXWAvnSljN8od4oNt6an+P4qNBpH6mkCTrQGz2U/p+iJejPYYyEpKPaYaBXQqgO1NzZVI+pwJE9l5B5mWQOhzip5XetE7hWKp4HR5agc+MSIB6RaioyeNZJR/zXi0jusFiJbRyQNy74gYqP6Vclo8GjnES9Za7n67ETNzyxGtTbF2dJ/uakuMGHjYU/YwurcR/oo53IK3bhmEqj MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4425.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9614e54-a016-438f-f789-08d82704c488 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 08:14:30.2548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vXeAgF5gWXOppyiqXPopn3XcskF2RNh/MoeU5POKn9xDGZ1K7EfWUh4mOlxV7ga5hd269kDdWSau4jS8nghdXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3210 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ni, Ray > Sent: Monday, July 13, 2020 2:45 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wu, Hao A ; Laszlo Ersek > Subject: RE: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that = add > for CD-ROM >=20 > > + // > > + // If the MBR with partition entry contains itself, i.e. start wit= h LBA0, > > + // and have the same size with the media, we treat it as a El Tori= to partition. > > + // > > + if ((StartingLBA =3D=3D 0) && > > + (SizeInLBA !=3D 0) && > 1. Can this check "SizeInLBA !=3D 0" be removed? Yes. I don't think the LastLBA would be the max UINT64 value. So we can rem= ove this condition. >=20 > > + DEBUG ((DEBUG_INFO, "PartitionValidMbr: The MBR table has partit= ion > > entry start at sector 0.\n")); > 2. Can the debug message be refined as below? > " PartitionValidMbr: MBR table has partition entry covering the ENTIRE di= sk. > Don't treat it as a valid MBR." Sure. Your suggestion make the change more clear. I would change this in th= e comment of the section as well. Thanks, Zhichao