From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.9482.1592875941961731679 for ; Mon, 22 Jun 2020 18:32:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=zNgBltsJ; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) IronPort-SDR: szetvWNx5Ha9yWm4FGveJkrJBiETQSR+ae9upQy8Unu5YVpU/GEcDoZSUXKDFofo4bZ605ClsI KGg+ONZYFJUw== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="228585721" X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="228585721" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 18:32:20 -0700 IronPort-SDR: 5sAGxwPNZQXFkfFN9J3Dg/bYclbtD29Z3YKkieQ9YZATMS2HVLH44kdt4ZqgGpcN25mLWEExSQ 6MYMlzGB23KA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="319014833" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 22 Jun 2020 18:32:20 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 18:32:19 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 18:32:19 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jun 2020 18:32:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MS7+tdrvOzUeVV22WznBq2UTUTwIwRsdZcugxSdbmqg3jfsEAMaNuLNswQSkesBfhsKia8qJikG9dkX8ycsvXcfp8aMSIvAeJy4xjHEcpTynwJhRUIRXEc1ZfhM4IEVzlPjuoDSnM2iW4amydH6uQ93RqwC5t3I8Ns3oJdj+MJqj0My41VxgFDriV6x6Vg8lH5wG+koujOx5Ut0CprBRDIORGimAOCd0YlZMMnw5qoSLyQ3n7gnytO0lJzGCLFVMOkL+LOgBbfzz04oGPH+QdwYTZeDdaq4CKa50VA93dTeHNsKD8ciCsMn0ZylqCcWHPV9b0lQv0fPrLshBRVYr3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WqwkvdS6cnLLoBY3SgsUiF6aPiwnXSzgwqe9Q04uUc0=; b=k1pQe5UiqZGZHw436a5uEOVVuw3eTmA0NrZil10OY09ZniCVLG8UC6By6nkGeVuSKLiqQRtdBFsDzkSt0cxsqaaMd69v2b7L+mvghhF640wed7uDl23GhhaLI86x8L8KxphJFimHk1TeNIRMc+Lg2mzpu00bdvntONme93KoGx5rSdN6V+F4yVGFwg9dcXOsIxdp3wJbu6RPEmD1eArVgv45h+/DSNTyQX51yFE9OGENHzZvLDtSH2qD9+slseyEFsXOkLTxp6o1J5q6YsULN5tZZsU0JotDASEIcRxr9Vj9jcRdq5zDFJMgOKZV7xmY2vJISDJTatQtB7XGOSjYfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WqwkvdS6cnLLoBY3SgsUiF6aPiwnXSzgwqe9Q04uUc0=; b=zNgBltsJi+fsz4rtZJW90c7HQgoSQikn9YTIAG7s9kEWX1I1mhMXqTOt9irWbx8TfCQFky+UGU5QrkLyDieSDgSNONuLXWwOyhflw8g4dph1HBjhAfvNQfkyOkS3Ij3PKPZC97f95b1LkA7zRXLX0n+Z8Tux06ROWj9wPuGzrLE= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB3212.namprd11.prod.outlook.com (2603:10b6:5:5b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.23; Tue, 23 Jun 2020 01:32:17 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3109.027; Tue, 23 Jun 2020 01:32:17 +0000 From: "Gao, Zhichao" To: Tomas Pilar , "devel@edk2.groups.io" CC: nd , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application Thread-Topic: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application Thread-Index: AQHWQx31wOC2uiqeB0qggQb45YpYkKjkmaYAgADcSNA= Date: Tue, 23 Jun 2020 01:32:17 +0000 Message-ID: References: <20200615140351.1725-1-Tomas.Pilar@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3e3a40b3-4d7f-4e46-935e-08d8171543f2 x-ms-traffictypediagnostic: DM6PR11MB3212: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZGK5Oe2sRmXuS9wlnOak1iI5YeZD93FN7lVVcrxxNTEHFcksYLFQghuUhoS+2pHyAnl6EQEma6VUUgcr5IrriqeNgbkK2f/JPSdopeBZ0N1tZF5WTzzEPxSasW7fwS8inGnVZzoe3bQrls02Wlq8HZRxf8ntsr8YM6YnOYcjsX9hwSm3zxqfrY2FHqCUxOGKbupm3tiUaCCwdo9b+dwE1v3KBFX6gQZHGX497qSbfxrqBfs4sTKAPx8q+YrVdYpdxuhj4Hzq9x3hB0P2HF9D7RNLtpAlcViHDFuldoCQ8ggDpGHlQDMVki9QqpysuU8Pw+I8KPC2SJbKWN9YBkwkavm7rhsJ4ueMy/20c6c9sX7zV2LB4SU/sRkQkLMJycZ0uh9Yo2zCt/AZB7Tm3JUqkg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(396003)(39860400002)(136003)(366004)(346002)(966005)(7696005)(5660300002)(478600001)(4326008)(76116006)(316002)(55016002)(9686003)(110136005)(66946007)(54906003)(186003)(66476007)(66556008)(64756008)(2906002)(66446008)(33656002)(83380400001)(86362001)(26005)(53546011)(6506007)(8936002)(8676002)(107886003)(52536014)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: uTATGFzDjTkl61NrtMLa0oq8BKcbYUEYRTJ7RKc4C7JMevxwhPrUKz3Nb/i+uQVIbUluGA2V0EiyFnGCoGkAvw60A2FG9sKlssBXu4eWzF78wNR5RNRjUQ3bLpTTbzP1tKfDAykDAxKH8ZpnUyGz9Tq1h1Ys1QNIYVmZ6mKMSLBQuUf4NxTGQTLFMSU4ozgsndjhf+VZSvBgHs1/upPXVo8YxJ7VCsMi0Ge7jaja1Y7mF3FCmFeHNaxEYunvzbO4h2UbW9UpwviTYvvCHRJRI/YjSmPcZewbTuWQws9zI8WLNOxiGFT+9rLXayTd8D1zcU+vwpOuO0ovu9wG+IVHNYEfWeLeYd13iWPqDb6BRn+meSnGu13w8JXdQjG7QqKS6pLOa+QpIsiGD2zSvw4+7NxeBLb+wPPuopIMRR43VD7sUACAfX5QfnVKl+hHCUmPvNPNKBoWqH8ozWiZsEMKW4QLdgJieGHbJXc/WBpsiTlU+QSHvPj3+f/CkqnDeY8h MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3e3a40b3-4d7f-4e46-935e-08d8171543f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 01:32:17.3278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dnk77BCnYULRGwaYrH7Xe0m8Zu1YlDW6oC1uTkVa7ct8aIp7PKhWQRmeycJGMnXR3MZg+G/VAioh4AWJvaC1qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3212 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Already give the R-B to the remain patches. Thanks, Zhichao > -----Original Message----- > From: Tomas Pilar > Sent: Monday, June 22, 2020 8:24 PM > To: devel@edk2.groups.io > Cc: nd ; Ni, Ray ; Gao, Zhichao > > Subject: RE: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application >=20 > Hi Ray, Zhichao, >=20 > Do you have any opinions on the respun patches? >=20 > Cheers, > Tom >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Tomas Pil= ar > (tpilar) via groups.io > Sent: 15 June 2020 15:04 > To: devel@edk2.groups.io > Cc: nd ; Ray Ni ; Zhichao Gao > > Subject: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application >=20 > This patchset adds a new application module to the ShellPkg with the > functionality of the 'acpiview' command. >=20 > The existing code is tidied and a clean boundary between the UEFI shell = command > wrapper and the acpiview functionality is created. Then, a new applicati= on > wrapper is added. >=20 > The motivation for a standalone AcpiView application lies in the desire = to test > implementation of the Acpi tables on a wide selection of platforms, part= icularly > platforms still in development, platforms that might have an older > implementation of the UEFI shell or platforms that might not include the > 'acpiview' > command in the internal build of the UEFI shell. Furthermore, this appli= cation can > then be integrated in larger firmware testing frameworks. >=20 > --- > v3: Fix pointer dereference in GetSelectedTable. Create library > interface for the UefiShellAcpiViewCommandLib and convert to > named library. Tidy help text shell hook in standalone app. > v2: Patch formatting >=20 > Cc: Ray Ni > Cc: Zhichao Gao >=20 > Tomas Pilar (7): > ShellPkg/AcpiView: Move log reset to main method > ShellPkg/AcpiView: Refactor configuration > ShellPkg/AcpiView: Move table count reset > ShellPkg/AcpiView: Move parameter parsing > ShellPkg/AcpiView: Refactor DumpAcpiTableToFile > ShellPkg: Add AcpiViewCommandLib > ShellPkg/AcpiView: Add application wrapper >=20 > .../Application/AcpiViewApp/AcpiViewApp.c | 40 ++ > .../Application/AcpiViewApp/AcpiViewApp.inf | 34 ++ > .../Application/AcpiViewApp/AcpiViewApp.uni | 122 +++++ > ShellPkg/Include/Library/AcpiViewCommandLib.h | 46 ++ > .../UefiShellAcpiViewCommandLib/AcpiParser.c | 1 + > .../AcpiTableParser.c | 1 + > .../UefiShellAcpiViewCommandLib/AcpiView.c | 474 ++---------------- > .../UefiShellAcpiViewCommandLib/AcpiView.h | 113 +---- > .../AcpiViewConfig.c | 246 +++++++++ > .../AcpiViewConfig.h | 177 +++++++ > .../Parsers/Gtdt/GtdtParser.c | 1 + > .../Parsers/Iort/IortParser.c | 1 + > .../Parsers/Madt/MadtParser.c | 1 + > .../Parsers/Pptt/PpttParser.c | 1 + > .../Parsers/Srat/SratParser.c | 1 + > .../UefiShellAcpiViewCommandLib.c | 279 ++++++++++- > .../UefiShellAcpiViewCommandLib.h | 26 - > .../UefiShellAcpiViewCommandLib.inf | 33 +- > ShellPkg/ShellPkg.dec | 3 + > ShellPkg/ShellPkg.dsc | 4 +- > 20 files changed, 1019 insertions(+), 585 deletions(-) create mode 100= 644 > ShellPkg/Application/AcpiViewApp/AcpiViewApp.c > create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.inf > create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni > create mode 100644 ShellPkg/Include/Library/AcpiViewCommandLib.h > create mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.c > create mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewConfig.h > delete mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib= . > h >=20 > -- > 2.24.1.windows.2 >=20 >=20 >=20 >=20