Re: [edk2-devel] [PATCH v2 3/6] ShellPkg/AcpiView: Move table count reset

["Gao, Zhichao" <zhichao.gao@intel.com>]

It is highly suggested to use the lower-case static and const. Except that:
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tomas Pilar
> (tpilar)
> Sent: Friday, May 22, 2020 2:44 AM
> To: devel@edk2.groups.io
> Cc: nd@arm.com; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH v2 3/6] ShellPkg/AcpiView: Move table count reset
> 
> The table count module level symbols are now reset when executing the core
> method, rather than the shell command wrapper.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com>
> ---
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> index 2f7395c23bce..c9654e52c434 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> @@ -255,6 +255,10 @@ AcpiView (
>    EfiConfigurationTable = NULL;
>    OriginalAttribute = 0;
> 
> +  // Reset Table counts
> +  mTableCount = 0;
> +  mBinTableCount = 0;
> +
>    // Reset The error/warning counters
>    ResetErrorCount ();
>    ResetWarningCount ();
> @@ -390,9 +394,7 @@ ShellCommandRunAcpiView (
>    CONST CHAR16*      MandatoryTableSpecStr;
>    CONST CHAR16       *SelectedTableName;
> 
> -  // Set Defaults
> -  mTableCount = 0;
> -  mBinTableCount = 0;
> +  // Set configuration defaults
>    AcpiConfigSetDefaults ();
> 
>    ShellStatus = SHELL_SUCCESS;
> --
> 2.24.1.windows.2
> 
> 
> 
>