From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11874.1591929627741134158 for ; Thu, 11 Jun 2020 19:40:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lG8vpzoI; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhichao.gao@intel.com) IronPort-SDR: JaDAVDpyZgNnagkhM63BYK66wSWiz1EV3Kj+5vZO8fKG1N+cKbiosFszbT4zSdiaV40LYcVl+I yjxykUzPEjcA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 19:40:27 -0700 IronPort-SDR: 8aty0M+OOsEwZGJyq6XNC3Z8pqGhfvpkmF5ESU+BIu8LxMGyi1HyEhfL6PrGlE/OzgAnDzMXd0 YZfwSOcGT8Gg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="259769381" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 11 Jun 2020 19:40:27 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 19:40:26 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 11 Jun 2020 19:40:26 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 11 Jun 2020 19:40:26 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 19:40:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A1nitzBrhqBRj+VBFVM1A59U33tktAD4mTLEuCApNGqgPu1FETeO3tUOYKMGFgr9ew1rFh48m+S7h69BX6MgayqBDFQOC2JXCBx20bt/y9oJ6X01RpLWUWS8xET1po8yFFYtRk/XvMkSlpS/zFxdO9GfHURojRMPxtPAaig4oVsbJbVDBVrLvBNYPPUXYocWhuYkVtERJpF8wfx0i3fsNnpFOCliYvZTaYaEqTdfFqxpvRefp4CgdP2jKi+uq2cr8oLqbXO0NmazX0FaNQW2Pn5uWoemQjK7rETHgkYqYjMt93AB2O7H5V0e4eU3QizcphADuB6xYxAWkN4kIKqIqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Gm9/AUdzg613XAC+wYyQ7gaOOHa55YDd2rDwLcXet0=; b=iYM3T2yfD+8NCNW49zFBbkPEkZcxMh1s65DQ/iIdYjMV02w4AckjXKqLHtdHA8h6HpT6C1KV3M28BO3e87nmMCnjGeTvlJFuq+TOsI/rjLvCpY1ryd/c/mxA5ai9JpmqRnbQcJT3/S0/rSEWG4yusXHSuijKNM4daETqsAGXis0mWFpz8AcBCBRnf1bQu0Ngvlkxg+uOby6SxyQSfgUECl9lqxRycHGEzt8CyVwpdxkTP+pFOX/pslxyKI8f3Bis71y++TCT7aXNZBKpywS1ClP3OKcC38Gyzjl9FpAxJfEuJqIJpfxQ5S9VFT58MFhRFREADGqbv8dfeJd7Zgd0cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Gm9/AUdzg613XAC+wYyQ7gaOOHa55YDd2rDwLcXet0=; b=lG8vpzoIIkg9ieIcF5sXCzwTPMpNwd659tGC6O8rOsMwpUO/2Hu68ac3C2KL8FEwpF1tIYckWLdHQGTLZD8ck0TmU0RJGCtY8o5z+4q5qodfJkHlY43I2pLIJzeW+NGfDFAryGe9huLDfQMTA0D/nZYzMWWXTo0FU8m+K77xIEo= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB4753.namprd11.prod.outlook.com (2603:10b6:5:2ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.20; Fri, 12 Jun 2020 02:40:22 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3088.023; Fri, 12 Jun 2020 02:40:22 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Tomas.Pilar@arm.com" CC: "nd@arm.com" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v2 3/6] ShellPkg/AcpiView: Move table count reset Thread-Topic: [edk2-devel] [PATCH v2 3/6] ShellPkg/AcpiView: Move table count reset Thread-Index: AQHWL5/7tR3txfxfqU6LrzyBLXb1XKjUSrcA Date: Fri, 12 Jun 2020 02:40:22 +0000 Message-ID: References: <20200521184421.2222-1-Tomas.Pilar@arm.com> <20200521184421.2222-4-Tomas.Pilar@arm.com> In-Reply-To: <20200521184421.2222-4-Tomas.Pilar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e596f8db-7d18-4fcc-b5e3-08d80e79f473 x-ms-traffictypediagnostic: DM6PR11MB4753: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1332; x-forefront-prvs: 0432A04947 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N7GP4365OzqW+GzyBiZp2ty2Kdip7amJ2hGafvd7X6H1QbdUv/Q0DxZRIJhD2Q4wzE+cUizut3zLA0QzTvBEVW4Y1bGjkqzqw6a1HpVk5u/J/b+HonGDTBy5GYFxCcwPndpj/9IO+VoHHIXUo6bbPy3sJ+IRnRkj2ckWHH/ccluCztwcWby1uRNFQgRl1AMLhR9eUlNvkvx1J3Y7outeqp0afk/0R9NtRjTgQFH8MyjX9+c9UxXc5HZDzR/8fAm2zt/ZlnKP0vOW9iqs5NzFTt45Hj8gqXccfOdA1nIg0Sq1FnORxxFFaQBJDgglLxeKTIxX4fzHwCCYCitFMZDWSCQniGirdnmM8IyJ2fYNVPL2bttGxepEHg4YLRN+SUifUlaVERQrPc7V2B5v/WX1CA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(366004)(39860400002)(376002)(396003)(52536014)(5660300002)(71200400001)(966005)(86362001)(66446008)(66946007)(64756008)(83380400001)(2906002)(76116006)(8676002)(8936002)(66556008)(66476007)(478600001)(110136005)(107886003)(6506007)(55016002)(53546011)(9686003)(316002)(4326008)(186003)(33656002)(7696005)(54906003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ovkbKm05qDsyTRkK1yr+XX9tlaS5i+rZirl0ZKl6ClwQYqTd3tK75wRtCyjfuE08vSMnBoVrMNKhaxt/UUNdqTMyJa+gDGNMGJaONlyt+S78WmoREoSpiIngGgIq0C8W/aRKkmK/XOPTooXAZGqyf/m0d2H5bpLLz3wHmXj0qv3I4w+4mXC0goNPV5AjwdtnHWlmyqeulliuLeC/WYBiJPEAlI7zLlGI3MwE253VAnTipUet446hZBy7b8gHACDrTyF6aXohDcEQCqdI5YfmeiY4D1/uHw1MzbIYxsUGhfT8PYUe2i2EONVqfDOR8qW/RZgSwrf0N/uUaQpW0l8uL/WTHWB8Wy9228sR4vcqqqs6D3KDDnpOzbfYA05+uAXq3COSXRexaMkZadBpM4MBfdP6u1303T1KFmR1rsFpp0+s1CXz1TdUVdfTst0OvT6A3FMqShCLvsv81hX+3uxOA5sGyh2aZB+GdrPTidj4gAtoiGMZ/vzRPpOgbmc29+6V MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e596f8db-7d18-4fcc-b5e3-08d80e79f473 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2020 02:40:22.6981 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1uE6BdUbqNMBzsQjh/ZRn85VTYUokp2JTn95tBTXo+gaqbABr6wmQrkmjmnZJcdqwO/RJpOU9Exj5ZhRkdP5Zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4753 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It is highly suggested to use the lower-case static and const. Except that: Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Tomas Pil= ar > (tpilar) > Sent: Friday, May 22, 2020 2:44 AM > To: devel@edk2.groups.io > Cc: nd@arm.com; Ni, Ray ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH v2 3/6] ShellPkg/AcpiView: Move table count= reset >=20 > The table count module level symbols are now reset when executing the co= re > method, rather than the shell command wrapper. >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Tomas Pilar > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > index 2f7395c23bce..c9654e52c434 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > @@ -255,6 +255,10 @@ AcpiView ( > EfiConfigurationTable =3D NULL; > OriginalAttribute =3D 0; >=20 > + // Reset Table counts > + mTableCount =3D 0; > + mBinTableCount =3D 0; > + > // Reset The error/warning counters > ResetErrorCount (); > ResetWarningCount (); > @@ -390,9 +394,7 @@ ShellCommandRunAcpiView ( > CONST CHAR16* MandatoryTableSpecStr; > CONST CHAR16 *SelectedTableName; >=20 > - // Set Defaults > - mTableCount =3D 0; > - mBinTableCount =3D 0; > + // Set configuration defaults > AcpiConfigSetDefaults (); >=20 > ShellStatus =3D SHELL_SUCCESS; > -- > 2.24.1.windows.2 >=20 >=20 >=20 >=20