From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.10522.1596504794828534752 for ; Mon, 03 Aug 2020 18:33:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=nm5J27MC; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zhichao.gao@intel.com) IronPort-SDR: Y4BlfvCl0H++nvP1tF4Wgf1ymEc0N5HPOR+gZ4gVEEp7eLltii+DNI7TT9E/u4BbbirTSvmvmC tUWLe+nwCNRw== X-IronPort-AV: E=McAfee;i="6000,8403,9702"; a="139819534" X-IronPort-AV: E=Sophos;i="5.75,432,1589266800"; d="scan'208";a="139819534" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2020 18:33:13 -0700 IronPort-SDR: 98JwF2qGPW3Se5aUqDVpcn6kIvJIAQoqcsjYqDbp0VomjTneUtuz3EZ07sEbvH6CeOV54p5GM2 BoOHfQV/foGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,432,1589266800"; d="scan'208";a="288364580" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 03 Aug 2020 18:33:12 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Aug 2020 18:33:11 -0700 Received: from orsmsx104.amr.corp.intel.com (10.22.225.131) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 3 Aug 2020 18:33:11 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Aug 2020 18:33:11 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Aug 2020 18:33:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SOX0Yt5TKqJMIqyTmZPwgW53VTT8/vtdYaFoMHxL7/rgbYqR30CXLgaPlw+YWMkSMbTvf9wEC6PS4euWEetvwIzQ91pMIbanzIKo7W4ApwS0hzUxPChkiDHRcd7I0UB9YJD5+7slSdMQVRMFXg0XhkbH7ERa+r8yl2sFdwwp0+UWfHblo+vyzXkLgXiNfuGQQpVHDfytaCbseV19Cf/+pJw50WHUdfLfsEtV5brF1N96QzABxHCJtjKKZltE55sBPbMO8cEPz3XrkB3mDm5V/u3pEQABo9XNkJPy+VZXi8FAAGuCb13B/mGSTT7M6YudfEj093Hzjf4ErdMZ4+AdaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sMxW08fq+Yf70BaDy48dzWlkTjvRv5lQ5OW+s/0qEN0=; b=PZZQ+7VmzEsAf9gsSCzVYJK0fLJER+ytu3PduHjHeqiohhQ1I9SBQbkmzJZAb1lHbNudCuCkM+QMYgYxwRiiaKAxEyzkYl+Ao9+KoZJmQEBuIQnKkIBAs+ayGRgvkSy6w2U1ZxuVPf1P7aaZgOv6NCD/hi7Vc3b39kKn7xsu9k5Ynbb7otWn74pryhpV79uGmJfpaIDPNoD87LzGho5Hu1o3qz/vWp7Llw14W2JoXqvE2PiQr8xjq+RlVZyFHm6bbTOZpgHFT+wUZHUNcwXgi6V2u3GiN4blfzFPyu7KXCgVJ+vJMl4JHqXai5k4Re6oDnhOeyN+nlVhYfCIwjbmig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sMxW08fq+Yf70BaDy48dzWlkTjvRv5lQ5OW+s/0qEN0=; b=nm5J27MC2vP0kh6RWDGSLIZVod2UwxKoY/MAfc9Y3NTrBlCqqn1+nfgkwFKJZUOkODoGz9FTxxJtn56Sp04FI3QhgZgDgjQi0OtvsLx4RTpBz2A7yXk5PskB29CYjpNhH1lF1/8lON0QgAsquqI3VOllzioQdFP+3OoQ1yBP6KU= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB3451.namprd11.prod.outlook.com (2603:10b6:5:5b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17; Tue, 4 Aug 2020 01:33:01 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3239.021; Tue, 4 Aug 2020 01:33:01 +0000 From: "Gao, Zhichao" To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" CC: "Ni, Ray" , Sami Mujawar Subject: Re: [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field values format Thread-Topic: [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field values format Thread-Index: AQHWXsyTm0XtHbVjgUWcWB9jPzs8kKknQLVw Date: Tue, 4 Aug 2020 01:33:01 +0000 Message-ID: References: <20200720193231.4560-1-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200720193231.4560-1-Samer.El-Haj-Mahmoud@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a0aa404-2dc1-4d15-a794-08d8381653cb x-ms-traffictypediagnostic: DM6PR11MB3451: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1186; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OAgwgtxgo7lSTPolvrsqGiS2UlVsX8TyluyPi8vyZqYlTcMEQyaPtzRNXeG8k6nG/PMN30EDtefpgWYGW08H6iMUL6NwlFfIx6wPfDUlrQbRY7O1MuuzROrF7MurDiAN2zYUYeQQTP1eUwb1PR0X6IEzWBd8VZqxFzy4bHLPo6TjhfQMja16En748RAxM7CpYrxBf3SiXWZ5drQ75PO2go/qBFTAZ9B9gW6QRT6eSbElJ0xiHpTyIhay5/KrUekGbFEUXs33jFhZTh6wMRpaEvytEqz+wNk7O3cn0pXHv9cVFAAgYQPktWEhRd9fHYmeu95Z7l/xctxk1JV0xvnxoQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(8676002)(86362001)(7696005)(66446008)(83380400001)(55016002)(2906002)(186003)(478600001)(76116006)(4326008)(26005)(52536014)(8936002)(66556008)(110136005)(9686003)(66946007)(66476007)(64756008)(54906003)(316002)(6506007)(33656002)(53546011)(71200400001)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: xYM3v0mXbEb7m4+mGHHvprmvPhm7E/IfFFvJ5qcN345o4E3w54LjUABpUMD8j9t2w3vSlLeB03EtSyAwl386+nrKk3rkEPvm2iFyanXAtnLJRckScbATwPUUsD7x9Mh0I8hO4TJ933z2siqZLkTfcrfF2UON79WX/7eHkjyI48Jm+BnWougF/ej+FHNunLJX+cBaQGBOOoE3/PPjRIXHEKS/ijEUfzvtwEINZ3TPu8ree3xhmHuT7264i9MXP5J1VQ65d0dCSV6PlFVuJv/E2QGqm6xpRKVKgVHor5OO8uR7x7AAnRvys5wwsVogDuUIXGvgPViXgBNVSx0amjKgDTcXpn5FHGeNUf5XPjVpYH3YYVM3BeuZ27LygvIl+oxK+imgeLr90vwhctgvU0QPtL6kS3yoVFBWyop3rXnDnfR5wc6adt9D0mb711n5DxAr/qnZul+P5V5ZjQnawY9NVPRAz8ssAf6TXnwMlLLDmNJ+C9UuBBukZP5xGn5oaEoEK8QhCixqkgx9CNKlYRLbnK0pzIzmbT+4aR3ZudEFdBVX0ObthZNbl1uan1rPAxs2Ns1OKhQ/pE0/UteHZC2KQHWmjiHZk1iFU9Opz8nAHfyphXALT4AgusSH7pgUCZWxJdYtNuyhgNSsbBwuyJ+Y/g== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4425.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a0aa404-2dc1-4d15-a794-08d8381653cb X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2020 01:33:01.8557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DYyOI8/mIaqK0w1gRX7l4QqDT1Zyfml8pnhn+6JVBgAYI8s3mjTU1ru2JIJ4s4xq/b58bVw74c6aA7LMFn1ePA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3451 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Samer El-Haj-Mahmoud > Sent: Tuesday, July 21, 2020 3:33 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Sam= i > Mujawar > Subject: [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field = values > format >=20 > Change how some SMBIOS TYpe 17 field values are printed: >=20 > - TotalWidth, DataWidth, ConfiguredMemoryClockSpeed: Print as > hex values instead of decimal, since there are some special meanings > for certain values (e.g. 0xFFFF) > - VolatileSize, NonVolatileSize, CacheSize, and LogicalSize: Print > as "0x%lx" instead of "0x%x" to prevent truncating output when > printing these QWORD fields. >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Samer El-Haj-Mahmoud > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 14 > +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index 1ea7b84bd0fa..7517465ddd49 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -746,8 +746,8 @@ SmbiosPrintStructure ( > case 17: > PRINT_STRUCT_VALUE_H (Struct, Type17, MemoryArrayHandle); > PRINT_STRUCT_VALUE_H (Struct, Type17, MemoryErrorInformationHandle); > - PRINT_STRUCT_VALUE (Struct, Type17, TotalWidth); > - PRINT_STRUCT_VALUE (Struct, Type17, DataWidth); > + PRINT_STRUCT_VALUE_H (Struct, Type17, TotalWidth); > + PRINT_STRUCT_VALUE_H (Struct, Type17, DataWidth); > PRINT_STRUCT_VALUE (Struct, Type17, Size); > DisplayMemoryDeviceFormFactor (Struct->Type17->FormFactor, Option); > PRINT_STRUCT_VALUE_H (Struct, Type17, DeviceSet); @@ -765,7 +765,7 > @@ SmbiosPrintStructure ( > } > if (AE_SMBIOS_VERSION (0x2, 0x7) && (Struct->Hdr->Length > 0x1C)) { > PRINT_STRUCT_VALUE (Struct, Type17, ExtendedSize); > - PRINT_STRUCT_VALUE (Struct, Type17, ConfiguredMemoryClockSpeed); > + PRINT_STRUCT_VALUE_H (Struct, Type17, > + ConfiguredMemoryClockSpeed); > } > if (AE_SMBIOS_VERSION (0x2, 0x8) && (Struct->Hdr->Length > 0x22)) { > PRINT_STRUCT_VALUE (Struct, Type17, MinimumVoltage); @@ -783,16 > +783,16 @@ SmbiosPrintStructure ( > PRINT_STRUCT_VALUE_H (Struct, Type17, > MemorySubsystemControllerProductID); > } > if (Struct->Hdr->Length > 0x34) { > - PRINT_STRUCT_VALUE_H (Struct, Type17, NonVolatileSize); > + PRINT_STRUCT_VALUE_LH (Struct, Type17, NonVolatileSize); > } > if (Struct->Hdr->Length > 0x3C) { > - PRINT_STRUCT_VALUE_H (Struct, Type17, VolatileSize); > + PRINT_STRUCT_VALUE_LH (Struct, Type17, VolatileSize); > } > if (Struct->Hdr->Length > 0x44) { > - PRINT_STRUCT_VALUE_H (Struct, Type17, CacheSize); > + PRINT_STRUCT_VALUE_LH (Struct, Type17, CacheSize); > } > if (Struct->Hdr->Length > 0x4C) { > - PRINT_STRUCT_VALUE_H (Struct, Type17, LogicalSize); > + PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize); > } > } > break; > -- > 2.17.1