From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.10651.1597134542893490159 for ; Tue, 11 Aug 2020 01:29:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=H/9X3kWv; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhichao.gao@intel.com) IronPort-SDR: 1lGpa+dROIAnvamhc9ahJpsFxjhvJX/5RAEsv8yzeOTpzl+bWK2gy1Sp6svlhMMtFfFHeM8xG9 T0if1dR8rZkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9709"; a="215207919" X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="scan'208";a="215207919" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 01:29:02 -0700 IronPort-SDR: B5LCgdTtUay2TK8ks4SqkfgeCxFs3L7ohonUu6PC5A5mvgpY7lLUaFbhNsDy1rvNosa4/xi6Iz NfjZLUOBH4ug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,460,1589266800"; d="scan'208";a="294650412" Received: from orsmsx601-2.jf.intel.com (HELO ORSMSX601.amr.corp.intel.com) ([10.22.229.81]) by orsmga006.jf.intel.com with ESMTP; 11 Aug 2020 01:29:02 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 01:29:01 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 11 Aug 2020 01:29:01 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 01:29:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XtE1hZulaWrDcPS76poc1xMTYS9ircmnJPNxR/0EYfA7ALxPR23NLS8YnMSAVuEpGk8Szn3Kk58GWF6vKgylfoGoDCh3ThvUcfgXd/4F4Q25aiiJ9SsacV4s1Uk7WHI4+BRXIzBp4ZPOParNPztIwGxa+iSh0BsRK0P5wOBqXUVUu4P+g8BmbUxbbadMGdZAxMhBqLnVgDINdTnPzVXr26FtVATF5GlK+KE0eapSFJSVvN9TlmaboQWHPX3H5ZOblpjD7tkv7/l6hrS8U3MBQV+PhczPWImN4m4c4G5FrUxy8TFX4V9qJhaqpFdFsw8yqZ+lZcOrPOnGQZqpqdYX7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6kef+8bpwhz3aajwuhmdECvbnjgkBxGNTZ7fo8ZXX4=; b=mYonhK1hz6D+NAr02Grsows0+jXJLZ06N/nYpTTBjerd/uOTubYY9NvMBBczHSW6NRJyrxD2ySl56Tf9vVoqwg2IWwwXQk0uBdLWQaAyI7dpKIOTevjrFWK97e+I42gLLsqL1pvURJjVo2PmFujDegVFLrBNwU9GRfH7/VzdAXoKbvrm/p8HVxP4KJ6XrYU1gZve/FLOdcoW/YxLbR85MHqrXffjev7uRtY2H4wRp5OVe/ivyGs8wC4a6RDQ1gf3WSfZmELUTcwCz7fvSAOgqZBORIyPORfu7izCuJFGaGDsX65rmmPY+ezth6Goq2f/ZantVVOcyauaVMjhLcsfGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6kef+8bpwhz3aajwuhmdECvbnjgkBxGNTZ7fo8ZXX4=; b=H/9X3kWvUXDyppZvX55fnzEdz/m7VftEhefH0YFFUAnXRhOAMw2aNZpzN1ibl55tSOcRUjYXuZHPl0K00ORDrVVgz/kO7kGMopo9zezCIaAKU4baH5VqM8mYZODxGV2m1SWWycTaq5sVUUYGt2M85MHFqamjkqdyv9OXV0aJA3s= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM5PR11MB1866.namprd11.prod.outlook.com (2603:10b6:3:10a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.19; Tue, 11 Aug 2020 08:28:58 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3261.025; Tue, 11 Aug 2020 08:28:58 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Ni, Ray" CC: "Wang, Jian J" , "Wu, Hao A" , Gary Lin , Andrew Fish Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove the check for special MBR Thread-Topic: [edk2-devel] [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove the check for special MBR Thread-Index: AQHWb7Y5aKOML7rS+0iQLUvkZMkCTKkykhnA Date: Tue, 11 Aug 2020 08:28:58 +0000 Message-ID: References: <20200811064302.33188-1-zhichao.gao@intel.com> <20200811064302.33188-3-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C66894E@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C66894E@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69fbbdbf-8570-4958-616f-08d83dd097ca x-ms-traffictypediagnostic: DM5PR11MB1866: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tApEUIJdE2IhZGDdqC2j/a/Nw0TSPeiRirSXCd3DCxugH3oAH5jvnmhNuVlw50S089aChPpWqpWHJRVIDXwIjTCN0G//jIqpCqXwg78N7noMqHStCrp802Jrwt259IsJRtOvXGlPHA5gWBxNZFvlINLsOy0Ccr5dbqZR3fwHau9PCCDzM0FEoYI07z1W+mjf5wI7Y491pfJshhg3mGKB61jghacFO1Hnq1kMhzEHpRWRpGA/SQHCHVsM3PKpX9yxyWJGwI5QfYNZihljr8K0as4AcUDodO/4BN8aJABk4hTU3UcNV7DPSmRyxtZMoUxpwVbVIivKYWYcP9E+sUuY+kQMBmobMHHT8C3qC3jZmCriz9uk2Ghs7mSKlqeSsqq9LOe31VbQ/7vJ2JHdYF34uk6+/7GgLpmdEDLwzjFeeGZwgojkVlky9B62/CsPlE+pIqM94IRWM7QZOyNGj1faIw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(366004)(346002)(376002)(396003)(53546011)(66946007)(6636002)(33656002)(66446008)(7696005)(26005)(8936002)(76116006)(110136005)(4326008)(478600001)(71200400001)(86362001)(316002)(5660300002)(6506007)(9686003)(2906002)(64756008)(66476007)(52536014)(8676002)(66556008)(55016002)(966005)(54906003)(83380400001)(186003)(562404015);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: FCO+sGy+B1lynfYhrh7TjfS39Xpi+ruGcJINHuWi/EBZHBaP1CdfPkyiTYDu4Svl6LRLPG6msvRIrI56hzBez5sF0eX87agieRMryjjP9DBWpbU0k5Fh+ZySQvB0u0yUDzDDl5WdG9sQ1vssSLRJpyraUGTanx9GuPMBJhp5y069XMLMdtXfKI8RSCkuGdsdgYlgw8/nmJJZmxlXoLtIzKKf78vGmYNhkNQrMbINfKbW619zjjmyWK5qusf8okU+yGZwY4WzDqlZ+f793WmG9hN8bbyrLjHcsW0Ji5hT7OGW5nEhBsFobz64nyHoPMo48vCchiKhoJ9Bi69ULfqe94uuQOgfZtSe9XCzDLvmWG4l0XROSr7XV7tIQIh8s4kNMIghPxk+tEodPRvCxnqvsKhgZNXO8ZiMQyYidWOY2T0Aiv5FKm938krI5aB2PbA2TDxibQY5kbo+EyGYjj03nqWtc+vXQ0MiY9a+ezKfbnfxpWUIeIVwz3v35C+RT5/r48togLLgJhtLgW9wsFn63yMjbNYf+aIzcbMEsyrB/XoeEJEuYvADA7d/StvEHs8pa9yzx7Hi95Zhq16Xvrtxl0RWwa29ghQsJFfREeb2wbblNxb5l8h5/OkMCYxMIDHBKESWyah8LKfl1/SZxHqkMg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4425.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69fbbdbf-8570-4958-616f-08d83dd097ca X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2020 08:28:58.1120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YC1vh/ErM5oJOSafQAdT22PpN3DNoPV3qovsBP4rNmAcrmulPZIghNOROClWe1viHFeki3H6wKRcLsmHASgIEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1866 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I also add some variables to calculate StartingLBA and SizeInLBA instead of= calculate them when they are needed. I am fine to revert the whole changes. Just make you aware of this. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Tuesday, August 11, 2020 4:06 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A = ; > Gary Lin ; Andrew Fish > Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove > the check for special MBR >=20 > Zhichao, > Can you please just revert the fix you recently added? >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Tuesday, August 11, 2020 2:43 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Ni, Ray ; Gary Lin > > ; Andrew Fish > > Subject: [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove the check for > > special MBR > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 > > > > Follow the spec definition, the ISO 9660 (and UDF) would be checked > > before the MBR. So it is not required to skip such MBR talbe that > > contian the entire block device. > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Gary Lin > > Cc: Andrew Fish > > Signed-off-by: Zhichao Gao > > --- > > .../Universal/Disk/PartitionDxe/Mbr.c | 19 ------------------= - > > 1 file changed, 19 deletions(-) > > > > diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c > > b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c > > index 3830af1ea7..822bf03e92 100644 > > --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c > > +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c > > @@ -55,25 +55,6 @@ PartitionValidMbr ( > > StartingLBA =3D UNPACK_UINT32 (Mbr->Partition[Index1].StartingLBA= ); > > SizeInLBA =3D UNPACK_UINT32 (Mbr->Partition[Index1].SizeInLBA); > > > > - // > > - // If the MBR with partition entry covering the ENTIRE disk, i.e.= start at > LBA0 > > - // with whole disk size, we treat it as an invalid MBR partition. > > - // > > - if ((StartingLBA =3D=3D 0) && > > - (SizeInLBA =3D=3D (LastLba + 1))) { > > - // > > - // Refer to the > http://manpages.ubuntu.com/manpages/bionic/man8/mkudffs.8.html > > - // "WHOLE DISK VS PARTITION" > > - // Some linux ISOs may put the MBR table in the first 512 bytes= for > compatibility reasons with Windows. > > - // Linux kernel ignores MBR table if contains partition which= starts at > sector 0. > > - // Skip it because we don't have the partition check for UDF(El= Torito > compatible). > > - // It would continue to do the whole disk check in the UDF rout= ine. > > - // > > - DEBUG ((DEBUG_INFO, "PartitionValidMbr: MBR table has partition= entry > covering the ENTIRE disk. Don't treat it as a > > valid MBR.\n")); > > - > > - return FALSE; > > - } > > - > > if (Mbr->Partition[Index1].OSIndicator =3D=3D 0x00 || SizeInLBA = =3D=3D 0) { > > continue; > > } > > -- > > 2.21.0.windows.1 >=20 >=20 >=20