Re: [PATCH v2 1/6] ShellPkg/AcpiView: Move log reset to main method

["Gao, Zhichao" <zhichao.gao@intel.com>]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Tomas Pilar <Tomas.Pilar@arm.com>
> Sent: Friday, May 22, 2020 2:44 AM
> To: devel@edk2.groups.io
> Cc: nd@arm.com; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: [PATCH v2 1/6] ShellPkg/AcpiView: Move log reset to main method
> 
> The error and warning counters are reset in the AcpiView main method.
> This improves reusability of the main method.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com>
> ---
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> index 84ffb3595750..f1a95b7b8f03 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> @@ -424,6 +424,10 @@ AcpiView (
>    EfiConfigurationTable = NULL;
>    OriginalAttribute = 0;
> 
> +  // Reset The error/warning counters
> +  ResetErrorCount ();
> +  ResetWarningCount ();
> +
>    // Search the table for an entry that matches the ACPI Table Guid
>    FoundAcpiTable = FALSE;
>    for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) { @@ -
> 566,10 +570,6 @@ ShellCommandRunAcpiView (
>    Package = NULL;
>    TmpDumpFileHandle = NULL;
> 
> -  // Reset The error/warning counters
> -  ResetErrorCount ();
> -  ResetWarningCount ();
> -
>    Status = ShellCommandLineParse (ParamList, &Package, &ProblemParam,
> TRUE);
>    if (EFI_ERROR (Status)) {
>      if (Status == EFI_VOLUME_CORRUPTED && ProblemParam != NULL) {
> --
> 2.24.1.windows.2
>