From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.12181.1591929608302521846 for ; Thu, 11 Jun 2020 19:40:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QnX9P72L; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) IronPort-SDR: 5HPQKa94HQbqOm/ZZLr0utmYxm784JDWZjivzsLqEc3l3hOfdDmSddPhhpNcZrEPHLSXj9uxFS 3fLkKYTw31AA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 19:40:07 -0700 IronPort-SDR: y69maXPqKr1o1wY9siz2Dzx6/uOMI2Q/i5PbMxhp9L2cKCMWla1bh/JRWObmAD96709FOdrDfp VF+AtSMqZXCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="275539477" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga006.jf.intel.com with ESMTP; 11 Jun 2020 19:40:05 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 19:40:04 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 11 Jun 2020 19:40:03 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 11 Jun 2020 19:40:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 11 Jun 2020 19:40:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bex4YlgdhvpLTjW8mMqjd3gmQFnSOF74s2I7Vem1eqT/Mr082lf2ndJb3nRuGLoFz2k9GjgqymqvSQRbHHDeOpBuegVuPBNA12pH5OGTuqYCNc03soaxxfoszaxw27UjnesN0trQcFBhFWvPWwXKblfp7SEcw5WieFHzMcvXdUUDmpABwSKcUx9j3DQeRzJUugVvjeUYIy8MAyx16qqGLuQeIrLiiJPd3pcwfo7LV44WMqXIiAsgeR0m6hOOvYOllYu0fLyI628qisFNEAleKMTY86qQEHZxn3QZqOovksrATX9Kw4UB5ig1ok4P9BMNfrRUvYBXBFTb9e8nP9aX8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0SLaKRVcno6GiCJh8in8EAmfalXN8LvH2GhWp3erfI=; b=m0qpenzsAZVljjZ7GRqF/3+NmzDPd9g+0r0TDTfi/Cq2FGjUX2Dh3a3C7zLiLAX8yRjFSE5fT+3yfECNC5q2YJ/9UWWw8yEfcEv7zlVcaOk9ctDmNpJANLIWMs1fusIW8JtH3oIvYLvVGSGzCvxkE1xl26DGzFfKhEa+zPnXr31zG5eFcywckuT3h0gbnmpeZKUz59hO/ITmhW9eyFgv2IYoT+mhsmtq0IKXiDgzXpbNlDe3Q2dAjccYP5AFsZBgRKxryMOweofpyT5QaPssh9MrfqRh2W+QOrmC4/nBMr/jPC7clv6u+wH6GsDhGTFEE4EhL0vPI2p/8XlYBtSqNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0SLaKRVcno6GiCJh8in8EAmfalXN8LvH2GhWp3erfI=; b=QnX9P72L033MB79nDG8WMCdE7/Q1W5AtJ0YJ4miOWuZhKqtQzaspMwd9ADCHgWlg7nn7g2oAsLNWdoExLkaAPd6C9E9ByKFcrAoxDZtcICwPUqr1sx9tJZ1a02k89McfIFYaV471wuy+Nc0HutJFv5Ic1EtXwLVbarAcKs7m/fI= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB4753.namprd11.prod.outlook.com (2603:10b6:5:2ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.20; Fri, 12 Jun 2020 02:40:02 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::ad34:e1fc:2e7b:d124%3]) with mapi id 15.20.3088.023; Fri, 12 Jun 2020 02:40:02 +0000 From: "Gao, Zhichao" To: Tomas Pilar , "devel@edk2.groups.io" CC: "nd@arm.com" , "Ni, Ray" Subject: Re: [PATCH v2 1/6] ShellPkg/AcpiView: Move log reset to main method Thread-Topic: [PATCH v2 1/6] ShellPkg/AcpiView: Move log reset to main method Thread-Index: AQHWL5/6dAYdsY8UUkCpF+nqeVKvh6jUSmlQ Date: Fri, 12 Jun 2020 02:40:02 +0000 Message-ID: References: <20200521184421.2222-1-Tomas.Pilar@arm.com> <20200521184421.2222-2-Tomas.Pilar@arm.com> In-Reply-To: <20200521184421.2222-2-Tomas.Pilar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fbe5875c-e159-4b59-1aa6-08d80e79e853 x-ms-traffictypediagnostic: DM6PR11MB4753: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:103; x-forefront-prvs: 0432A04947 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s6F56sZoFzQMuuP14sVO3EssVTi1OrT+s2/ZtsMVyffeQWqZ/jmzVb11uQBYPJU3ygPq7RPgeyOH4KqnRGMSKcl2I2H9SAlUio9jMLlsvnY61y0VoTSMIp3/kl1mTGhtqpfk3ilFtzlUHXv1Eci6rvOpm+VqleqpnahmKCSZIirbWJbBc2n08bE5BAedzfd6limRrUyhvWrnPgJe+L6IICNpUzZaj+0V4QtpxG+5pCPOKLz3Udx6LtiGtjxfX47usrHc7czALdx0pT1/JhhkQ0f8hme2sVAWMtz+MpGCnWIeMvKCtCbt5VSfFwb5RrXn x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(366004)(39860400002)(376002)(396003)(52536014)(5660300002)(71200400001)(86362001)(66446008)(66946007)(64756008)(83380400001)(2906002)(76116006)(8676002)(8936002)(66556008)(66476007)(478600001)(110136005)(107886003)(6506007)(55016002)(53546011)(9686003)(316002)(4326008)(186003)(33656002)(7696005)(54906003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: NL84TLJDKW0FUnxcOFZ4jDaAG4OBuTfjmFu89nWPOf12DR3N9f3Upy1dqV5mo0C0T1HdxgopPR9sWeb5FCn36bozE726J6uSXMNNBGmUZ7EZfA/DRd2itR0ABF4h6Iw8NYDL/XzzKkqkqrhjhaJM5ZMCZjUnevn8DL1BtsExrM7YsVphTqGZ6JTxnzgdUk8iE3jc077UAf5zPVgFndXxRyCK4nK9D8aJKyRPVHoDyHdBfvTToKXFkuNY3JBOXXaO93p+oCIOBAv5G9j88ktb4nWv5+C2aoc4hR5aQBkSWE5KRDmVSFMpncW7k8Cq5o7jP/m/AvsMHkJO/aST4oEBLPaWZDUGJDti3tENCs8tK+S3CzNS5tVgoXmfp67A90vl7EsnwnSPb8RpSAOhpaOpyA3cXkUL1IXA4tIlf9id6Bk3U7Pfq4KHo7av/o2YnCF1EqPI06yohXhfR5Vu65/Cq4m3VyoiPLCpjd4pUMNGEG0qTzH6hrZQOB/rjZg97emW MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fbe5875c-e159-4b59-1aa6-08d80e79e853 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2020 02:40:02.3897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g4KfxBRUkNkx5u8FEYUz9FBmyb1zpLznEXtP6avuc7iKm2acXZitKqaYIbyOEdQn7yHNyfixp6kGy/6pn9M6/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4753 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Tomas Pilar > Sent: Friday, May 22, 2020 2:44 AM > To: devel@edk2.groups.io > Cc: nd@arm.com; Ni, Ray ; Gao, Zhichao > > Subject: [PATCH v2 1/6] ShellPkg/AcpiView: Move log reset to main method >=20 > The error and warning counters are reset in the AcpiView main method. > This improves reusability of the main method. >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Tomas Pilar > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > index 84ffb3595750..f1a95b7b8f03 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c > @@ -424,6 +424,10 @@ AcpiView ( > EfiConfigurationTable =3D NULL; > OriginalAttribute =3D 0; >=20 > + // Reset The error/warning counters > + ResetErrorCount (); > + ResetWarningCount (); > + > // Search the table for an entry that matches the ACPI Table Guid > FoundAcpiTable =3D FALSE; > for (Index =3D 0; Index < SystemTable->NumberOfTableEntries; Index++) = { @@ - > 566,10 +570,6 @@ ShellCommandRunAcpiView ( > Package =3D NULL; > TmpDumpFileHandle =3D NULL; >=20 > - // Reset The error/warning counters > - ResetErrorCount (); > - ResetWarningCount (); > - > Status =3D ShellCommandLineParse (ParamList, &Package, &ProblemParam, > TRUE); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_VOLUME_CORRUPTED && ProblemParam !=3D NULL) { > -- > 2.24.1.windows.2 >=20