public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Dorapika Wu <chuan-hsun.wu@hpe.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH] ShellPkg: Update timezone of 3 cities
Date: Fri, 12 Jun 2020 03:03:58 +0000	[thread overview]
Message-ID: <DM6PR11MB4425AE11C278F997E6B9349DF6810@DM6PR11MB4425.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200605024421.5600-1-chuan-hsun.wu@hpe.com>

Please add the BZ link as below in the beginning of commit message:

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2780

Also remove the " Contributed-under: TianoCore Contribution Agreement 1.0".
See https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format.

With the above fixed, Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Dorapika Wu <chuan-hsun.wu@hpe.com>
> Sent: Friday, June 5, 2020 10:44 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Dorapika Wu <chuan-hsun.wu@hpe.com>
> Subject: [PATCH] ShellPkg: Update timezone of 3 cities
> 
> The timezone of following cities should be updated:
> Istanbul: UTC+3
> Novosibirsk: UTC+7
> Georgetown (Guyana): UTC-4
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dorapika Wu <chuan-hsun.wu@hpe.com>
> ---
>  .../UefiShellLevel2CommandsLib.uni                           | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.un
> i
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.un
> i
> index f5344e9e7d..8ce015746f 100644
> ---
> a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.un
> i
> +++
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.un
> i
> @@ -101,24 +101,24 @@
>  #string STR_TIMEZONE_M6           #language en-US "UTC-06:00, Central America,
> Central Time(US & Canada)\r\n"
>  #string STR_TIMEZONE_M5           #language en-US "UTC-05:00, Bogota, Lima,
> Quito, Eastern Time(US & Canada)\r\n"
>  #string STR_TIMEZONE_M430         #language en-US "UTC-04:30, Caracas\r\n"
> -#string STR_TIMEZONE_M4           #language en-US "UTC-04:00, Atlantic
> Time(Canada), Caracas, Santiago\r\n"
> +#string STR_TIMEZONE_M4           #language en-US "UTC-04:00, Atlantic
> Time(Canada), Caracas, Santiago, Georgetown\r\n"
>  #string STR_TIMEZONE_M330         #language en-US "UTC-03:30,
> Newfoundland\r\n"
> -#string STR_TIMEZONE_M3           #language en-US "UTC-03:00, Brasilia, Buenos
> Aires, Georgetown, Greenland\r\n"
> +#string STR_TIMEZONE_M3           #language en-US "UTC-03:00, Brasilia,
> Buenos Aires, Greenland\r\n"
>  #string STR_TIMEZONE_M2           #language en-US "UTC-02:00, Mid-
> Atlantic\r\n"
>  #string STR_TIMEZONE_M1           #language en-US "UTC-01:00, Azores, Cape
> Verde Is.\r\n"
>  #string STR_TIMEZONE_0            #language en-US "UTC      , Greenwich Mean
> Time, Casablanca, Monrovia, Dublin, London\r\n"
>  #string STR_TIMEZONE_P1           #language en-US "UTC+01:00, Amsterdam,
> Berlin, Bern, Rome, Paris, West Central Africa\r\n"
> -#string STR_TIMEZONE_P2           #language en-US "UTC+02:00, Athens, Istanbul,
> Bucharest, Cairo, Jerusalem\r\n"
> -#string STR_TIMEZONE_P3           #language en-US "UTC+03:00, Baghdad,
> Kuwait, Riyadh, Moscow, Nairobi\r\n"
> +#string STR_TIMEZONE_P2           #language en-US "UTC+02:00, Athens,
> Bucharest, Cairo, Jerusalem\r\n"
> +#string STR_TIMEZONE_P3           #language en-US "UTC+03:00, Baghdad,
> Kuwait, Riyadh, Moscow, Nairobi, Istanbul\r\n"
>  #string STR_TIMEZONE_P330         #language en-US "UTC+03:30, Tehran\r\n"
>  #string STR_TIMEZONE_P4           #language en-US "UTC+04:00, Abu Dhabi,
> Muscat, Baku, Tbilisi, Yerevan\r\n"
>  #string STR_TIMEZONE_P430         #language en-US "UTC+04:30, Kabul\r\n"
>  #string STR_TIMEZONE_P5           #language en-US "UTC+05:00, Ekaterinburg,
> Islamabad, Karachi, Tashkent\r\n"
>  #string STR_TIMEZONE_P530         #language en-US "UTC+05:30, Chennai,
> Kolkata, Mumbai, New Delhi\r\n"
>  #string STR_TIMEZONE_P545         #language en-US "UTC+05:45,
> Kathmandu\r\n"
> -#string STR_TIMEZONE_P6           #language en-US "UTC+06:00, Almaty,
> Novosibirsk, Astana, Dhaka, Sri Jayawardenepura\r\n"
> +#string STR_TIMEZONE_P6           #language en-US "UTC+06:00, Almaty, Astana,
> Dhaka, Sri Jayawardenepura\r\n"
>  #string STR_TIMEZONE_P630         #language en-US "UTC+06:30, Rangoon\r\n"
> -#string STR_TIMEZONE_P7           #language en-US "UTC+07:00, Bangkok, Hanio,
> Jakarta, Krasnoyarsk\r\n"
> +#string STR_TIMEZONE_P7           #language en-US "UTC+07:00, Bangkok, Hanio,
> Jakarta, Krasnoyarsk, Novosibirsk\r\n"
>  #string STR_TIMEZONE_P8           #language en-US "UTC+08:00, Beijing,
> Chongqing, Hong Kong, Urumqi, Taipei, Perth\r\n"
>  #string STR_TIMEZONE_P9           #language en-US "UTC+09:00, Osaka, Sapporo,
> Tokyo, Seoul, Yakutsk\r\n"
>  #string STR_TIMEZONE_P930         #language en-US "UTC+09:30, Adelaide,
> Darwin\r\n"
> --
> 2.14.1.windows.1


  reply	other threads:[~2020-06-12  3:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  2:44 [PATCH] ShellPkg: Update timezone of 3 cities chuan-hsun.wu
2020-06-12  3:03 ` Gao, Zhichao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-15  2:44 Dorapika Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4425AE11C278F997E6B9349DF6810@DM6PR11MB4425.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox