From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.7347.1589436878955258926 for ; Wed, 13 May 2020 23:14:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=RmXyvg1G; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) IronPort-SDR: ZywoWrgmA5cyL4HInlI7xrQhLA9XhS2yMBTLSBKCfWO5iKw2UKBMwJqXE80pKoeESDYx6of9UM Q01B9TCazRwA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 23:14:28 -0700 IronPort-SDR: Jc/d0IJIJkMCOFV1TT5CZD+/Zs9SJcyw2pVrkYJTL357B2sxRHSsoVT9F5NUQGtpPbYPg9z8gG G2qxBNllo5kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="464402024" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 13 May 2020 23:14:28 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 23:14:28 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 23:14:28 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 23:14:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oS6dw/anwsZPrdpj9lDZ8zgTqcWHW5TLtoJvJi1aUoTmQuAQcQJ/AICD8q04HceEbCOkGLEK9O+ruGGhyswUU9IqBWC5Bs2VUJ6s3fLwbAkHu9EjTx1WWkECeJ68YVGJal3hWPxn8O9namOeOGzQPwSt1xib46lVnU6DwQVZggDMIDX1t9bjc7b1BljLt1eII5Rv/RYToHJ+fq8FKp2VeNJY4nfBzGzFjQNO/HEN+HIXeg+8KdXNOAvtnjeUpxtGqCKhh9/1nRRFYTv9v8NxNR7SWqjvRfLmzKO8Jo6aw7Z6BQ29EfYtoJQgkeYn3Yts7VlLlpPegffDazoLmCkGdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xfLfZpGvVvldBCdenQaYXuFBtECCt3vzBmSts8wSRrs=; b=MM6DiEPzLtDVi8llRLD48oyvt9F6CtSEs568fwBVRnqxGUGi4PuXNnEGIqkWgTY3ztk5qnQaXeoPOSDFLW2WuGUzaKW7celCdQ+xh8AtLNzZfTyPuhw9YNOB4e6a1puHuclgYCmPoyLdNe1Ng1UmZB5586bz9+ybLgbqv63YmUPNdCVVY38GTnTuemi8w/4s2WwkS1OtWhWwTiBbrDyLuffRweCWZvmN4pKPPk3kJ/jgPsv6b2gUe4L9GxScMwvpNBwODKOZN629sPs4CahErq/OGL7b0cTqyT5jtFM3xtRHJuNU5jK0But5AeksyRfakIXsoqDKOSrM3fOLy7ijww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xfLfZpGvVvldBCdenQaYXuFBtECCt3vzBmSts8wSRrs=; b=RmXyvg1GXZGXBaxyhhacHMc05pcjn/1R6oWOsinPoPzaBXQ1BZN2FZGALljMmxmDycnAKyAx5IFC1Mzd0N43Ow/A5FlFThTVikmhUjN5WDuHy/nnHA34gsc1kuOa0nPKJJU/MWxLtS/CkERg+fkHW8s+Y35aUFW/cG+M67pNojs= Received: from DM6PR11MB4425.namprd11.prod.outlook.com (2603:10b6:5:1d9::31) by DM6PR11MB2747.namprd11.prod.outlook.com (2603:10b6:5:c6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Thu, 14 May 2020 06:14:26 +0000 Received: from DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1]) by DM6PR11MB4425.namprd11.prod.outlook.com ([fe80::615a:17b0:aa95:be1%3]) with mapi id 15.20.2979.033; Thu, 14 May 2020 06:14:26 +0000 From: "Gao, Zhichao" To: "Wang, Jian J" , "devel@edk2.groups.io" , "Fu, Siyuan" , "Kinney, Michael D" , "Yao, Jiewen" , Philippe Mathieu-Daude , "Lu, XiaoyuX" Subject: Re: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Topic: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions Thread-Index: AQHWJ8Ha/KDxt/qdI0iHRyvCNDz8pKimCmNggADVUoCAACuSgIAAEpKQ Date: Thu, 14 May 2020 06:14:26 +0000 Message-ID: References: <20200511182718.7728-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8bafe66d-b106-4d69-02e6-08d7f7ce0dcf x-ms-traffictypediagnostic: DM6PR11MB2747: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 040359335D x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MZmaqBxyR3waZ/O/g4C1ruWtxdqru25WjymT/qoOvxnRHS2xww1lOr42Tok67D2T6DkzjtMJiBvwrFAH9di91C5SBggeVMQvjCVzLx9vYozF/mfb01SwZ9dZTpEjRgXjNkJ6tvmnOpSDhhEhoeU+Lh7Sj4IGL7MKw9RCAn4YEWrYBDWNz8QmJUYfuIlceQg7wF4WPYj09SgXbfzc/7VP7A5SAplY5CdFzkFEk8wByI/R6o4HqowAmsXf+bml0PZCTzW6QNo49KXUL0MD45uRp3PYwXf7TLvJMV258CAXo7Z05VA+N1dwe05RCd4AddxBb5M+Jw9vySFyaOQ4ODfy2DBCij68Q84t6dValvGbtleu61hKpEFqiQXrQHvEfALhQuHH5eBfWbrcNc3HdRqXX76m1NT6CPTLTBoCEmfWoWFQkrnQQe1p6C1ZppatEvC7MS66aH7/soeiHFuQtHhnjrB4p3Ngz2gHDSt7dOjmP8GbvDQZQL68TwSkjJ1qF/CBEVDq17qWrE7xroIRsvYsD6XLcB4RsbDxTQTbeQIl/01fGF0qvlDD0r4JP5mHMtDX x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4425.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(376002)(366004)(136003)(39860400002)(396003)(55016002)(33656002)(316002)(6636002)(26005)(186003)(110136005)(5660300002)(19627235002)(6506007)(71200400001)(53546011)(7696005)(52536014)(66556008)(2906002)(478600001)(86362001)(66446008)(64756008)(966005)(66476007)(66946007)(8676002)(8936002)(76116006)(9686003)(921003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: sZc1vytdUWU6o5OrtvSs4UsITwVi+2C5fQ4XOWagZUazka44fg47z6db+cDlhAb6PSWcrihN7NmL/5/AtYPu1sJpodW9tblOUQoBBM5x1SG01yOnKXDMD6oJkCPqG+pEY6uyRs4rZ9AuFVhi0feIgsC6y7mvDbZua/hY1j3PxFGnN6YyhckNDZSShlC9mf1OjM/z0xPlcu/RfNx/zlmYwtpKu7tCCFl1UlzCIStplc8W6dOpg3Uj1V93dyvwa8bl17nEeaHHrzEimGmqwWP8mcgm7R23/cjSkUHz04XQ0CBVjrCr7Yrhjtj/H6dPf7i1abn9T6GHeJX6mG4Ebq2Eplw6qHd5BxMlMWTgcMBpSKxkk/dhct6i211YahmoAapkktvU0uSqnh5e9gjmJVxgiXs0Rjhg4YDhPbObBUhdHjUH6P4Hn/mBDgD2XtQArzBsO1YHDIJP6LSd2BRe8YoGAXMmn1mjtbTDc8lggZwRN8ShLgFy3732BESZldDdQVxP MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8bafe66d-b106-4d69-02e6-08d7f7ce0dcf X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2020 06:14:26.1299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0/tqW+NI0n1BXR5rqoWCAM9bguRjuiA/KiWJO0hFQkQ+MxKRzSjahTQHtxYiB0gL0CmttblMIgHVQ70V2lpOKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2747 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable New patch set send to my fork branch: https://github.com/ZhichaoGao/edk2/co= mmits/deprecated_algo Take all the comments and add Jian's R-B. V5 changes: Fix incorrect symbol in patch #2. Separate the patch #8 OpensslLib changes and create it thru change the proc= ess_files.pl. Change the incorrect Author Name of patch #2, #4, #6. Thanks, Zhichao > -----Original Message----- > From: Wang, Jian J > Sent: Thursday, May 14, 2020 1:12 PM > To: Gao, Zhichao ; devel@edk2.groups.io; Fu, Siyua= n > ; Kinney, Michael D ; Ya= o, > Jiewen ; Philippe Mathieu-Daude = ; > Lu, XiaoyuX > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated functions >=20 > Zhichao >=20 >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Thursday, May 14, 2020 10:49 AM > > To: Wang, Jian J ; devel@edk2.groups.io; Fu, > > Siyuan ; Kinney, Michael D > > ; Yao, Jiewen ; > > Philippe Mathieu-Daude ; Lu, XiaoyuX > > > > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated > > functions > > > > > > > -----Original Message----- > > > From: Wang, Jian J > > > Sent: Wednesday, May 13, 2020 9:49 PM > > > To: Gao, Zhichao ; devel@edk2.groups.io; Fu, > > > Siyuan ; Kinney, Michael D > > > ; Yao, Jiewen ; > > > Philippe Mathieu-Daude > > ; > > > Lu, XiaoyuX > > > Subject: RE: [PATCH V4 00/11] CryptoPkg: Retire the deprecated > > > functions > > > > > > Zhichao, > > > > > > Two general comments for improvement needed in your future patches: > > > 1. Add r-b for those patch files which have got r-b 2. It'd be > > > better to add summary of changes between this and previous version > > > of patches > > > > 1. I change the typo of the function definition. So all the patches are= changed. > > That is why I didn't keep any R-B > > 2. I put the summary change in cover-letter. Thanks for the > > suggestion. I would put the changes for every patch but not put them i= n the > commit message. > > > > > > > > For v4, > > > patch 8: the updates of OpensslLib should be done by > > > process_files.pl > > > > I didn't find the config string to disable the AES ECB mode only. Can > > you help guide me on this? Or should I remove the change of OpensslLib = in > patch #8? >=20 > You can remove those files from .inf by excluding them from @cryptofileli= st and > @sslfilelist in process_files.pl. Don't manually remove anything from > autogenerated content in inf file. >=20 > Regards, > Jian > > > > Thanks, > > Zhichao > > > > > > > > With this addressed (for the whole patch series), > > > > > > Reviewed-by: Jian J Wang > > > > > > > > > Mike, Jiewen, Siyuan, Philippe: any more comments for v4? > > > > > > Regards, > > > Jian > > > > > > > -----Original Message----- > > > > From: Gao, Zhichao > > > > Sent: Tuesday, May 12, 2020 2:27 AM > > > > To: devel@edk2.groups.io > > > > Cc: Wang, Jian J ; Lu, XiaoyuX > > > > ; Fu, Siyuan ; Kinney, > > > > Michael D ; Yao, Jiewen > > > > ; Philippe Mathieu-Daude > > > > Subject: [PATCH V4 00/11] CryptoPkg: Retire the deprecated > > > > functions > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1898 > > > > > > > > Retire below deprecated functions: > > > > MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1. > > > > > > > > V2: > > > > Seprate the MD5 and SHA1 changes to other patch set. > > > > Change the deprecated function wrapper implementatuion in > > > > EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug > > > > message and assert. > > > > > > > > V3: > > > > Remove the missing part of deprecated functions in V2. > > > > Change the name field in the EDKII_CRYPTO_PROTOCOL to indicate the > > > > function is deprecated and unsupported. > > > > > > > > V4: > > > > Fixed some typos. > > > > Separate the change of OpensslLib and make the change with > > > > process_files.pl. > > > > Moving the incorrect changes of AES_ECB from HAMC MD5 patch to Aes > > > > Ecb one. > > > > > > > > Cc: Jian J Wang > > > > Cc: Xiaoyu Lu > > > > Cc: Siyuan Fu > > > > Cc: Michael D Kinney > > > > Cc: Jiewen Yao > > > > Cc: Philippe Mathieu-Daude > > > > Signed-off-by: Zhichao Gao > > > > > > > > Zhichao Gao (8): > > > > CryptoPkg/CryptoDxe: Add function to indicate the deprecated algo= rithm > > > > CryptoPkg/BaseCrpytLib: Retire MD4 algorithm > > > > CryptoPkg/BaseCryptLib: Retire ARC4 algorithm > > > > CryptoPkg/BaseCryptLib: Retire the Tdes algorithm > > > > CryptoPkg/BaseCryptLib: Retire Aes Ecb mode algorithm > > > > CryptoPkg/BaseCryptLib: Retire HMAC MD5 algorithm > > > > CryptoPkg/BaseCryptLib: Retire HMAC SHA1 algorithm > > > > CryptoPkg/Crypto.h: Update the version of Crypto Driver > > > > > > > > Zhiguang Liu (3): > > > > CryptoPkg/OpensslLib: Set MD4 disable in OpensslLib > > > > CryptoPkg/OpensslLib: Set ARC4 disable in OpensslLib > > > > CryptoPkg/OpensslLib: Set TDES disable in OpensslLib > > > > > > > > CryptoPkg/CryptoPkg.dsc | 46 +- > > > > CryptoPkg/Driver/Crypto.c | 786 ++--------- > > > > CryptoPkg/Include/Library/BaseCryptLib.h | 809 ------------ > > > > .../Library/BaseCryptLib/BaseCryptLib.inf | 7 +- > > > > .../Library/BaseCryptLib/Cipher/CryptAes.c | 114 -- > > > > .../BaseCryptLib/Cipher/CryptAesNull.c | 52 - > > > > .../Library/BaseCryptLib/Cipher/CryptArc4.c | 205 --- > > > > .../BaseCryptLib/Cipher/CryptArc4Null.c | 124 -- > > > > .../Library/BaseCryptLib/Cipher/CryptTdes.c | 364 ------ > > > > .../BaseCryptLib/Cipher/CryptTdesNull.c | 160 --- > > > > .../Library/BaseCryptLib/Hash/CryptMd4.c | 223 ---- > > > > .../Library/BaseCryptLib/Hash/CryptMd4Null.c | 143 -- > > > > .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 216 --- > > > > .../BaseCryptLib/Hmac/CryptHmacMd5Null.c | 139 -- > > > > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 216 --- > > > > .../BaseCryptLib/Hmac/CryptHmacSha1Null.c | 139 -- > > > > .../Library/BaseCryptLib/PeiCryptLib.inf | 11 +- > > > > .../Library/BaseCryptLib/PeiCryptLib.uni | 8 +- > > > > CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c | 7 +- > > > > .../Library/BaseCryptLib/RuntimeCryptLib.inf | 11 +- > > > > .../Library/BaseCryptLib/RuntimeCryptLib.uni | 8 +- > > > > .../Library/BaseCryptLib/SmmCryptLib.inf | 12 +- > > > > .../Library/BaseCryptLib/SmmCryptLib.uni | 8 +- > > > > .../BaseCryptLibNull/BaseCryptLibNull.inf | 5 - > > > > .../BaseCryptLibNull/Cipher/CryptAesNull.c | 52 - > > > > .../BaseCryptLibNull/Cipher/CryptArc4Null.c | 124 -- > > > > .../BaseCryptLibNull/Cipher/CryptTdesNull.c | 160 --- > > > > .../BaseCryptLibNull/Hash/CryptMd4Null.c | 143 -- > > > > .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c | 139 -- > > > > .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c | 139 -- > > > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 1157 ++-----------= ---- > > > > .../Library/Include/openssl/opensslconf.h | 9 + > > > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 28 - > > > > .../Library/OpensslLib/OpensslLibCrypto.inf | 28 - > > > > CryptoPkg/Library/OpensslLib/process_files.pl | 3 + > > > > CryptoPkg/Private/Protocol/Crypto.h | 709 ++-------- > > > > 36 files changed, 402 insertions(+), 6102 deletions(-) delete > > > > mode > > > > 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptArc4Null.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdes.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Cipher/CryptTdesNull.c > > > > delete mode 100644 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Hash/CryptMd4Null.c > > > > delete mode 100644 > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptArc4Null.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLibNull/Cipher/CryptTdesNull.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLibNull/Hash/CryptMd4Null.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacMd5Null.c > > > > delete mode 100644 > > > > CryptoPkg/Library/BaseCryptLibNull/Hmac/CryptHmacSha1Null.c > > > > > > > > -- > > > > 2.21.0.windows.1 > > > > > >=20